)]}'
{"keystonemiddleware/tests/test_audit_middleware.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bd39de81086c5ea0c3142299132670e1c04ec626","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertEqual(\u0027/foo/bar\u0027, call_args[2][\u0027requestPath\u0027])"},{"line_number":87,"context_line":"            self.assertEqual(\u0027pending\u0027, call_args[2][\u0027outcome\u0027])"},{"line_number":88,"context_line":"            self.assertNotIn(\u0027reason\u0027, call_args[2])"},{"line_number":89,"context_line":"            self.assertNotIn(\u0027reporterchain\u0027, call_args[2])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Check second notification with request + response"},{"line_number":92,"context_line":"            call_args \u003d notify.call_args_list[1][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ccafa77b","line":89,"updated":"2015-01-27 16:48:22.000000000","message":"should be able to check the request environment has the cadf_event as expected.","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"09c215d7ed25d404f9ab522e30c807de784a8a08","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self.assertEqual(\u0027/foo/bar\u0027, call_args[2][\u0027requestPath\u0027])"},{"line_number":87,"context_line":"            self.assertEqual(\u0027pending\u0027, call_args[2][\u0027outcome\u0027])"},{"line_number":88,"context_line":"            self.assertNotIn(\u0027reason\u0027, call_args[2])"},{"line_number":89,"context_line":"            self.assertNotIn(\u0027reporterchain\u0027, call_args[2])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            # Check second notification with request + response"},{"line_number":92,"context_line":"            call_args \u003d notify.call_args_list[1][0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_ad864c63","line":89,"in_reply_to":"1a930d6b_ccafa77b","updated":"2015-01-29 22:28:52.000000000","message":"Done","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bd39de81086c5ea0c3142299132670e1c04ec626","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.assertIn(\u0027reason\u0027, call_args[2])"},{"line_number":97,"context_line":"            self.assertIn(\u0027reporterchain\u0027, call_args[2])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            self.assertEqual(notify.call_args_list[0][0][2][\u0027id\u0027],"},{"line_number":100,"context_line":"                             notify.call_args_list[1][0][2][\u0027id\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_api_request_failure(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ac8edb2b","line":99,"updated":"2015-01-27 16:48:22.000000000","message":"Add a comment that this is verifying that the event is stored in the request environment rather than in the middleware. Alternatively, add a new test with a better name.","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"09c215d7ed25d404f9ab522e30c807de784a8a08","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.assertIn(\u0027reason\u0027, call_args[2])"},{"line_number":97,"context_line":"            self.assertIn(\u0027reporterchain\u0027, call_args[2])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            self.assertEqual(notify.call_args_list[0][0][2][\u0027id\u0027],"},{"line_number":100,"context_line":"                             notify.call_args_list[1][0][2][\u0027id\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_api_request_failure(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_8d834855","line":99,"in_reply_to":"1a930d6b_ac8edb2b","updated":"2015-01-29 22:28:52.000000000","message":"Done","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bd39de81086c5ea0c3142299132670e1c04ec626","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            self.assertEqual(notify.call_args_list[0][0][2][\u0027id\u0027],"},{"line_number":100,"context_line":"                             notify.call_args_list[1][0][2][\u0027id\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_api_request_failure(self):"},{"line_number":103,"context_line":"        middleware \u003d audit.AuditMiddleware("},{"line_number":104,"context_line":"            FakeFailingApp(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_ac0a5b87","line":101,"updated":"2015-01-27 16:48:22.000000000","message":"Should be able to add a test that if a request is made that sends an audit event and then another request is made with no audit event then the second request doesn\u0027t send an audit event.","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"36b51d9f0150552ea7a27827d1c800b29739986f","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"            self.assertEqual(notify.call_args_list[0][0][2][\u0027id\u0027],"},{"line_number":100,"context_line":"                             notify.call_args_list[1][0][2][\u0027id\u0027])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_api_request_failure(self):"},{"line_number":103,"context_line":"        middleware \u003d audit.AuditMiddleware("},{"line_number":104,"context_line":"            FakeFailingApp(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_0dc5988d","line":101,"in_reply_to":"1a930d6b_ac0a5b87","updated":"2015-01-29 22:29:19.000000000","message":"done... i think?","commit_id":"c34e4b1a2a0d1a3b8602186362201c843e254994"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"de3eba272d9b26ad02f27ef4d05823672eb05eaf","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                   environ\u003dself._get_environ_header(\u0027GET\u0027))"},{"line_number":225,"context_line":"        with mock.patch(\u0027oslo.messaging.Notifier.info\u0027) as notify:"},{"line_number":226,"context_line":"            middleware._process_response(req2, webob.response.Response())"},{"line_number":227,"context_line":"            self.assertTrue(notify.called)"},{"line_number":228,"context_line":"            # ensure event is not the same across requests"},{"line_number":229,"context_line":"            self.assertNotEqual(req.environ[\u0027cadf_event\u0027].id,"},{"line_number":230,"context_line":"                                notify.call_args_list[0][0][2][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_165b4f55","line":227,"updated":"2015-02-01 15:47:20.000000000","message":"To test this I think we want this second request to not generate an audit event of its own... isn\u0027t that the problem, that if the first request generates an audit event then the next requests, if it doesn\u0027t generate its own event, will get the same event?","commit_id":"ef6da0099431d67cb176723466f2927bcddc345c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1054373d8afdbc23b90155713b08590ef57e4722","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                                   environ\u003dself._get_environ_header(\u0027GET\u0027))"},{"line_number":225,"context_line":"        with mock.patch(\u0027oslo.messaging.Notifier.info\u0027) as notify:"},{"line_number":226,"context_line":"            middleware._process_response(req2, webob.response.Response())"},{"line_number":227,"context_line":"            self.assertTrue(notify.called)"},{"line_number":228,"context_line":"            # ensure event is not the same across requests"},{"line_number":229,"context_line":"            self.assertNotEqual(req.environ[\u0027cadf_event\u0027].id,"},{"line_number":230,"context_line":"                                notify.call_args_list[0][0][2][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_c5d657c5","line":227,"in_reply_to":"da86d52c_165b4f55","updated":"2015-02-02 03:45:15.000000000","message":"no. the problem is we don\u0027t want different requests reusing the same event. ie. each request should have it\u0027s own unique event... each request should generate it\u0027s own unique event which is why this tests that each the two requests had different event ids.","commit_id":"ef6da0099431d67cb176723466f2927bcddc345c"}]}