)]}'
{"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5419f8ae84427404d2135b36e16efd601fa2114d","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self._token_cache \u003d self._token_cache_factory()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        revocation_cache_timeout \u003d datetime.timedelta("},{"line_number":521,"context_line":"            seconds\u003dint(self._conf_get(\u0027revocation_cache_time\u0027)))"},{"line_number":522,"context_line":"        self._revocations \u003d _revocations.Revocations(revocation_cache_timeout,"},{"line_number":523,"context_line":"                                                     self._signing_directory,"},{"line_number":524,"context_line":"                                                     self._identity_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0e41dda8","line":521,"updated":"2015-03-08 11:05:27.000000000","message":"the config is defined as int in line 275, should this be already returning an int()?  why do we need to convert to int() again","commit_id":"27b5a587888bafa921106373380aec72ca25157f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"6c3e520608c9b502572c7093b44346470bb3f217","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self._token_cache \u003d self._token_cache_factory()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        revocation_cache_timeout \u003d datetime.timedelta("},{"line_number":521,"context_line":"            seconds\u003dint(self._conf_get(\u0027revocation_cache_time\u0027)))"},{"line_number":522,"context_line":"        self._revocations \u003d _revocations.Revocations(revocation_cache_timeout,"},{"line_number":523,"context_line":"                                                     self._signing_directory,"},{"line_number":524,"context_line":"                                                     self._identity_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_6eccf089","line":521,"in_reply_to":"9a80dd14_0e41dda8","updated":"2015-03-09 21:20:15.000000000","message":"the default value is an int, but we can\u0027t assume the user will use such value in the conf (check the reported bug).","commit_id":"27b5a587888bafa921106373380aec72ca25157f"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2ccc4c25cf6ad3913ea2b9c48d0755bfcc3be248","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self._token_cache \u003d self._token_cache_factory()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        revocation_cache_timeout \u003d datetime.timedelta("},{"line_number":521,"context_line":"            seconds\u003dint(self._conf_get(\u0027revocation_cache_time\u0027)))"},{"line_number":522,"context_line":"        self._revocations \u003d _revocations.Revocations(revocation_cache_timeout,"},{"line_number":523,"context_line":"                                                     self._signing_directory,"},{"line_number":524,"context_line":"                                                     self._identity_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e2119e54","line":521,"in_reply_to":"9a80dd14_3bb87329","updated":"2015-03-10 19:49:56.000000000","message":"Agree with Lin, this should be fixed a while ago. \n\nIf the value is set in CONF then oslo.config will handle converting this to an int.\nIf the value is set via paste or overrides then the _conf_values_type_convert function above should handle converting it to an int.\n\nAre you sure this is reproducible with a current auth_token?","commit_id":"27b5a587888bafa921106373380aec72ca25157f"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"7406ff5744e036640d49f9f425b9bf635deea9c5","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self._token_cache \u003d self._token_cache_factory()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        revocation_cache_timeout \u003d datetime.timedelta("},{"line_number":521,"context_line":"            seconds\u003dint(self._conf_get(\u0027revocation_cache_time\u0027)))"},{"line_number":522,"context_line":"        self._revocations \u003d _revocations.Revocations(revocation_cache_timeout,"},{"line_number":523,"context_line":"                                                     self._signing_directory,"},{"line_number":524,"context_line":"                                                     self._identity_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_3bb87329","line":521,"in_reply_to":"9a80dd14_6eccf089","updated":"2015-03-09 22:56:58.000000000","message":"it is not just the default value, but the type is an int as well. from what I understand config return the right type when the user tries to read it. so I\u0027m not sure if we really need to do additional conversion here.\n\nit wasn\u0027t clear what string value in the bug report was having issue","commit_id":"27b5a587888bafa921106373380aec72ca25157f"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"788c094022720cf20d63dfb723a0bf974be7519d","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self._token_cache \u003d self._token_cache_factory()"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        revocation_cache_timeout \u003d datetime.timedelta("},{"line_number":521,"context_line":"            seconds\u003dint(self._conf_get(\u0027revocation_cache_time\u0027)))"},{"line_number":522,"context_line":"        self._revocations \u003d _revocations.Revocations(revocation_cache_timeout,"},{"line_number":523,"context_line":"                                                     self._signing_directory,"},{"line_number":524,"context_line":"                                                     self._identity_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a28166fd","line":521,"in_reply_to":"9a80dd14_e2119e54","updated":"2015-03-10 20:01:30.000000000","message":"ahh, didn\u0027t know about that... So I believe this change should be abandoned and the bug closed since this was already fixed by using oslo.config.","commit_id":"27b5a587888bafa921106373380aec72ca25157f"}]}