)]}'
{"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8a5317d3e50b3ace4b29dfc18977a862bd4c8156","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            interface_name \u003d v3_endpoint[\u0027interface\u0027].lower() + \u0027URL\u0027"},{"line_number":463,"context_line":"            region[interface_name] \u003d v3_endpoint[\u0027url\u0027]"},{"line_number":464,"context_line":"            if v3_endpoint[\u0027interface\u0027] \u003d\u003d \u0027public\u0027 and \u0027id\u0027 in v3_endpoint:"},{"line_number":465,"context_line":"                region[\u0027id\u0027] \u003d v3_endpoint[\u0027id\u0027]"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        v2_service[\u0027endpoints\u0027] \u003d list(regions.values())"},{"line_number":468,"context_line":"        v2_services.append(v2_service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_aeef64af","line":465,"updated":"2015-04-30 13:42:47.000000000","message":"I don\u0027t think this should be \u0027region\u0027.  It is an endpoint for a region that is being built here.  Perhaps it could be called \u0027regional_endpoint\u0027.  I only picked up on this because it looked like the region id was being set to be the endpoint id - which would have been wrong.  I know it\u0027s not your code but while you\u0027re in here....","commit_id":"b80ceb916b02ced5def9b5e83bc2520837b80a7d"}],"keystonemiddleware/auth_token/_request.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"196ec6ea375283df3f67b4ad4fb75828f811ded3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        for v3_endpoint in v3_service.get(\u0027endpoints\u0027, []):"},{"line_number":40,"context_line":"            region_name \u003d v3_endpoint.get(\u0027region\u0027)"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                region \u003d regions[region_name]"},{"line_number":43,"context_line":"            except KeyError:"},{"line_number":44,"context_line":"                region \u003d {\u0027region\u0027: region_name} if region_name else {}"},{"line_number":45,"context_line":"                regions[region_name] \u003d region"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1aab0776","side":"PARENT","line":42,"updated":"2015-09-14 20:29:52.000000000","message":"the left side of this is a v2 endpoint, not a region... all this code is super confusing as a result.","commit_id":"ec0c41b685ad85c37428c862ed9b9cdb1fda4d80"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"63941e1ec69df51fd2ee6e97ed599e60b56d6d32","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        for v3_endpoint in v3_service.get(\u0027endpoints\u0027, []):"},{"line_number":40,"context_line":"            region_name \u003d v3_endpoint.get(\u0027region\u0027)"},{"line_number":41,"context_line":"            try:"},{"line_number":42,"context_line":"                region \u003d regions[region_name]"},{"line_number":43,"context_line":"            except KeyError:"},{"line_number":44,"context_line":"                region \u003d {\u0027region\u0027: region_name} if region_name else {}"},{"line_number":45,"context_line":"                regions[region_name] \u003d region"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1a2d47a7","side":"PARENT","line":42,"in_reply_to":"ba15a1d1_1aab0776","updated":"2015-09-14 20:43:26.000000000","message":"I agree that the original author(s) didn\u0027t name things very well and it does confuse things... I didn\u0027t create that here, just didn\u0027t try to clean it up. I can rename it if I need to put up another patch, or if you think that\u0027s really important.","commit_id":"ec0c41b685ad85c37428c862ed9b9cdb1fda4d80"}],"keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py":[{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8a5317d3e50b3ace4b29dfc18977a862bd4c8156","unresolved":false,"context_lines":[{"line_number":2152,"context_line":""},{"line_number":2153,"context_line":"        auth_ref \u003d access.AccessInfo.factory(body\u003dtoken)"},{"line_number":2154,"context_line":"        catalog_data \u003d auth_ref.service_catalog.get_data()"},{"line_number":2155,"context_line":"        # account for ids missing from keystoneclient fixtures"},{"line_number":2156,"context_line":"        for v3_service in catalog_data:"},{"line_number":2157,"context_line":"            for x in range(len(v3_service.get(\u0027endpoints\u0027, []))):"},{"line_number":2158,"context_line":"                if \u0027id\u0027 not in v3_service[\u0027endpoints\u0027][x]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_4ed1f0cc","line":2155,"updated":"2015-04-30 13:42:47.000000000","message":"Likewise, while you\u0027re in here, perhaps the test could be extended a little to validate the code with more than one service, and possibly more than one endpoint group for a service.  Given that a lot of this is to do with how the data is grouped in the catalog we should give the code a chance to get it wrong?","commit_id":"b80ceb916b02ced5def9b5e83bc2520837b80a7d"}],"keystonemiddleware/tests/unit/auth_token/test_request.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"32922020f26c720022e6add813538f19fd582139","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        for v3_service in catalog_data:"},{"line_number":215,"context_line":"            for x in range(len(v3_service.get(\u0027endpoints\u0027, []))):"},{"line_number":216,"context_line":"                if \u0027id\u0027 not in v3_service[\u0027endpoints\u0027][x]:"},{"line_number":217,"context_line":"                    v3_service[\u0027endpoints\u0027][x][\u0027id\u0027] \u003d \u0027endpt\u0027 + str(x)"},{"line_number":218,"context_line":"        catalog \u003d _request._v3_to_v2_catalog(catalog_data)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        self.assertEqual(1, len(catalog))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_d5d56043","line":217,"updated":"2015-09-14 20:50:45.000000000","message":"How about improving the actual fixtures instead? Use Depends-On: \u003cChange-Id\u003e in this review to create a cross-project review dependency.","commit_id":"beeb4d9623fb74c96a1c66b4b537e3b1d130e56d"}]}