)]}'
{"keystonemiddleware/tests/unit/auth_token/base.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.cfg \u003d self.useFixture(cfg_fixture.Config())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"},{"line_number":34,"context_line":"    def create_middleware(cls, cb, conf\u003dNone):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        @webob.dec.wsgify"},{"line_number":37,"context_line":"        def _do_cb(req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_e378fc91","line":34,"updated":"2015-04-29 16:25:36.000000000","message":"I don\u0027t see cls used so no need for classmethod.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                 status\u003d\u0027200 OK\u0027,"},{"line_number":45,"context_line":"                                 body\u003d\u0027\u0027,"},{"line_number":46,"context_line":"                                 headers\u003dNone,"},{"line_number":47,"context_line":"                                 conf\u003dNone):"},{"line_number":48,"context_line":"        def cb(req):"},{"line_number":49,"context_line":"            resp \u003d webob.Response(body, status)"},{"line_number":50,"context_line":"            resp.headers.update(headers or {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c3f2a006","line":47,"updated":"2015-04-29 16:25:36.000000000","message":"A docstring would explain why we need both create_middleware and create_simple_middleware.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return cls.create_middleware(cb, conf)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @classmethod"},{"line_number":56,"context_line":"    def call(cls, middleware, method\u003d\u0027GET\u0027, path\u003d\u0027/\u0027, headers\u003dNone):"},{"line_number":57,"context_line":"        req \u003d webob.Request.blank(path)"},{"line_number":58,"context_line":"        req.method \u003d method"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c3dce048","line":56,"updated":"2015-04-29 16:25:36.000000000","message":"this could use a docstring to explain what it returns.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"}],"keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    @webob.dec.wsgify"},{"line_number":195,"context_line":"    def __call__(self, req):"},{"line_number":196,"context_line":"        for k, v in self.expected_env.items():"},{"line_number":197,"context_line":"            assert req.environ[k] \u003d\u003d v, \u0027%s !\u003d %s\u0027 % (req.environ[k], v)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        resp \u003d webob.Response()"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_23c5d45a","line":197,"updated":"2015-04-29 16:25:36.000000000","message":"suggest do env \u003d req.environ then don\u0027t need to change all these lines.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            v3_default_service_env_additions)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"class BaseAuthTokenMiddlewareTest(base.BaseAuthTokenTestCase):"},{"line_number":278,"context_line":"    \"\"\"Base test class for auth_token middleware."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    All the tests allow for running with auth_token"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_03b658dc","line":277,"updated":"2015-04-29 16:25:36.000000000","message":"we seem to have 2 tests that have essentially the same name... why not merge?","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        self.response_headers \u003d None"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def call_middleware(self, **kwargs):"},{"line_number":312,"context_line":"        return self.call(self.middleware, **kwargs)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _setup_signing_directory(self):"},{"line_number":315,"context_line":"        directory_name \u003d self.useFixture(fixtures.TempDir()).path"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c3fd0070","line":312,"updated":"2015-04-29 16:25:36.000000000","message":"This method doesn\u0027t seem to be adding much, suggest remove it.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        conf \u003d {"},{"line_number":638,"context_line":"            \u0027revocation_cache_time\u0027: \u00271\u0027"},{"line_number":639,"context_line":"        }"},{"line_number":640,"context_line":"        self.create_simple_middleware(conf\u003dconf)"},{"line_number":641,"context_line":"        self.assertLastPath(None)"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def test_auth_with_no_token_does_not_call_http(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_89dde972","line":640,"updated":"2015-04-29 16:25:36.000000000","message":"set_middleware still exists, why not use it?","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":723,"context_line":"            self.get_revocation_list_json())"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        token \u003d self.token_dict[\u0027revoked_token\u0027]"},{"line_number":726,"context_line":"        resp \u003d self.call_middleware(headers\u003d{\u0027X-Auth-Token\u0027: token})"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"        self.assertEqual(401, resp.status_int)"},{"line_number":729,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_09d3193a","line":726,"updated":"2015-04-29 16:25:36.000000000","message":"seems like we could have a self.call_middleware(token\u003dtoken) rather than have to set the header all the time.\n\nAlso, if we\u0027re just going to use assertEqual(401) etc, all the time, put that in a function.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0292b62731ae436b651dad4f69585710ac81ceb9","unresolved":false,"context_lines":[{"line_number":2151,"context_line":"        conf \u003d {\u0027auth_uri\u0027: \u0027http://local.test\u0027}"},{"line_number":2152,"context_line":"        status \u003d \u0027401 Unauthorized\u0027"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"        middleware \u003d self.create_simple_middleware(status\u003dstatus, conf\u003dconf)"},{"line_number":2155,"context_line":"        self.assertFalse(middleware._delay_auth_decision)"},{"line_number":2156,"context_line":""},{"line_number":2157,"context_line":"        for v in (\u0027True\u0027, \u00271\u0027, \u0027on\u0027, \u0027yes\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_1b88fc21","line":2154,"updated":"2015-04-29 16:25:36.000000000","message":"this seems like overkill.","commit_id":"fed48721126479e5b0be1d4379562e5c47ea1970"}]}
