)]}'
{"id":"openstack%2Fkeystonemiddleware~171264","triplet_id":"openstack%2Fkeystonemiddleware~master~I012bbd45d208c7643b29e5f32fa903724cb87765","project":"openstack/keystonemiddleware","branch":"master","topic":"bug/1463009","hashtags":[],"change_id":"I012bbd45d208c7643b29e5f32fa903724cb87765","subject":"Correct memcached parameters in TokenCache","status":"ABANDONED","created":"2015-04-07 16:05:47.000000000","updated":"2015-12-01 08:02:55.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"431883e1c45049b6025be78d846185925ce82f01","_number":171264,"virtual_id_number":171264,"owner":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-10-13 10:17:22.000000000","_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"date":"2015-11-30 20:14:07.000000000","_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"date":"2015-10-13 16:55:22.000000000","_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"date":"2015-11-27 07:38:38.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2015-10-08 15:19:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"value":-1,"date":"2015-06-08 18:47:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"value":-1,"date":"2015-10-13 10:07:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":-2,"date":"2015-12-01 08:02:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":-1,"date":"2015-08-13 15:39:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"date":"2015-10-13 10:06:51.000000000","_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-07 16:08:56.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2015-06-01 13:18:36.000000000","updated_by":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"reviewer":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"state":"REVIEWER"},{"updated":"2015-06-02 18:36:37.000000000","updated_by":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"reviewer":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"state":"REVIEWER"},{"updated":"2015-06-08 18:47:57.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2015-08-13 15:39:43.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2015-10-08 15:19:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-13 10:06:51.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2015-10-13 10:17:22.000000000","updated_by":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"reviewer":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"state":"REVIEWER"},{"updated":"2015-10-13 16:55:22.000000000","updated_by":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"reviewer":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"state":"REVIEWER"},{"updated":"2015-11-27 07:38:38.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-01 08:02:07.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"}],"messages":[{"id":"84463dfeae2bee9a5f3aa121b2d8e3c73433881e","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2015-04-07 16:05:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b2ed3975d47bafbfa5c355396d50987545a230a","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-04-07 16:08:56.000000000","message":"Patch Set 1:\n\nunit tests would be nice.","accounts_in_message":[],"_revision_number":1},{"id":"11a269256a86d3bf97af0ad729f75a8c1bb1aee8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-07 17:57:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-keystonemiddleware-python26 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python26/27099c6/ : SUCCESS in 1m 04s\n- gate-keystonemiddleware-pep8 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-pep8/0541c92/ : SUCCESS in 57s\n- gate-keystonemiddleware-docs http://docs-draft.openstack.org/64/171264/1/check/gate-keystonemiddleware-docs/aa891ae//doc/build/html/ : SUCCESS in 1m 14s\n- gate-keystonemiddleware-python27 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python27/c631982/ : SUCCESS in 1m 20s\n- gate-keystonemiddleware-python34 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python34/3a12fb6/ : SUCCESS in 3m 12s\n- gate-tempest-dsvm-neutron-src-keystonemiddleware-icehouse http://logs.openstack.org/64/171264/1/check/gate-tempest-dsvm-neutron-src-keystonemiddleware-icehouse/f98858a/ : FAILURE in 29m 10s\n- gate-tempest-dsvm-neutron-src-keystonemiddleware-juno http://logs.openstack.org/64/171264/1/check/gate-tempest-dsvm-neutron-src-keystonemiddleware-juno/596b592/ : FAILURE in 17m 56s\n- gate-tempest-dsvm-neutron-src-keystonemiddleware http://logs.openstack.org/64/171264/1/check/gate-tempest-dsvm-neutron-src-keystonemiddleware/8d139ce/ : SUCCESS in 57m 16s","accounts_in_message":[],"_revision_number":1},{"id":"7c12df93f583919a4c2490cfdd56d67513620fd9","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-05-05 14:53:07.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027m not sure about unit tests here.  I\u0027ve looked pretty hard at this.  Because none of the openstack code cares whether it is integers or tuples the best I could get to is to monkey patch a method that verifies the parameters being passed into the memcache instantiation being integers rather than tuples.  If we added unit tests to verify that all objects were instantiated with parameters that matched the documented types of the classes used we\u0027d have an awful lot of test code.  As it stands memcache couldn\u0027t work as intended.  A tuple isn\u0027t a duck and our code is broken.","accounts_in_message":[],"_revision_number":1},{"id":"5be2ae90fe2e4b03968994e7f3da6c36e2dfca23","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-05-05 15:12:30.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"29b53121c7d19e6b7ef15e3b7e9085bf6e243f3b","author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"date":"2015-05-06 11:23:04.000000000","message":"Patch Set 1:\n\nHow was this supposed to be working before ?","accounts_in_message":[],"_revision_number":1},{"id":"bd0f1a90a70aa12e9a2aad02e595a46d2f7611db","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-06-01 10:18:36.000000000","message":"Patch Set 1:\n\nYes, I wondered that too, Samuel.","accounts_in_message":[],"_revision_number":1},{"id":"b3308fd85d59fd8b66c27839bba8b3273cce6ecb","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-06-01 10:21:24.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d717f8252e380d118050875ceab83d5dfbd73d89","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-01 10:49:01.000000000","message":"Patch Set 1:\n\nOh well. It did not work before in an interesting way: http://paste.openstack.org/show/252506/","accounts_in_message":[],"_revision_number":1},{"id":"d9857c83f07d06198d19e4b981941a15150d35f5","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-01 11:03:10.000000000","message":"Patch Set 1:\n\nAnd everything \"worked\" before because usage of _MemcacheClientPool by _cache.TokenCache is not tested at all.","accounts_in_message":[],"_revision_number":1},{"id":"7a736c1d86fd8c3471617f47367d79634af6cb65","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-01 11:19:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-keystonemiddleware-python26 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python26/54d4412/ : SUCCESS in 1m 10s\n- gate-keystonemiddleware-pep8 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-pep8/7b2f97a/ : SUCCESS in 1m 05s\n- gate-keystonemiddleware-docs http://docs-draft.openstack.org/64/171264/1/check/gate-keystonemiddleware-docs/6a46073//doc/build/html/ : SUCCESS in 1m 15s\n- gate-keystonemiddleware-python27 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python27/be13677/ : SUCCESS in 1m 01s\n- gate-keystonemiddleware-python34 http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-python34/2c2ac19/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-keystonemiddleware http://logs.openstack.org/64/171264/1/check/gate-tempest-dsvm-neutron-src-keystonemiddleware/8d67e13/ : SUCCESS in 53m 09s\n- gate-keystonemiddleware-tox-bandit http://logs.openstack.org/64/171264/1/check/gate-keystonemiddleware-tox-bandit/d6a3be6/ : SUCCESS in 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a86d43b9da70b633f66ef4f5a6e4429276251b61","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-01 12:52:18.000000000","message":"Patch Set 1: Code-Review-1\n\nLet\u0027s wait till 6/2 meeting, I\u0027d like to discuss something there.","accounts_in_message":[],"_revision_number":1},{"id":"34415cc87d58c44c2e89be5d4968187562bd265f","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-01 13:02:21.000000000","message":"Patch Set 1: Code-Review+1\n\nRight, we can\u0027t backport a drop of memcache_pool back to kilo","accounts_in_message":[],"_revision_number":1},{"id":"7739dfc0de5f14eb8d4863a3a3fd0071cabe188b","author":{"_account_id":9142,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@lsd.ufcg.edu.br","username":"samuel-z","inactive":true},"date":"2015-06-01 13:18:36.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM, thanks","accounts_in_message":[],"_revision_number":1},{"id":"431fa6df903274561341c472cc34ed945ff1d335","author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"date":"2015-06-02 18:36:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5fe42ac907621fa99ccc6f6875bc538a9fca782a","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-02 18:38:29.000000000","message":"Patch Set 1: Code-Review-1\n\nIs there a reason there\u0027s no unit tests? A comment in the commit message would explain it.","accounts_in_message":[],"_revision_number":1},{"id":"06f8bd26dd839216d2bb60a43122536d29c49c99","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-06-03 09:56:09.000000000","message":"Patch Set 1:\n\nThere is a reason I believe as I commented above.  But it\u0027s not really worth adding to the commit message I don\u0027t think.  If we added the comment to this commit then we could more or less add it to any commit.  If we\u0027re calling an external api with the wrong param types then we just need to correct it.  Unless we trace down every execution path to the instantiation in question and verify types at every point - or as I said above monkey patch some test code over an external api to the same purpose I cannot see how unit tests would work.  And doing the latter I don\u0027t think would add any value.","accounts_in_message":[],"_revision_number":1},{"id":"26fdfd5244fe9e3d6dfd844b143047e84a508d5f","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-06-03 09:56:51.000000000","message":"Patch Set 1:\n\nOr we could code in java instead. ;)","accounts_in_message":[],"_revision_number":1},{"id":"89d5b7e53ba3414dbea6a7c739af270b6bbb814c","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-03 13:41:43.000000000","message":"Patch Set 1:\n\nWhy did the tests pass before?","accounts_in_message":[],"_revision_number":1},{"id":"9f64aa6b805d0cada57c54b13a274faf1fecad5a","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-03 13:49:56.000000000","message":"Patch Set 1:\n\nBecause there are no tests involving both token validation and usage of memcache_pool as backend.","accounts_in_message":[],"_revision_number":1},{"id":"d5703bb73b29033d17030f9806db61b73dbc5562","author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"date":"2015-06-07 14:44:13.000000000","message":"Patch Set 1: -Code-Review\n\nLet\u0027s get some testing in place then.","accounts_in_message":[],"_revision_number":1},{"id":"a8d7cecc6be8ba3d2c1941f8859cdc8095e825eb","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-08 12:24:05.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"100a3f65b487488a4e9afad537d3984252cadf87","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-08 12:58:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9e4dc6aba2b027a755eb5aab546d77a264369ede","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-06-08 13:03:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0274e9f7039edcf0128e4ecc6199eee3a2e4a17a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 14:02:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-keystonemiddleware-pep8 http://logs.openstack.org/64/171264/4/check/gate-keystonemiddleware-pep8/fb6465d/ : SUCCESS in 1m 06s\n- gate-keystonemiddleware-docs http://docs-draft.openstack.org/64/171264/4/check/gate-keystonemiddleware-docs/a3359db//doc/build/html/ : SUCCESS in 1m 14s\n- gate-keystonemiddleware-python27 http://logs.openstack.org/64/171264/4/check/gate-keystonemiddleware-python27/52118b4/ : SUCCESS in 1m 17s\n- gate-keystonemiddleware-python34 http://logs.openstack.org/64/171264/4/check/gate-keystonemiddleware-python34/b1f7782/ : SUCCESS in 1m 58s\n- gate-tempest-dsvm-neutron-src-keystonemiddleware http://logs.openstack.org/64/171264/4/check/gate-tempest-dsvm-neutron-src-keystonemiddleware/23614fd/ : SUCCESS in 57m 46s\n- gate-keystonemiddleware-tox-bandit http://logs.openstack.org/64/171264/4/check/gate-keystonemiddleware-tox-bandit/58bb414/ : SUCCESS in 42s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"85f918d1d2c2f94f9b4ac39057844bce2c4ce779","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-06-08 18:47:57.000000000","message":"Patch Set 4: Code-Review-1\n\nThere are no tests for the code changes.","accounts_in_message":[],"_revision_number":4},{"id":"cdd49c76f1e65ca6a6546f2345043275948cf8f9","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2015-08-13 15:39:43.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nagree with David, tests would be nice so that we don\u0027t regress.","accounts_in_message":[],"_revision_number":4},{"id":"a3e5936356b0ba33baa9dfdea8e162569316548e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 15:19:35.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"b99da9ef195500485b000da4bf57e550e90f9ef8","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2015-10-13 10:07:29.000000000","message":"Patch Set 4: Code-Review-1\n\nThere needs further work to do.","accounts_in_message":[],"_revision_number":4},{"id":"4b83acf22d10031a104b5a8c15e274d60356151d","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-10-13 10:17:22.000000000","message":"Patch Set 4:\n\nI detailed why I have not added tests in my message Jun 3 10:56 AM. I agree that this bug wouldn\u0027t have arisen if there was a test to verify the calling of memcache but I can\u0027t easily see how that would be done.  If somebody can make some suggestions as to how this testing could be added then I can look at it again and maybe this bug could get closed.  I\u0027m stumped.","accounts_in_message":[],"_revision_number":4},{"id":"e402273bc57dee3fa8129900948519e123747d77","author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"date":"2015-10-13 10:46:44.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"7242ef15bbc4d3b551f7ab416cbdc04f6051788c","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2015-10-13 15:41:13.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nThe test should be mocking out memcached.","accounts_in_message":[],"_revision_number":4},{"id":"69dc1fd4f5a5897fc877e54211f65b7f1080f461","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2015-10-13 16:55:22.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"fe289f6546274455db6503c14c29c7ded149bb3c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-11-27 07:38:38.000000000","message":"Patch Set 4:\n\nplease rebase this against master, we\u0027ll get it through","accounts_in_message":[],"_revision_number":4},{"id":"5120a1c61788085f16d8e500e4bbee75f642267e","author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"date":"2015-11-30 20:14:07.000000000","message":"Patch Set 4:\n\nLooks like this has been made unnecessary by https://review.openstack.org/#/c/212341/ which merged in August -- although still didn\u0027t have tests :)  \n\nThis can probably be abandoned.","accounts_in_message":[],"_revision_number":4},{"id":"39cad5454b223406186dd6f95d1123c0abdbb81b","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-01 08:02:07.000000000","message":"Patch Set 4: Code-Review-2\n\nSteve McLellan is right, this is made obsolete by the cleanup that Jamie did.","accounts_in_message":[],"_revision_number":4},{"id":"226e870fe667790006b5f028be1c20bbd5c8bd4d","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-01 08:02:55.000000000","message":"Abandoned\n\nIssue already addressed by: https://review.openstack.org/#/c/212341/","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"cbb2e958d96f44e00b02b3bfd2b174318ab6c104","revisions":{"ccd5a721c948fd11320a871aa9090f37c360f539":{"kind":"REWORK","_number":1,"created":"2015-04-07 16:05:47.000000000","uploader":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"ref":"refs/changes/64/171264/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/64/171264/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/1"}}},"commit":{"parents":[{"commit":"319e02d08baf0c334c18f1b8b1f1a049d49a837a","subject":"Merge \"Rename requests mock object in testing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/319e02d08baf0c334c18f1b8b1f1a049d49a837a"}]}],"author":{"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","date":"2015-04-07 16:03:02.000000000","tz":-300},"committer":{"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","date":"2015-04-07 16:05:46.000000000","tz":-300},"subject":"Correct memcached parameters in TokenCache","message":"Correct memcached parameters in TokenCache\n\nTokenCache._memcache_pool_dead_retry and\nTokenCache._memcache_pool_maxsize end up as tuples because the lines\nthat store them end in commas. Both values should be integers; patch\nremoves the commas.\n\nChange-Id: I012bbd45d208c7643b29e5f32fa903724cb87765\nCloses-Bug: 1441238\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/ccd5a721c948fd11320a871aa9090f37c360f539"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/ccd5a721c948fd11320a871aa9090f37c360f539"}]},"branch":"refs/heads/master"},"209ffe5f3404ae9f8c9b7dd740d0a772a537749d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-06-08 12:24:05.000000000","uploader":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"ref":"refs/changes/64/171264/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/64/171264/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/2"}}},"commit":{"parents":[{"commit":"57d389da8aaef3f955d7f0b086803d98b6531a2e","subject":"Merge \"Fetch user token from request rather than env\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/57d389da8aaef3f955d7f0b086803d98b6531a2e"}]}],"author":{"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","date":"2015-04-07 16:03:02.000000000","tz":-300},"committer":{"name":"Boris Bobrov","email":"bbobrov@mirantis.com","date":"2015-06-08 12:24:05.000000000","tz":0},"subject":"Correct memcached parameters in TokenCache","message":"Correct memcached parameters in TokenCache\n\nTokenCache._memcache_pool_dead_retry and\nTokenCache._memcache_pool_maxsize end up as tuples because the lines\nthat store them end in commas. Both values should be integers; patch\nremoves the commas.\n\nChange-Id: I012bbd45d208c7643b29e5f32fa903724cb87765\nCloses-Bug: 1441238\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/209ffe5f3404ae9f8c9b7dd740d0a772a537749d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/209ffe5f3404ae9f8c9b7dd740d0a772a537749d"}]},"branch":"refs/heads/master"},"7d53e3a0e7b23d9413fa61e5a617d182add59eed":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2015-06-08 12:58:15.000000000","uploader":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"ref":"refs/changes/64/171264/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/64/171264/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/3"}}},"commit":{"parents":[{"commit":"7ad56112830d979ba9452edc743ce340386a4c6e","subject":"a test for memcache_pool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/7ad56112830d979ba9452edc743ce340386a4c6e"}]}],"author":{"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","date":"2015-04-07 16:03:02.000000000","tz":-300},"committer":{"name":"Boris Bobrov","email":"bbobrov@mirantis.com","date":"2015-06-08 12:57:00.000000000","tz":180},"subject":"Correct memcached parameters in TokenCache","message":"Correct memcached parameters in TokenCache\n\nTokenCache._memcache_pool_dead_retry and\nTokenCache._memcache_pool_maxsize end up as tuples because the lines\nthat store them end in commas. Both values should be integers; patch\nremoves the commas.\n\nChange-Id: I012bbd45d208c7643b29e5f32fa903724cb87765\nCloses-Bug: 1441238\nPartial-Bug: 1463009\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/7d53e3a0e7b23d9413fa61e5a617d182add59eed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/7d53e3a0e7b23d9413fa61e5a617d182add59eed"}]},"branch":"refs/heads/master"},"cbb2e958d96f44e00b02b3bfd2b174318ab6c104":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2015-06-08 13:03:58.000000000","uploader":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"ref":"refs/changes/64/171264/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/64/171264/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/64/171264/4"}}},"commit":{"parents":[{"commit":"3ee9eb61f26d09056c4f4761000bdeb7e6d3baa0","subject":"a test for memcache_pool","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/3ee9eb61f26d09056c4f4761000bdeb7e6d3baa0"}]}],"author":{"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","date":"2015-04-07 16:03:02.000000000","tz":-300},"committer":{"name":"Boris Bobrov","email":"bbobrov@mirantis.com","date":"2015-06-08 13:00:48.000000000","tz":180},"subject":"Correct memcached parameters in TokenCache","message":"Correct memcached parameters in TokenCache\n\nTokenCache._memcache_pool_dead_retry and\nTokenCache._memcache_pool_maxsize end up as tuples because the lines\nthat store them end in commas. Both values should be integers; patch\nremoves the commas.\n\nChange-Id: I012bbd45d208c7643b29e5f32fa903724cb87765\nCloses-Bug: 1441238\nPartial-Bug: 1463009\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/cbb2e958d96f44e00b02b3bfd2b174318ab6c104"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/cbb2e958d96f44e00b02b3bfd2b174318ab6c104"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}