)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4cabdb2f871c56d777542d012fe022dc9e64f60c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ankita_wagh \u003cAnkita_Wagh@symantec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-05 12:59:05 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handling endpoints with missing URL types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes Bug: #1450868"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_505f6d0e","line":7,"updated":"2015-05-06 09:06:21.000000000","message":"Are the types missing or the urls?  It\u0027s the latter isn\u0027t it?  So \n\nImproved handling of endpoints missing interface urls (public, internal or admin).?","commit_id":"1ada431408abf878899ff3d20a57978c3e52d413"}],"keystonemiddleware/audit.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7e9de847023ba67bb28df59a03ac9fdf34e595ac","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            admin_urlparse \u003d None"},{"line_number":255,"context_line":"            public_urlparse \u003d None"},{"line_number":256,"context_line":"            admin_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027adminURL\u0027)"},{"line_number":257,"context_line":"            if admin_url not None:"},{"line_number":258,"context_line":"                admin_urlparse \u003d urlparse.urlparse(admin_url)"},{"line_number":259,"context_line":"            public_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027publicURL\u0027)"},{"line_number":260,"context_line":"            if public_url not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_d42f98f4","line":257,"updated":"2015-05-03 16:05:19.000000000","message":"This isn\u0027t valid Python","commit_id":"62bf7f197b2a49b875bce2e5b3bb8a98e621b494"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7e9de847023ba67bb28df59a03ac9fdf34e595ac","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            if admin_url not None:"},{"line_number":258,"context_line":"                admin_urlparse \u003d urlparse.urlparse(admin_url)"},{"line_number":259,"context_line":"            public_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027publicURL\u0027)"},{"line_number":260,"context_line":"            if public_url not None:"},{"line_number":261,"context_line":"                public_urlparse \u003d urlparse.urlparse(public_url)"},{"line_number":262,"context_line":"            req_url \u003d urlparse.urlparse(req.host_url)"},{"line_number":263,"context_line":"            if admin_urlparse \u0026 req_url.netloc \u003d\u003d admin_urlparse.netloc:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_b4365c50","line":260,"updated":"2015-05-03 16:05:19.000000000","message":"or this","commit_id":"62bf7f197b2a49b875bce2e5b3bb8a98e621b494"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"7e9de847023ba67bb28df59a03ac9fdf34e595ac","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            if public_url not None:"},{"line_number":261,"context_line":"                public_urlparse \u003d urlparse.urlparse(public_url)"},{"line_number":262,"context_line":"            req_url \u003d urlparse.urlparse(req.host_url)"},{"line_number":263,"context_line":"            if admin_urlparse \u0026 req_url.netloc \u003d\u003d admin_urlparse.netloc:"},{"line_number":264,"context_line":"                service_info \u003d self._get_service_info(endp)"},{"line_number":265,"context_line":"                break"},{"line_number":266,"context_line":"            elif public_urlparse \u0026 req_url.netloc \u003d\u003d public_urlparse.netloc:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_543ca82e","line":263,"updated":"2015-05-03 16:05:19.000000000","message":"Are you sure you want to use the bitwise \u0026 instead or \u0027and\u0027? I\u0027m thinking this is a mistake.","commit_id":"62bf7f197b2a49b875bce2e5b3bb8a98e621b494"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f084f1fe9c7d93b766349ffef954c0a5e9806dae","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        default_endpoint \u003d None"},{"line_number":253,"context_line":"        for endp in catalog:"},{"line_number":254,"context_line":"            admin_urlparse \u003d urlparse.urlparse("},{"line_number":255,"context_line":"                endp[\u0027endpoints\u0027][0][\u0027adminURL\u0027])"},{"line_number":256,"context_line":"            public_urlparse \u003d urlparse.urlparse("},{"line_number":257,"context_line":"                endp[\u0027endpoints\u0027][0][\u0027publicURL\u0027])"},{"line_number":258,"context_line":"            req_url \u003d urlparse.urlparse(req.host_url)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_e8315f5b","side":"PARENT","line":255,"updated":"2015-05-05 16:20:27.000000000","message":"you can alternatively use .get(\u0027xyzURL\u0027, \u0027\u0027)\n\nthis will default to an empty string and urlparse will just create an empty ParseResult","commit_id":"f45d7663f38bde35abfa223d185b6a4d5029c308"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"8a406300e01bea9836cca0e2cb9f7ac21717d1ee","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        default_endpoint \u003d None"},{"line_number":253,"context_line":"        for endp in catalog:"},{"line_number":254,"context_line":"            admin_urlparse \u003d None"},{"line_number":255,"context_line":"            public_urlparse \u003d None"},{"line_number":256,"context_line":"            admin_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027adminURL\u0027)"},{"line_number":257,"context_line":"            if admin_url:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_28719744","line":254,"updated":"2015-05-05 16:15:37.000000000","message":"Bit clunky all this stacking up of variables just to check they\u0027re there.  Can this be more dynamic?","commit_id":"5f78d994f314c9af781424f74a49a91ab9cf8eed"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4cabdb2f871c56d777542d012fe022dc9e64f60c","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        default_endpoint \u003d None"},{"line_number":253,"context_line":"        for endp in catalog:"},{"line_number":254,"context_line":"            admin_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027adminURL\u0027, \u0027\u0027)"},{"line_number":255,"context_line":"            admin_urlparse \u003d urlparse.urlparse(admin_url)"},{"line_number":256,"context_line":"            public_url \u003d endp[\u0027endpoints\u0027][0].get(\u0027publicURL\u0027, \u0027\u0027)"},{"line_number":257,"context_line":"            public_urlparse \u003d urlparse.urlparse(public_url)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_955e1744","line":254,"updated":"2015-05-06 09:06:21.000000000","message":"Personally I\u0027d be inclined to do\n\nendpoint_urls \u003d endp[\u0027endpoints\u0027][0]\nadmin_url \u003d endpoint_urls.get(\u0027adminURL\u0027, \u0027\u0027)\n...\npublic_url \u003d  endpoint_urls.get(\u0027publicURL\u0027, \u0027\u0027)\n...\n\njust to cut down on the square brackets stuff a bit.","commit_id":"1ada431408abf878899ff3d20a57978c3e52d413"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"81cf597e666b1bbc13a1db6b1e4b8259e834d77c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        except Exception as e:"},{"line_number":67,"context_line":"            _LOG.exception(_LE(\u0027An exception occurred processing \u0027"},{"line_number":68,"context_line":"                               \u0027the API call: %s \u0027), e)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    return wrapper"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_4520ad9b","line":69,"updated":"2015-05-06 22:00:39.000000000","message":"remove all the stray formatting changes","commit_id":"96e984d4c7df5b1c375aa78fe406a77e2f5f29f1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"81cf597e666b1bbc13a1db6b1e4b8259e834d77c","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            if admin_urlparse and req_url.netloc \u003d\u003d admin_urlparse.netloc:"},{"line_number":262,"context_line":"                service_info \u003d self._get_service_info(endp)"},{"line_number":263,"context_line":"                break"},{"line_number":264,"context_line":"            elif public_urlparse and req_url.netloc \u003d\u003d public_urlparse.netloc:"},{"line_number":265,"context_line":"                service_info \u003d self._get_service_info(endp)"},{"line_number":266,"context_line":"                break"},{"line_number":267,"context_line":"            elif (self._MAP.default_target_endpoint_type and"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_a51ae16c","line":264,"updated":"2015-05-06 22:00:39.000000000","message":"we should leave this as original statement...i don\u0027t think admin_urlparse or public_urlparse would ever be None\n\n  if (req_url.netloc \u003d\u003d admin_urlparse.netloc\n         or req_url.netloc \u003d\u003d public_urlparse.netloc):","commit_id":"96e984d4c7df5b1c375aa78fe406a77e2f5f29f1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"34ef8650eda30659df73f409c7f9ea7ff3bf41fa","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                               id\u003dtaxonomy.UNKNOWN, admin_endp\u003dNone,"},{"line_number":243,"context_line":"                               private_endp\u003dNone, public_endp\u003dNone)"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            catalog \u003d ast.literal_eval("},{"line_number":246,"context_line":"                req.environ[\u0027HTTP_X_SERVICE_CATALOG\u0027])"},{"line_number":247,"context_line":"        except KeyError:"},{"line_number":248,"context_line":"            raise PycadfAuditApiConfigError("}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_afcabb9f","line":245,"updated":"2015-05-06 23:48:56.000000000","message":"it does what! this is json - not python.\n\n(note this is not your fault)","commit_id":"47fed2f1fd5539a12b1d79e0db35b7d3f71afa20"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"d6629134a55096efe87ab48573a713630f4301d6","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                               id\u003dtaxonomy.UNKNOWN, admin_endp\u003dNone,"},{"line_number":243,"context_line":"                               private_endp\u003dNone, public_endp\u003dNone)"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            catalog \u003d ast.literal_eval("},{"line_number":246,"context_line":"                req.environ[\u0027HTTP_X_SERVICE_CATALOG\u0027])"},{"line_number":247,"context_line":"        except KeyError:"},{"line_number":248,"context_line":"            raise PycadfAuditApiConfigError("}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_d358e2fc","line":245,"in_reply_to":"1aca2d91_afcabb9f","updated":"2015-05-07 19:33:53.000000000","message":"hmm..  i can\u0027t remember why we have this... but yeah. probably can be switched to json.loads","commit_id":"47fed2f1fd5539a12b1d79e0db35b7d3f71afa20"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"662d73755926d7c64a06e59690c4ccab3a30a68e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                               id\u003dtaxonomy.UNKNOWN, admin_endp\u003dNone,"},{"line_number":243,"context_line":"                               private_endp\u003dNone, public_endp\u003dNone)"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            catalog \u003d ast.literal_eval("},{"line_number":246,"context_line":"                req.environ[\u0027HTTP_X_SERVICE_CATALOG\u0027])"},{"line_number":247,"context_line":"        except KeyError:"},{"line_number":248,"context_line":"            raise PycadfAuditApiConfigError("}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_ccfa4e43","line":245,"in_reply_to":"1aca2d91_d358e2fc","updated":"2015-05-08 23:03:37.000000000","message":"Let\u0027s get this fixed. ASAP, this is not good. @gordc Please open a bug and let\u0027s get a fix spun up quickly.","commit_id":"47fed2f1fd5539a12b1d79e0db35b7d3f71afa20"}],"keystonemiddleware/tests/unit/test_audit_middleware.py":[{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4cabdb2f871c56d777542d012fe022dc9e64f60c","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        payload \u003d req.environ[\u0027cadf_event\u0027].as_dict()"},{"line_number":485,"context_line":"        self.assertEqual(payload[\u0027target\u0027][\u0027id\u0027], identifier.norm_ns(\u0027nova\u0027))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_missing_private_endpoint_url(self):"},{"line_number":488,"context_line":"        env_headers \u003d {\u0027HTTP_X_SERVICE_CATALOG\u0027:"},{"line_number":489,"context_line":"                       \u0027\u0027\u0027[{\"endpoints_links\": [],"},{"line_number":490,"context_line":"                            \"endpoints\": [{\"adminURL\":"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_75513b62","line":487,"updated":"2015-05-06 09:06:21.000000000","message":"I think \"test_endpoint_missing_internal_url\"?  For the sake of consistency - but I do realise that it\u0027s referred to elsewhere in the code as \u0027private\u0027.  What\u0027s the official line on this?","commit_id":"1ada431408abf878899ff3d20a57978c3e52d413"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4cabdb2f871c56d777542d012fe022dc9e64f60c","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        self.middleware._process_request(req)"},{"line_number":507,"context_line":"        payload \u003d req.environ[\u0027cadf_event\u0027].as_dict()"},{"line_number":508,"context_line":"        self.assertEqual((payload[\u0027target\u0027][\u0027addresses\u0027][1][\u0027url\u0027]), \"unknown\")"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def test_missing_public_endpoint_url(self):"},{"line_number":511,"context_line":"        env_headers \u003d {\u0027HTTP_X_SERVICE_CATALOG\u0027:"},{"line_number":512,"context_line":"                       \u0027\u0027\u0027[{\"endpoints_links\": [],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_75fffb34","line":509,"updated":"2015-05-06 09:06:21.000000000","message":"endpoint_missing_public_url","commit_id":"1ada431408abf878899ff3d20a57978c3e52d413"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4cabdb2f871c56d777542d012fe022dc9e64f60c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        payload \u003d req.environ[\u0027cadf_event\u0027].as_dict()"},{"line_number":531,"context_line":"        self.assertEqual((payload[\u0027target\u0027][\u0027addresses\u0027][2][\u0027url\u0027]), \"unknown\")"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def test_missing_admin_endpoint_url(self):"},{"line_number":534,"context_line":"        env_headers \u003d {\u0027HTTP_X_SERVICE_CATALOG\u0027:"},{"line_number":535,"context_line":"                       \u0027\u0027\u0027[{\"endpoints_links\": [],"},{"line_number":536,"context_line":"                            \"endpoints\": [{\"region\": \"RegionOne\","}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_d59ecf06","line":533,"updated":"2015-05-06 09:06:21.000000000","message":"endpoint_missing_admin_url","commit_id":"1ada431408abf878899ff3d20a57978c3e52d413"}]}
