)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c998047ce69e66e6f3301283c1d1def702390e61","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Separate setting catalog on headers from others"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A minor cleanup to make setting catalog headers distinct from the"},{"line_number":10,"context_line":"regular headers."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I696e826a9983965258cf4cf518ab399723d27649"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_3ee06596","line":10,"updated":"2015-08-13 16:34:02.000000000","message":"just out of curiosity, why should they be separate?","commit_id":"b5cc39c1e580cb6d76181e0b48c0eb9b45386a18"}],"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"92f8edc5b5213e60d91d4b7f61d4c08d9bbdae64","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            except exc.InvalidToken:"},{"line_number":484,"context_line":"                self.log.info(_LI(\u0027Invalid user token\u0027))"},{"line_number":485,"context_line":"                request.user_token_valid \u003d False"},{"line_number":486,"context_line":"            else:"},{"line_number":487,"context_line":"                request.user_token_valid \u003d True"},{"line_number":488,"context_line":"                request.token_info \u003d data"},{"line_number":489,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_7e48bc87","line":486,"updated":"2015-10-30 07:09:35.000000000","message":"done here","commit_id":"ed2815f72d28d5c518bf8c93466a0fedcd1d1951"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"92f8edc5b5213e60d91d4b7f61d4c08d9bbdae64","unresolved":false,"context_lines":[{"line_number":722,"context_line":"        \"\"\""},{"line_number":723,"context_line":"        request.remove_auth_headers()"},{"line_number":724,"context_line":"        self._token_cache.initialize(request.environ)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        resp \u003d super(AuthProtocol, self).process_request(request)"},{"line_number":727,"context_line":"        if resp:"},{"line_number":728,"context_line":"            return resp"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a26ad4f_1e0e683b","line":725,"updated":"2015-10-30 07:09:35.000000000","message":"which is called from here.","commit_id":"ed2815f72d28d5c518bf8c93466a0fedcd1d1951"}],"keystonemiddleware/auth_token/_request.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c998047ce69e66e6f3301283c1d1def702390e61","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        for k, v in six.iteritems(self._DEPRECATED_HEADER_MAP):"},{"line_number":158,"context_line":"            self.headers[k] \u003d self.headers[v]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def set_service_catalog_headers(self, auth_ref):"},{"line_number":161,"context_line":"        \"\"\"Convert service catalog from token object into headers."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        Build headers that represent the catalog - see main"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_9e417966","line":160,"updated":"2015-08-13 16:34:02.000000000","message":"do we need an explicit test to ensure this method is tested?","commit_id":"b5cc39c1e580cb6d76181e0b48c0eb9b45386a18"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c998047ce69e66e6f3301283c1d1def702390e61","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def set_service_catalog_headers(self, auth_ref):"},{"line_number":161,"context_line":"        \"\"\"Convert service catalog from token object into headers."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        Build headers that represent the catalog - see main"},{"line_number":164,"context_line":"        doc info at start of __init__ file for details of headers to be defined"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        if not auth_ref.has_service_catalog():"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_5e7531ca","line":163,"updated":"2015-08-13 16:34:02.000000000","message":"add doc strings for parameters","commit_id":"b5cc39c1e580cb6d76181e0b48c0eb9b45386a18"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ed1cece52762042dd747b1f1f769f35653fb5604","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"\"\""},{"line_number":169,"context_line":"        if not auth_ref.has_service_catalog():"},{"line_number":170,"context_line":"            self.headers.pop(self._SERVICE_CATALOG_HEADER, None)"},{"line_number":171,"context_line":"            return"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        catalog \u003d auth_ref.service_catalog.get_data()"},{"line_number":174,"context_line":"        if auth_ref.version \u003d\u003d \u0027v3\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_b4c0fce1","line":171,"updated":"2015-10-12 20:12:20.000000000","message":"do we need an explicit test for this now that it\u0027s broken into it\u0027s own method outside of set_user_headers? \n\nsomething like - https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/tests/unit/auth_token/test_request.py#L143 ?","commit_id":"2639dd1c272d6f9417e69d539765bdf178b8a84a"},{"author":{"_account_id":17026,"name":"Sean Perry","email":"sean.perry@hpe.com","username":"sean_perry"},"change_message_id":"f19098efc547ed6521bdbcc448e62932de4acf6c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            c \u003d jsonutils.dumps(catalog)"},{"line_number":167,"context_line":"            self.headers[self._SERVICE_CATALOG_HEADER] \u003d c"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.user_token_valid \u003d True"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def set_service_headers(self, auth_ref):"},{"line_number":172,"context_line":"        \"\"\"Convert token object into service headers."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_62bce36c","side":"PARENT","line":169,"updated":"2015-10-14 00:14:59.000000000","message":"Neither user_token_valid or service_token_valid are being set any more in this file. Is that on purpose?","commit_id":"0f31eb0449b7c5b2e623d5b388a49734b2c1f0a7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"158ffcb8a6c3648db32ff4149a62f4771fe830f8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            c \u003d jsonutils.dumps(catalog)"},{"line_number":167,"context_line":"            self.headers[self._SERVICE_CATALOG_HEADER] \u003d c"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.user_token_valid \u003d True"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def set_service_headers(self, auth_ref):"},{"line_number":172,"context_line":"        \"\"\"Convert token object into service headers."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a2ca52d_45c6fb68","side":"PARENT","line":169,"in_reply_to":"5a2ca52d_62bce36c","updated":"2015-10-16 17:52:02.000000000","message":"and why don\u0027t we have tests for the setting?","commit_id":"0f31eb0449b7c5b2e623d5b388a49734b2c1f0a7"}]}