)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3092fa5efa4198180d60c912039813c280f51e9c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  oslo_config_project \u003d aodh"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"With this, the keystonemiddleware will automatically load"},{"line_number":20,"context_line":"the configuration of the project aodh with a local oslo.config object"},{"line_number":21,"context_line":"instead of the global one."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This allows application to not rely of the global oslo.config object"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_1b2d7ba8","line":20,"updated":"2015-08-13 16:24:31.000000000","message":"aodh?","commit_id":"94b5b13cf71807facf529ad23c7890a51b953ac9"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"dc5205e6a4ca77d81fb9c12f420a33e809ad8557","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  oslo_config_project \u003d aodh"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"With this, the keystonemiddleware will automatically load"},{"line_number":20,"context_line":"the configuration of the project aodh with a local oslo.config object"},{"line_number":21,"context_line":"instead of the global one."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This allows application to not rely of the global oslo.config object"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_a179ba84","line":20,"in_reply_to":"1a4dcd0f_1b2d7ba8","updated":"2015-08-13 16:38:47.000000000","message":"https://launchpad.net/aodh","commit_id":"94b5b13cf71807facf529ad23c7890a51b953ac9"}],"doc/source/middlewarearchitecture.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d997f65b254842ab29b29dd1bbb70df5e8f57831","unresolved":false,"context_lines":[{"line_number":274,"context_line":"Also if the service doesn\u0027t use the global oslo.config object (CONF). "},{"line_number":275,"context_line":"The oslo config project name can be set, keystonemiddleware will load "},{"line_number":276,"context_line":"the project configuration itself. Optionally the location of the "},{"line_number":277,"context_line":"configuration file can be set if oslo.config is not able to discover it."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":".. code-block:: ini"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa1b9901_7a4727bc","line":277,"updated":"2015-08-20 12:05:31.000000000","message":"You\u0027ve got some EOL whitespace and the grammar is a bit weird through here. Maybe something like:\n\nIf the service doesn\u0027t use the global oslo.config object (CONF), then the olso config project name can be set it in paste config and keystonemiddleware will load the project configuration itself.","commit_id":"ef31d7f94b6469bceaa02939e59a81ac4bd98ed1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"24c9f5ab30b759f86e634d07d9268b76620547d0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"Also if the service doesn\u0027t use the global oslo.config object (CONF). "},{"line_number":275,"context_line":"The oslo config project name can be set, keystonemiddleware will load "},{"line_number":276,"context_line":"the project configuration itself. Optionally the location of the "},{"line_number":277,"context_line":"configuration file can be set if oslo.config is not able to discover it."},{"line_number":278,"context_line":""},{"line_number":279,"context_line":".. code-block:: ini"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa1b9901_65677bb7","line":277,"in_reply_to":"fa1b9901_7a4727bc","updated":"2015-08-20 15:16:29.000000000","message":"Done","commit_id":"ef31d7f94b6469bceaa02939e59a81ac4bd98ed1"}],"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3092fa5efa4198180d60c912039813c280f51e9c","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                # CONF.project will exist only if the service uses"},{"line_number":992,"context_line":"                # oslo.config. It will only be set when the project"},{"line_number":993,"context_line":"                # calls CONF(...) and when not set oslo.config oddly"},{"line_number":994,"context_line":"                # raises a NoSuchOptError exception."},{"line_number":995,"context_line":"                if self._local_oslo_config:"},{"line_number":996,"context_line":"                    return self._local_oslo_config.project"},{"line_number":997,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_fe9d1dbc","line":994,"updated":"2015-08-13 16:24:31.000000000","message":"this comment should include why we\u0027re returning self._local_oslo_config.project versus CONF.project.","commit_id":"94b5b13cf71807facf529ad23c7890a51b953ac9"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"21bca35aa3a336e0b894758b6d2da4221f8cb8b6","unresolved":false,"context_lines":[{"line_number":991,"context_line":"                # CONF.project will exist only if the service uses"},{"line_number":992,"context_line":"                # oslo.config. It will only be set when the project"},{"line_number":993,"context_line":"                # calls CONF(...) and when not set oslo.config oddly"},{"line_number":994,"context_line":"                # raises a NoSuchOptError exception."},{"line_number":995,"context_line":"                if self._local_oslo_config:"},{"line_number":996,"context_line":"                    return self._local_oslo_config.project"},{"line_number":997,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_4d33bd14","line":994,"in_reply_to":"1a4dcd0f_fe9d1dbc","updated":"2015-08-19 15:28:29.000000000","message":"Done","commit_id":"94b5b13cf71807facf529ad23c7890a51b953ac9"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2e07a80b4bd2fb10eddbbba4e15d5c881630405b","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"        plugin_opts \u003d plugin_class.get_options()"},{"line_number":963,"context_line":"        conf \u003d self._local_oslo_config or CONF"},{"line_number":964,"context_line":"        conf.register_opts(plugin_opts, group\u003dgroup)"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        for opt in plugin_opts:"},{"line_number":967,"context_line":"            val \u003d self._conf_get(opt.dest, group\u003dgroup)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_4b5c9318","line":964,"updated":"2015-08-21 12:49:57.000000000","message":"ultra nit: since \u0027conf\u0027 isn\u0027t used again, i\u0027d probably go with:\n\n (self._local_oslo_config or CONF).register_opts(plugin_opts, group\u003dgroup)\n\nbut only because of the relatively subtle difference between \u0027conf\u0027 and \u0027CONF\u0027 as a readability concern.","commit_id":"e21bdebe44ac5486de3f033be4d1cc6a898b58f1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"8a29ac6bd44ae3b635a34c68622bc4196360bc32","unresolved":false,"context_lines":[{"line_number":961,"context_line":""},{"line_number":962,"context_line":"        plugin_opts \u003d plugin_class.get_options()"},{"line_number":963,"context_line":"        conf \u003d self._local_oslo_config or CONF"},{"line_number":964,"context_line":"        conf.register_opts(plugin_opts, group\u003dgroup)"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        for opt in plugin_opts:"},{"line_number":967,"context_line":"            val \u003d self._conf_get(opt.dest, group\u003dgroup)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_06c20de9","line":964,"in_reply_to":"fa1b9901_4b5c9318","updated":"2015-08-21 13:59:25.000000000","message":"Done","commit_id":"e21bdebe44ac5486de3f033be4d1cc6a898b58f1"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2e07a80b4bd2fb10eddbbba4e15d5c881630405b","unresolved":false,"context_lines":[{"line_number":987,"context_line":"            # Prefer local oslo config object"},{"line_number":988,"context_line":"            if self._local_oslo_config:"},{"line_number":989,"context_line":"                return self._local_oslo_config.project"},{"line_number":990,"context_line":"            else:"},{"line_number":991,"context_line":"                try:"},{"line_number":992,"context_line":"                    # CONF.project will exist only if the service uses"},{"line_number":993,"context_line":"                    # oslo.config. It will only be set when the project"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_abf1af02","line":990,"updated":"2015-08-21 12:49:57.000000000","message":"nit: the else is unnecessary","commit_id":"e21bdebe44ac5486de3f033be4d1cc6a898b58f1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"8a29ac6bd44ae3b635a34c68622bc4196360bc32","unresolved":false,"context_lines":[{"line_number":987,"context_line":"            # Prefer local oslo config object"},{"line_number":988,"context_line":"            if self._local_oslo_config:"},{"line_number":989,"context_line":"                return self._local_oslo_config.project"},{"line_number":990,"context_line":"            else:"},{"line_number":991,"context_line":"                try:"},{"line_number":992,"context_line":"                    # CONF.project will exist only if the service uses"},{"line_number":993,"context_line":"                    # oslo.config. It will only be set when the project"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_66b3c998","line":990,"in_reply_to":"fa1b9901_abf1af02","updated":"2015-08-21 13:59:25.000000000","message":"Done","commit_id":"e21bdebe44ac5486de3f033be4d1cc6a898b58f1"}]}