)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5a7b92f332eba4bb3e2646f1684811da2cfbf0ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Edmonds \u003cedmondsw@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-09 14:01:51 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use ConnectionError for auth_token tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Auth token unit tests are failing because the keystoneclient exception"},{"line_number":10,"context_line":"ConnectionError is being used where ConnectionRefused is expected now."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_0382adc8","line":7,"updated":"2015-09-09 18:26:16.000000000","message":"Change \"ConnectionError\" to \"ConnectionRefused\".\n\nAlso, capitalize Use.\n\nAlso, suggest change the title to\n\n Fix auth_token keystoneclient fakes to raise ConnectionRefused","commit_id":"a69ee464ca41def09ecb8408c4d566338c94d662"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5a7b92f332eba4bb3e2646f1684811da2cfbf0ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use ConnectionError for auth_token tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Auth token unit tests are failing because the keystoneclient exception"},{"line_number":10,"context_line":"ConnectionError is being used where ConnectionRefused is expected now."},{"line_number":11,"context_line":"This switches to using ConnectionRefused."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_7e28e085","line":9,"updated":"2015-09-09 18:26:16.000000000","message":"The commit message could just say that the fakes were incorrect. keystoneclient doesn\u0027t raise ConnectionError, it raises ConnectionRefused. It just so happened that ConnectionError is ConnectionRefused . Link to the keystoneclient code: http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/session.py?id\u003d28138b588224c6b0503620ac2e24bd37dad25370#n430\n\nkeystoneclient doesn\u0027t raise ConnectionError anywhere.\n\nThere wasn\u0027t a change in keystoneclient other than the exceptions were re-named, but the next release will correct that change.","commit_id":"a69ee464ca41def09ecb8408c4d566338c94d662"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"e8c89d7b3b9a9bb86b4174f8a02a0a0269c34fd8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use ConnectionRefused for auth_token tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Auth token unit tests were failing because they were faking"},{"line_number":10,"context_line":"ConnectionError whereas keystoneclient now raises ConnectionRefused. See"},{"line_number":11,"context_line":"http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/session.py?id\u003d28138b588224c6b0503620ac2e24bd37dad25370#n430"},{"line_number":12,"context_line":"This switches to faking ConnectionRefused."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_d9c34689","line":10,"updated":"2015-09-09 18:53:27.000000000","message":"change \"faking ConnectionError\" to \"faking keystoneclient raising ConnectionError\"\n\nkeystoneclient has always raised ConnectionRefused as far as I know, so it isn\u0027t accurate to say that this is something that changed.","commit_id":"692b982175caff28071ff2b4b181ce87a44ce59f"}],"keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5a7b92f332eba4bb3e2646f1684811da2cfbf0ba","unresolved":false,"context_lines":[{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":"def network_error_response(request, context):"},{"line_number":1523,"context_line":"    raise exceptions.ConnectionRefused(\"Network connection refused.\")"},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"class v2AuthTokenMiddlewareTest(BaseAuthTokenMiddlewareTest,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_be5c381a","line":1523,"updated":"2015-09-09 18:26:16.000000000","message":"note, the message is actually \"Unable to establish connection to %s\", according to http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/session.py?id\u003d28138b588224c6b0503620ac2e24bd37dad25370#n429 ... probably not worth it to try to chase the exception messages.","commit_id":"a69ee464ca41def09ecb8408c4d566338c94d662"}]}