)]}'
{"keystonemiddleware/tests/unit/auth_token/test_user_auth_plugin.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"60ac35fb82132a375f2786c0f1523acc7e7e93c4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.cfg.register_opts(opts, group\u003dgroup)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        auth.register_conf_options(self.cfg.conf,"},{"line_number":36,"context_line":"                                   group\u003d_base.AUTHTOKEN_GROUP)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.cfg.config(group\u003dgroup,"},{"line_number":39,"context_line":"                        auth_plugin\u003dauth_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c10ca63d","line":36,"updated":"2015-09-15 13:42:33.000000000","message":"s/_base.AUTHTOKEN_GROUP/group/ to be consistent with above, assuming there is some need to be able to pass in the group name, else could change the above to be consistent with this.","commit_id":"326e9a42e8f701a10434a8053c63bb8a18005ab2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"fb702ad91bf2387e6d82ea624f4e225598ea8f8b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.cfg.register_opts(opts, group\u003dgroup)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        auth.register_conf_options(self.cfg.conf,"},{"line_number":36,"context_line":"                                   group\u003d_base.AUTHTOKEN_GROUP)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.cfg.config(group\u003dgroup,"},{"line_number":39,"context_line":"                        auth_plugin\u003dauth_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_9c42903d","line":36,"in_reply_to":"ba15a1d1_0c641547","updated":"2015-09-15 14:39:08.000000000","message":"I changed my mind. I think we should register the options right before they\u0027re used since that\u0027s where the exception is raised.","commit_id":"326e9a42e8f701a10434a8053c63bb8a18005ab2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"13d7393425bcd5371c44a77022a5af8c88f666e6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.cfg.register_opts(opts, group\u003dgroup)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        auth.register_conf_options(self.cfg.conf,"},{"line_number":36,"context_line":"                                   group\u003d_base.AUTHTOKEN_GROUP)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.cfg.config(group\u003dgroup,"},{"line_number":39,"context_line":"                        auth_plugin\u003dauth_plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0c641547","line":36,"in_reply_to":"ba15a1d1_c10ca63d","updated":"2015-09-15 14:09:17.000000000","message":"These options are used differently.\n\nThe plugin options (at line 31) are for the auth plugins. They\u0027re loaded and registered dynamically and can be in any group that you configure them to be in.\n\nThe auth_token middleware always registers and loads the static base auth plugin options from the keystone_authtoken section.\n\nThinking about this some more, I don\u0027t think this belongs here... I\u0027ll move it somewhere... maybe just move it to where the base configopts is created is the best place for it.","commit_id":"326e9a42e8f701a10434a8053c63bb8a18005ab2"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"1edebb2f99a319e528e565a5092c6a2d3d6c7a40","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def configure_middleware(self,"},{"line_number":29,"context_line":"                             auth_plugin,"},{"line_number":30,"context_line":"                             group\u003d\u0027keystone_authtoken\u0027,"},{"line_number":31,"context_line":"                             **kwargs):"},{"line_number":32,"context_line":"        opts \u003d auth.get_plugin_class(auth_plugin).get_options()"},{"line_number":33,"context_line":"        self.cfg.register_opts(opts, group\u003dgroup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_a3f40f87","line":30,"updated":"2015-09-15 16:09:21.000000000","message":"should we use _base.AUTHTOKEN_GROUP here instead of \u0027keystone_authtoken\u0027?","commit_id":"2951d00049ac6f9824cf85e885fe53b2aa944746"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b00423d9ee37dc9689715c428bc1e060bb8b54c4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def configure_middleware(self,"},{"line_number":29,"context_line":"                             auth_plugin,"},{"line_number":30,"context_line":"                             group\u003d\u0027keystone_authtoken\u0027,"},{"line_number":31,"context_line":"                             **kwargs):"},{"line_number":32,"context_line":"        opts \u003d auth.get_plugin_class(auth_plugin).get_options()"},{"line_number":33,"context_line":"        self.cfg.register_opts(opts, group\u003dgroup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_de9c785f","line":30,"in_reply_to":"ba15a1d1_a3f40f87","updated":"2015-09-15 16:25:16.000000000","message":"Removed it in https://review.openstack.org/223679","commit_id":"2951d00049ac6f9824cf85e885fe53b2aa944746"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"1edebb2f99a319e528e565a5092c6a2d3d6c7a40","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # Since these tests cfg.config() themselves rather than waiting for"},{"line_number":36,"context_line":"        # auth_token to do it on __init__ we need to register the base auth"},{"line_number":37,"context_line":"        # options (e.g., auth_plugin)"},{"line_number":38,"context_line":"        auth.register_conf_options(self.cfg.conf, group\u003d_base.AUTHTOKEN_GROUP)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.cfg.config(group\u003dgroup,"},{"line_number":41,"context_line":"                        auth_plugin\u003dauth_plugin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8340eba6","line":38,"updated":"2015-09-15 16:09:21.000000000","message":"I think your patch set 1 answer was referring to the auth_section option. But if someone was using that here, auth.register_conf_options would have needed to be done earlier, so that the auth_section option was registered, so it could be read, so its value could be passed in here. So does this need to be done earlier, or should there not really be a group arg on this function because it will always be _base.AUTHTOKEN_GROUP?","commit_id":"2951d00049ac6f9824cf85e885fe53b2aa944746"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b00423d9ee37dc9689715c428bc1e060bb8b54c4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # Since these tests cfg.config() themselves rather than waiting for"},{"line_number":36,"context_line":"        # auth_token to do it on __init__ we need to register the base auth"},{"line_number":37,"context_line":"        # options (e.g., auth_plugin)"},{"line_number":38,"context_line":"        auth.register_conf_options(self.cfg.conf, group\u003d_base.AUTHTOKEN_GROUP)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.cfg.config(group\u003dgroup,"},{"line_number":41,"context_line":"                        auth_plugin\u003dauth_plugin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_de0c783d","line":38,"in_reply_to":"ba15a1d1_8340eba6","updated":"2015-09-15 16:25:16.000000000","message":"why would tests read the config option? They should be setting it to whatever they need.\n\nI proposed a separate change https://review.openstack.org/223679 to remove the group option since nothing\u0027s using it.","commit_id":"2951d00049ac6f9824cf85e885fe53b2aa944746"}]}