)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0a1f95f62e4ff07a086fd085a4b3dc0b0c397fa1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Check for notification_driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding check for notification_driver before sending messages to"},{"line_number":10,"context_line":"notification queue. If notification_driver is available then only"},{"line_number":11,"context_line":"messages will be send to queue otherwise passes to log file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I75345cc909442ff03ad2276830b0781ee60f7266"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_3481674e","line":10,"updated":"2016-02-02 16:22:45.000000000","message":"remove \"only\"","commit_id":"fbdb9916114ac0c8a37f8730ac0413ada86a09ee"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0a1f95f62e4ff07a086fd085a4b3dc0b0c397fa1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding check for notification_driver before sending messages to"},{"line_number":10,"context_line":"notification queue. If notification_driver is available then only"},{"line_number":11,"context_line":"messages will be send to queue otherwise passes to log file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I75345cc909442ff03ad2276830b0781ee60f7266"},{"line_number":14,"context_line":"Closes-Bug: #1452055"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a5de9d1_94e37b33","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":30},"updated":"2016-02-02 16:22:45.000000000","message":"change \"send to queue\" to \"sent to the queue\"\n\nchange \"otherwise passes\" to \"otherwise the message is logged\"","commit_id":"fbdb9916114ac0c8a37f8730ac0413ada86a09ee"}],"keystonemiddleware/audit.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a3a010e238ad242e6ba03aa00655c0a59ab08b40","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._cadf_audit \u003d OpenStackAuditApi(conf.get(\u0027audit_map_file\u0027))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d conf.get(\u0027notification_driver\u0027)"},{"line_number":343,"context_line":"        if messaging:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_8bf0a392","line":342,"range":{"start_line":342,"start_character":8,"end_line":342,"end_character":67},"updated":"2016-01-31 06:39:00.000000000","message":"check \u0027driver\u0027 instead of \u0027notification_driver\u0027, as the latter seems to be deprecated:\n\nhttps://github.com/openstack/oslo.messaging/blob/6e95e8b891b1a963eecf6588404a501c57e59071/oslo_messaging/notify/notifier.py#L32-L38","commit_id":"3ea9cef7d2bb74a503953d9da970c5ec2c920872"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0a1f95f62e4ff07a086fd085a4b3dc0b0c397fa1","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._cadf_audit \u003d OpenStackAuditApi(conf.get(\u0027audit_map_file\u0027))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d conf.get(\u0027driver\u0027)"},{"line_number":343,"context_line":"        if messaging:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_b46c7737","line":342,"updated":"2016-02-02 16:22:45.000000000","message":"Why is this using conf and not cfg.CONF? oslo_messaging isn\u0027t being passed conf, it\u0027s getting passed cfg.CONF.\n\nI don\u0027t think we should be guessing how oslo_messaging works (for example, whether it uses driver or not). oslo_messaging should provide us with a function to call that tells us whether notifications are configured or not.","commit_id":"fbdb9916114ac0c8a37f8730ac0413ada86a09ee"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0a1f95f62e4ff07a086fd085a4b3dc0b0c397fa1","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d conf.get(\u0027driver\u0027)"},{"line_number":343,"context_line":"        if messaging:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"},{"line_number":346,"context_line":"                                             aliases\u003dtransport_aliases),"},{"line_number":347,"context_line":"                os.path.basename(sys.argv[0]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_944a9bab","line":344,"updated":"2016-02-02 16:22:45.000000000","message":"no need to create a notifier if it\u0027s not going to be used.","commit_id":"fbdb9916114ac0c8a37f8730ac0413ada86a09ee"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8e9cb9fa155947ec0da036e10b80fdf3e70c8fe8","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._cadf_audit \u003d OpenStackAuditApi(conf.get(\u0027audit_map_file\u0027))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d cfg.CONF.driver"},{"line_number":343,"context_line":"        if messaging and self._notification_driver:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_97baf36c","line":342,"updated":"2016-02-16 17:27:21.000000000","message":"I don\u0027t think we should be guessing how oslo_messaging works (whether it uses driver or not). oslo_messaging should provide us with a function to call that tells us whether notifications are configured or not.","commit_id":"fe2e9d420c2e72290d74d00fa15c65c6003e9a43"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"44da08f2df2b7b986019fb6e01c7fd356b1b2df4","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._cadf_audit \u003d OpenStackAuditApi(conf.get(\u0027audit_map_file\u0027))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d cfg.CONF.driver"},{"line_number":343,"context_line":"        if messaging and self._notification_driver:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_cfc74962","line":342,"in_reply_to":"5a18252c_0dec7cc6","updated":"2016-04-20 21:10:17.000000000","message":"oslo messaging has deprecated \u0027driver\u0027 usage in DEFAULT section. https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/notifier.py#L36\n\nThe group used for notifications is \u0027oslo_messaging_notifications\u0027 https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/notifier.py#L178.","commit_id":"fe2e9d420c2e72290d74d00fa15c65c6003e9a43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"721522f95a43754c779c2442acbea69d3c81d3e2","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        self._cadf_audit \u003d OpenStackAuditApi(conf.get(\u0027audit_map_file\u0027))"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d cfg.CONF.driver"},{"line_number":343,"context_line":"        if messaging and self._notification_driver:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_0dec7cc6","line":342,"in_reply_to":"dae33548_97baf36c","updated":"2016-04-12 07:38:10.000000000","message":"++ I don\u0027t want to make guesses at oslo_messaging from within keystonemiddleware. Let\u0027s get oslo_messaging to help us do something smarter here.","commit_id":"fe2e9d420c2e72290d74d00fa15c65c6003e9a43"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"3330182ce4b295625dfdb32bdaa7db0257e59535","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":342,"context_line":"        self._notification_driver \u003d cfg.CONF.driver"},{"line_number":343,"context_line":"        if messaging and self._notification_driver:"},{"line_number":344,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":345,"context_line":"                oslo_messaging.get_transport(cfg.CONF,"},{"line_number":346,"context_line":"                                             aliases\u003dtransport_aliases),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_8dcf7428","line":343,"range":{"start_line":343,"start_character":25,"end_line":343,"end_character":50},"updated":"2016-02-12 02:27:17.000000000","message":"If it is None, maybe a warn saying so?\n\nHowever this doesn\u0027t invalidate this patch, maybe addressed in a followup","commit_id":"fe2e9d420c2e72290d74d00fa15c65c6003e9a43"}]}