)]}'
{"doc/source/audit.rst":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":79,"context_line":"   ignore_req_list \u003d GET,POST # opt to ignore specific requests"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Audit middleware can be configured to use its own exclusive notification driver"},{"line_number":82,"context_line":"and topic(s) value. This can be useful in case when service is already using"},{"line_number":83,"context_line":"oslo messaging notifications and want to use different driver for auditing e.g."},{"line_number":84,"context_line":"service has existing notifications sent to queue via \u0027messagingv2\u0027 and want to"},{"line_number":85,"context_line":"sent audit notifications to log file via \u0027log\u0027 driver. Example shown below::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_7756d606","line":82,"updated":"2016-04-20 17:19:08.000000000","message":"\"useful in the case when the\" or \"useful when the service\" -- i like the shorter one better","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Audit middleware can be configured to use its own exclusive notification driver"},{"line_number":82,"context_line":"and topic(s) value. This can be useful in case when service is already using"},{"line_number":83,"context_line":"oslo messaging notifications and want to use different driver for auditing e.g."},{"line_number":84,"context_line":"service has existing notifications sent to queue via \u0027messagingv2\u0027 and want to"},{"line_number":85,"context_line":"sent audit notifications to log file via \u0027log\u0027 driver. Example shown below::"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_97ad72eb","line":83,"updated":"2016-04-20 17:19:08.000000000","message":"and wants to use a different","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Audit middleware can be configured to use its own exclusive notification driver"},{"line_number":82,"context_line":"and topic(s) value. This can be useful in case when service is already using"},{"line_number":83,"context_line":"oslo messaging notifications and want to use different driver for auditing e.g."},{"line_number":84,"context_line":"service has existing notifications sent to queue via \u0027messagingv2\u0027 and want to"},{"line_number":85,"context_line":"sent audit notifications to log file via \u0027log\u0027 driver. Example shown below::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   [audit_middleware_notifications]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_b7998ec6","line":84,"updated":"2016-04-20 17:19:08.000000000","message":"wants","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":82,"context_line":"and topic(s) value. This can be useful in case when service is already using"},{"line_number":83,"context_line":"oslo messaging notifications and want to use different driver for auditing e.g."},{"line_number":84,"context_line":"service has existing notifications sent to queue via \u0027messagingv2\u0027 and want to"},{"line_number":85,"context_line":"sent audit notifications to log file via \u0027log\u0027 driver. Example shown below::"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   [audit_middleware_notifications]"},{"line_number":88,"context_line":"   driver \u003d log"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_d78a4a63","line":85,"updated":"2016-04-20 17:19:08.000000000","message":"send audit notifications to a log file","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":88,"context_line":"   driver \u003d log"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify own transport url if its transport url needs to be different from"},{"line_number":92,"context_line":"service own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_7725365a","line":91,"updated":"2016-04-20 17:19:08.000000000","message":"specify a transport url","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify own transport url if its transport url needs to be different from"},{"line_number":92,"context_line":"service own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_d7140aea","line":92,"updated":"2016-04-20 17:19:08.000000000","message":"the service\u0027s","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"3e780296f60d77820c101776f9fb10fb782db3e0","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify own transport url if its transport url needs to be different from"},{"line_number":92,"context_line":"service own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a122d0e_09a5c645","line":92,"in_reply_to":"1a122d0e_d7140aea","updated":"2016-04-20 18:24:17.000000000","message":"Will make all the corrections mentioned above","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dc3f41c80796fcfad02c0eeb8c977fdcbff3e141","unresolved":false,"context_lines":[{"line_number":88,"context_line":"   driver \u003d log"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify a transport url if its transport url needs to be different from the"},{"line_number":92,"context_line":"service\u0027s own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dab17558_4caea52e","line":91,"range":{"start_line":91,"start_character":10,"end_line":91,"end_character":23},"updated":"2016-05-11 22:10:05.000000000","message":"nit: suggest to use URL and to put the name of the config in (), like: transport URL (transport_url)","commit_id":"061ddbcf98e1259dd5d12082923da0dccbcdf354"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58ac094344c2b83e1ab448983f8afcf1439bec57","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify a transport URL if its transport URL needs to be different from the"},{"line_number":92,"context_line":"service\u0027s own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"dab17558_2572ebe3","line":92,"range":{"start_line":92,"start_character":43,"end_line":92,"end_character":75},"updated":"2016-05-13 17:58:17.000000000","message":"nit: Other transport related settings are ...","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"fa6ebb245bb79b754a8debe60c00d03863e8d82c","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"When audit events are sent via \u0027messagingv2\u0027 or \u0027messaging\u0027, middleware can"},{"line_number":91,"context_line":"specify a transport URL if its transport URL needs to be different from the"},{"line_number":92,"context_line":"service\u0027s own messaging transport setting. Transport related other settings are"},{"line_number":93,"context_line":"read from oslo messaging sections defined in service configuration e.g."},{"line_number":94,"context_line":"\u0027oslo_messaging_rabbit\u0027. Example shown below::"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"dab17558_2873df16","line":92,"range":{"start_line":92,"start_character":43,"end_line":92,"end_character":75},"in_reply_to":"dab17558_2572ebe3","updated":"2016-05-13 18:26:03.000000000","message":"Addressed in next patch.","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"}],"keystonemiddleware/audit.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"fafefbf2609d63136132b693ba1606a32a613341","unresolved":false,"context_lines":[{"line_number":57,"context_line":"_LOG \u003d None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"_AUDIT_OPTS \u003d ["},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027notification_driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_47d5c7e2","line":60,"updated":"2016-02-24 17:15:44.000000000","message":"Since we have a new group (see comment in line 73). this can be just \u0027driver\u0027 just like:\nhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/notifier.py#n32","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"935f2f63096f140349236fd541568090a6a20d4b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"_LOG \u003d None"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"_AUDIT_OPTS \u003d ["},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027notification_driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_46402636","line":60,"in_reply_to":"bae84128_47d5c7e2","updated":"2016-02-24 18:00:42.000000000","message":"Changed in patch# 7 to \u0027driver\u0027.","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"fafefbf2609d63136132b693ba1606a32a613341","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":65,"context_line":"               default\u003dNone,"},{"line_number":66,"context_line":"               help\u003d\u0027AMQP topic used for OpenStack notifications.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_a714939f","line":64,"updated":"2016-02-24 17:15:44.000000000","message":"This should be a list opt just like:\nhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/notifier.py#n45\n\nAnd the name should be \u0027topics\u0027 as well","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"935f2f63096f140349236fd541568090a6a20d4b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":65,"context_line":"               default\u003dNone,"},{"line_number":66,"context_line":"               help\u003d\u0027AMQP topic used for OpenStack notifications.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_86334ef6","line":64,"in_reply_to":"bae84128_a714939f","updated":"2016-02-24 18:00:42.000000000","message":"As per Notifier interface, it expects single topic and converts to list if provided as per http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/notifier.py#n178\n\nSo it does not look like there is option to pass multiple topic similar to notification driver. I will have to keep it single topic. Let me know if can be otherwise.","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"fafefbf2609d63136132b693ba1606a32a613341","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cfg.StrOpt(\u0027topic\u0027,"},{"line_number":65,"context_line":"               default\u003dNone,"},{"line_number":66,"context_line":"               help\u003d\u0027AMQP topic used for OpenStack notifications.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":68,"context_line":"               default\u003dNone,"},{"line_number":69,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":70,"context_line":"               \u0027 notification. If not specified, we fall back to the same \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_47eca7ba","line":67,"updated":"2016-02-24 17:15:44.000000000","message":"This is good since it mirrors:\nhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/notify/notifier.py#n39","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"fafefbf2609d63136132b693ba1606a32a613341","unresolved":false,"context_lines":[{"line_number":70,"context_line":"               \u0027 notification. If not specified, we fall back to the same \u0027"},{"line_number":71,"context_line":"               \u0027 configuration used for RPC.\u0027),"},{"line_number":72,"context_line":"]"},{"line_number":73,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def _log_and_ignore_error(fn):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_47be67ae","line":73,"updated":"2016-02-24 17:15:44.000000000","message":"I\u0027d recommend using \u0027audit_middleware_notifications\u0027 as the group:\n\ntrying to mirror the group name used in oslo.messaging:\nhttp://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/opts.py#n48","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"935f2f63096f140349236fd541568090a6a20d4b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"               \u0027 notification. If not specified, we fall back to the same \u0027"},{"line_number":71,"context_line":"               \u0027 configuration used for RPC.\u0027),"},{"line_number":72,"context_line":"]"},{"line_number":73,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def _log_and_ignore_error(fn):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_86618ed6","line":73,"in_reply_to":"bae84128_47be67ae","updated":"2016-02-24 18:00:42.000000000","message":"Changed in patch# 7.","commit_id":"d89a7777241023e2c5389f54e2504178fa02f2b0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":65,"context_line":"                default\u003dNone,"},{"line_number":66,"context_line":"                help\u003d\u0027List of AMQP topic used for OpenStack notifications.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_57b63af9","line":63,"updated":"2016-04-20 17:19:08.000000000","message":"What is the default is None is specified? Would be a good idea to mention that.\n\n- also -\n\npossible values are","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"f80793f744b71a8bc8bb83a94bebfe9c2570f3b5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":65,"context_line":"                default\u003dNone,"},{"line_number":66,"context_line":"                help\u003d\u0027List of AMQP topic used for OpenStack notifications.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_cb7f3e13","line":63,"in_reply_to":"1a122d0e_29aa4219","updated":"2016-04-20 20:39:34.000000000","message":"\u0027value\u0027 in this context is referring to the list of possible values. So it should read \u0027Possible values are messaging, ..., test and noop.\u0027","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"3e780296f60d77820c101776f9fb10fb782db3e0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":65,"context_line":"                default\u003dNone,"},{"line_number":66,"context_line":"                help\u003d\u0027List of AMQP topic used for OpenStack notifications.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_29aa4219","line":63,"in_reply_to":"1a122d0e_57b63af9","updated":"2016-04-20 18:24:17.000000000","message":"I will add what is used when not specified for driver and topics properties.\n\nHere \u0027driver\u0027 is a single string property. That\u0027s why its specified as \u0027Possible value is\u0027.","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"7f8ccfb74533be6faf0d9a5cb19b32c6094b2e48","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible\u0027"},{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":65,"context_line":"                default\u003dNone,"},{"line_number":66,"context_line":"                help\u003d\u0027List of AMQP topic used for OpenStack notifications.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_4b984e1c","line":63,"in_reply_to":"1a122d0e_cb7f3e13","updated":"2016-04-20 20:45:33.000000000","message":"I was taking it as a value of property. Okay..will address in patch 11 as already have new patch 10 with other changes.","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               \u0027value is  messaging, messagingv2, routing, log, test, noop\u0027),"},{"line_number":64,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":65,"context_line":"                default\u003dNone,"},{"line_number":66,"context_line":"                help\u003d\u0027List of AMQP topic used for OpenStack notifications.\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":68,"context_line":"               default\u003dNone,"},{"line_number":69,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_37a45eb8","line":66,"updated":"2016-04-20 17:19:08.000000000","message":"topics","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":68,"context_line":"               default\u003dNone,"},{"line_number":69,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":70,"context_line":"               \u0027 notification. If not specified, we fall back to the same \u0027"},{"line_number":71,"context_line":"               \u0027 configuration used for RPC.\u0027),"},{"line_number":72,"context_line":"]"},{"line_number":73,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_f79e6661","line":70,"updated":"2016-04-20 17:19:08.000000000","message":"why add spaces to the beginning of the line if you are already adding them to the end?","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        transport_aliases \u003d self._get_aliases(cfg.CONF.project)"},{"line_number":363,"context_line":"        if messaging:"},{"line_number":364,"context_line":"            self._notifier \u003d oslo_messaging.Notifier("},{"line_number":365,"context_line":"                oslo_messaging.get_transport("},{"line_number":366,"context_line":"                    cfg.CONF,"},{"line_number":367,"context_line":"                    url\u003dcfg.CONF.audit_middleware_notifications.transport_url,"},{"line_number":368,"context_line":"                    aliases\u003dtransport_aliases),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_d7a7eaa4","line":365,"updated":"2016-04-20 17:19:08.000000000","message":"(nit) it might be nice to have \u0027transport \u003d ....get_transport(...)\u0027 on its own line to make this easier to read","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dc3f41c80796fcfad02c0eeb8c977fdcbff3e141","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":74,"context_line":"               \u0027notification. If not specified, we fall back to the same \u0027"},{"line_number":75,"context_line":"               \u0027configuration used for RPC.\u0027),"},{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_6c0f2937","line":75,"updated":"2016-05-11 22:10:05.000000000","message":"transport_url depends of the driver, right? Suggest to add here what are the drivers allowed for it.","commit_id":"061ddbcf98e1259dd5d12082923da0dccbcdf354"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"5b896172c0d712772fc37a793b26d46695e8edef","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":74,"context_line":"               \u0027notification. If not specified, we fall back to the same \u0027"},{"line_number":75,"context_line":"               \u0027configuration used for RPC.\u0027),"},{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_58c77f95","line":75,"in_reply_to":"dab17558_3d5c2d4a","updated":"2016-05-12 00:16:44.000000000","message":"Looks like transport_url needs to be specified as \u0027secret\u003dTrue\u0027. So will make this change in next patch #12.","commit_id":"061ddbcf98e1259dd5d12082923da0dccbcdf354"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"15bd1e919e3bb18aa8902bc90a1b0df75f590e1b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":74,"context_line":"               \u0027notification. If not specified, we fall back to the same \u0027"},{"line_number":75,"context_line":"               \u0027configuration used for RPC.\u0027),"},{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_3d5c2d4a","line":75,"in_reply_to":"dab17558_6c0f2937","updated":"2016-05-12 00:10:51.000000000","message":"oslo messaging keeps enhancing list of supported drivers e.g. rabbitmq, zeromq etc. Even oslo messaging code does not include it in their side. https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/notifier.py#L40\n\n\nTransport url sample : https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/transport.py#L157","commit_id":"061ddbcf98e1259dd5d12082923da0dccbcdf354"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58ac094344c2b83e1ab448983f8afcf1439bec57","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible \u0027"},{"line_number":63,"context_line":"               \u0027values are messaging, messagingv2, routing, log, test, noop. \u0027"},{"line_number":64,"context_line":"               \u0027If not specified, then value from oslo_messaging_notifications\u0027"},{"line_number":65,"context_line":"               \u0027 conf section is used.\u0027),"},{"line_number":66,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":67,"context_line":"                default\u003dNone,"},{"line_number":68,"context_line":"                help\u003d\u0027List of AMQP topics used for OpenStack notifications. If\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_45b0cf8b","line":65,"range":{"start_line":63,"start_character":15,"end_line":65,"end_character":41},"updated":"2016-05-13 17:58:17.000000000","message":"nit: these should get tabbed over a bit to line up with \u0027The...","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"fa6ebb245bb79b754a8debe60c00d03863e8d82c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":61,"context_line":"               default\u003dNone,"},{"line_number":62,"context_line":"               help\u003d\u0027The Driver to handle sending notifications. Possible \u0027"},{"line_number":63,"context_line":"               \u0027values are messaging, messagingv2, routing, log, test, noop. \u0027"},{"line_number":64,"context_line":"               \u0027If not specified, then value from oslo_messaging_notifications\u0027"},{"line_number":65,"context_line":"               \u0027 conf section is used.\u0027),"},{"line_number":66,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":67,"context_line":"                default\u003dNone,"},{"line_number":68,"context_line":"                help\u003d\u0027List of AMQP topics used for OpenStack notifications. If\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_68632742","line":65,"range":{"start_line":63,"start_character":15,"end_line":65,"end_character":41},"in_reply_to":"dab17558_45b0cf8b","updated":"2016-05-13 18:26:03.000000000","message":"Addressed in next patch.","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58ac094344c2b83e1ab448983f8afcf1439bec57","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":67,"context_line":"                default\u003dNone,"},{"line_number":68,"context_line":"                help\u003d\u0027List of AMQP topics used for OpenStack notifications. If\u0027"},{"line_number":69,"context_line":"                \u0027 not specified, then value from oslo_messaging_notifications \u0027"},{"line_number":70,"context_line":"                \u0027conf section is used.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_25ab0b20","line":70,"range":{"start_line":69,"start_character":16,"end_line":70,"end_character":41},"updated":"2016-05-13 17:58:17.000000000","message":"same","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"fa6ebb245bb79b754a8debe60c00d03863e8d82c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.ListOpt(\u0027topics\u0027,"},{"line_number":67,"context_line":"                default\u003dNone,"},{"line_number":68,"context_line":"                help\u003d\u0027List of AMQP topics used for OpenStack notifications. If\u0027"},{"line_number":69,"context_line":"                \u0027 not specified, then value from oslo_messaging_notifications \u0027"},{"line_number":70,"context_line":"                \u0027conf section is used.\u0027),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_484f43bd","line":70,"range":{"start_line":69,"start_character":16,"end_line":70,"end_character":41},"in_reply_to":"dab17558_25ab0b20","updated":"2016-05-13 18:26:03.000000000","message":"Addressed in next patch.","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58ac094344c2b83e1ab448983f8afcf1439bec57","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               secret\u003dTrue,"},{"line_number":74,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":75,"context_line":"               \u0027notification. If not specified, we fall back to the same \u0027"},{"line_number":76,"context_line":"               \u0027configuration used for RPC.\u0027),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_65a51346","line":76,"range":{"start_line":75,"start_character":15,"end_line":76,"end_character":46},"updated":"2016-05-13 17:58:17.000000000","message":"same","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"fa6ebb245bb79b754a8debe60c00d03863e8d82c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               secret\u003dTrue,"},{"line_number":74,"context_line":"               help\u003d\u0027A URL representing messaging driver to use for \u0027"},{"line_number":75,"context_line":"               \u0027notification. If not specified, we fall back to the same \u0027"},{"line_number":76,"context_line":"               \u0027configuration used for RPC.\u0027),"},{"line_number":77,"context_line":"]"},{"line_number":78,"context_line":"cfg.CONF.register_opts(_AUDIT_OPTS, group\u003d\"audit_middleware_notifications\")"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_88c76b11","line":76,"range":{"start_line":75,"start_character":15,"end_line":76,"end_character":46},"in_reply_to":"dab17558_65a51346","updated":"2016-05-13 18:26:03.000000000","message":"Addressed in next patch.","commit_id":"4fe7165d0d83c0a839f5dfe5f7ef415332280157"}],"keystonemiddleware/tests/unit/test_audit_middleware.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a722f8e5443c065c73ebadd66fe7dcdc064421c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            middleware(req)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"            self.assertEqual(2, notify.call_count)"},{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_f92459b3","line":215,"range":{"start_line":215,"start_character":12,"end_line":215,"end_character":65},"updated":"2016-05-12 13:03:53.000000000","message":"what about:\n\n  first \u003d notify.call_args_list[0]\n  second \u003d notify.call_args_list[1]","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"cb773cd15538456048ae33d30b3ac3bdaf6f0d22","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            middleware(req)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"            self.assertEqual(2, notify.call_count)"},{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_9098766c","line":215,"range":{"start_line":215,"start_character":12,"end_line":215,"end_character":65},"in_reply_to":"dab17558_f92459b3","updated":"2016-05-12 16:32:19.000000000","message":"Existing code. No change made in this review.","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a722f8e5443c065c73ebadd66fe7dcdc064421c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self.assertEqual(2, notify.call_count)"},{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            # ensure exact same context is used between request and response"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_ee2f6da5","line":217,"range":{"start_line":217,"start_character":64,"end_line":217,"end_character":65},"updated":"2016-05-12 13:03:53.000000000","message":"nit: remove the .","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"cb773cd15538456048ae33d30b3ac3bdaf6f0d22","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            self.assertEqual(2, notify.call_count)"},{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            # ensure exact same context is used between request and response"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_f072a248","line":217,"range":{"start_line":217,"start_character":64,"end_line":217,"end_character":65},"in_reply_to":"dab17558_ee2f6da5","updated":"2016-05-12 16:32:19.000000000","message":"Its existing code. No change made in this review.","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"9a722f8e5443c065c73ebadd66fe7dcdc064421c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            # ensure exact same context is used between request and response"},{"line_number":221,"context_line":"            self.assertIs(first[0], second[0])"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_b96131d6","line":218,"range":{"start_line":218,"start_character":12,"end_line":218,"end_character":49},"updated":"2016-05-12 13:03:53.000000000","message":"can\u0027t you verify the context itself? this type checking is not saying much about what we expect here","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"bb27265ae1a39f05c0cf2eb7809b70befb697ad2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            # ensure exact same context is used between request and response"},{"line_number":221,"context_line":"            self.assertIs(first[0], second[0])"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_e10bf229","line":218,"range":{"start_line":218,"start_character":12,"end_line":218,"end_character":49},"in_reply_to":"dab17558_7086b214","updated":"2016-05-12 17:47:54.000000000","message":"you are right, got confused by gerrit :)","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"cb773cd15538456048ae33d30b3ac3bdaf6f0d22","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            first, second \u003d [a[0] for a in notify.call_args_list]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"            # the Context is the first argument. Let\u0027s verify it."},{"line_number":218,"context_line":"            self.assertIsInstance(first[0], dict)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"            # ensure exact same context is used between request and response"},{"line_number":221,"context_line":"            self.assertIs(first[0], second[0])"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_7086b214","line":218,"range":{"start_line":218,"start_character":12,"end_line":218,"end_character":49},"in_reply_to":"dab17558_b96131d6","updated":"2016-05-12 16:32:19.000000000","message":"This is an existing code and no change was made in this test. Let me check reason for unit test failures as I just did rebase of my review with master with no conflicts.","commit_id":"ba745c975960a6c8ff1dc7edfedbe6ee730b9265"}],"releasenotes/notes/bug-1544840-a534127f8663e40f.yaml":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"9825e5e372ba9403fa46cad60c50984baf99c840","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1544840 \u003chttps://bugs.launchpad.net/keystonemiddleware/+bug/1544840\u003e`_]"},{"line_number":5,"context_line":"    Adding audit middleware specific notification related configuration"},{"line_number":6,"context_line":"    to allow different notification driver and transport for audit if needed."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_97cf3255","line":6,"updated":"2016-04-20 17:19:08.000000000","message":"allow a different","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"3e780296f60d77820c101776f9fb10fb782db3e0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1544840 \u003chttps://bugs.launchpad.net/keystonemiddleware/+bug/1544840\u003e`_]"},{"line_number":5,"context_line":"    Adding audit middleware specific notification related configuration"},{"line_number":6,"context_line":"    to allow different notification driver and transport for audit if needed."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_896f16fb","line":6,"in_reply_to":"1a122d0e_97cf3255","updated":"2016-04-20 18:24:17.000000000","message":"Okay..will address it in next patch.","commit_id":"78c1261e601115fe2ad3f03327828993089fa8b8"}]}