)]}'
{"keystonemiddleware/auth_token/_signing_dir.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"660277a30ff9ec7f54fc42482d6a78014b7debe8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self._log \u003d log or _LOG"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self._directory_name \u003d directory_name"},{"line_number":32,"context_line":"        if self._directory_name:"},{"line_number":33,"context_line":"            self._log.info("},{"line_number":34,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"},{"line_number":35,"context_line":"                self._directory_name)"},{"line_number":36,"context_line":"            self._verify_signing_dir()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def write_file(self, file_name, new_contents):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_1edaf178","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":38},"updated":"2016-04-11 22:57:02.000000000","message":"This could all go into _calc_path and not log anything until it\u0027s used. This comment is definitely more of a NIT than a blocker, but we can delay calling _verify_signing_dir this way and consolidate code/log lines.","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"00202ee24ba649614f5a2eedd4f39b4fef39117a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self._log \u003d log or _LOG"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self._directory_name \u003d directory_name"},{"line_number":32,"context_line":"        if self._directory_name:"},{"line_number":33,"context_line":"            self._log.info("},{"line_number":34,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"},{"line_number":35,"context_line":"                self._directory_name)"},{"line_number":36,"context_line":"            self._verify_signing_dir()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def write_file(self, file_name, new_contents):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_7e9fa55f","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"5a18252c_1edaf178","updated":"2016-04-11 23:14:42.000000000","message":"That\u0027s what I did initially. The problem with it is there would be two implementation choices: 1) only log and verify when the directory is created, which would mean not doing those things if the directory already existed, or 2) log and verify every time _lazy_create_signing_dir is run, which would spam the logs and cause a (tiny) performance degradation since _verify_signing_dir would be run all the time.","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6d94f18e30689a06571654304a08d6545f19d315","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self._log \u003d log or _LOG"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        self._directory_name \u003d directory_name"},{"line_number":32,"context_line":"        if self._directory_name:"},{"line_number":33,"context_line":"            self._log.info("},{"line_number":34,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"},{"line_number":35,"context_line":"                self._directory_name)"},{"line_number":36,"context_line":"            self._verify_signing_dir()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def write_file(self, file_name, new_contents):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_12aaddd4","line":36,"range":{"start_line":32,"start_character":0,"end_line":36,"end_character":38},"in_reply_to":"5a18252c_7e9fa55f","updated":"2016-04-12 06:49:55.000000000","message":"Fair enough. I was thinking of it being overall gated with an if block, but as I said, these comments are at best nitpicking and def. shouldn\u0027t hold anything up.","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"660277a30ff9ec7f54fc42482d6a78014b7debe8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return os.path.join(self._directory_name, file_name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _lazy_create_signing_dir(self):"},{"line_number":68,"context_line":"        if self._directory_name is None:"},{"line_number":69,"context_line":"            self._directory_name \u003d tempfile.mkdtemp(prefix\u003d\u0027keystone-signing-\u0027)"},{"line_number":70,"context_line":"            self._log.info("},{"line_number":71,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_9ed44148","line":68,"updated":"2016-04-11 22:57:02.000000000","message":"if the above comment is used and all the logic is moved into calc_path, this check could be removed since you\u0027ll already know if you need to lazy create the path.","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"660277a30ff9ec7f54fc42482d6a78014b7debe8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            self._directory_name \u003d tempfile.mkdtemp(prefix\u003d\u0027keystone-signing-\u0027)"},{"line_number":70,"context_line":"            self._log.info("},{"line_number":71,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"},{"line_number":72,"context_line":"                self._directory_name)"},{"line_number":73,"context_line":"            self._verify_signing_dir()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _verify_signing_dir(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_5ebbc90e","line":72,"updated":"2016-04-11 22:57:02.000000000","message":"This log line could be consolidated if the original comment in this file is followed, since you can make lazy create just do the creation and calc path can emit the log line(s).\n\n  if self._directory_name is None:\n      self._lazy_create_signing_dir()\n  self._log.info(...)\n  ...\n\nLikewise ._verify_signing_dir could be skipped in lazy_Create_path","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"00202ee24ba649614f5a2eedd4f39b4fef39117a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            self._directory_name \u003d tempfile.mkdtemp(prefix\u003d\u0027keystone-signing-\u0027)"},{"line_number":70,"context_line":"            self._log.info("},{"line_number":71,"context_line":"                _LI(\u0027Using %s as cache directory for signing certificate\u0027),"},{"line_number":72,"context_line":"                self._directory_name)"},{"line_number":73,"context_line":"            self._verify_signing_dir()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _verify_signing_dir(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_9e08c193","line":72,"in_reply_to":"5a18252c_5ebbc90e","updated":"2016-04-11 23:14:42.000000000","message":"Same reply as above, I don\u0027t want to spam the logs every time calc_path is run or reverify a directory that\u0027s already been verified.","commit_id":"0f426e7f9e86385cab698f73d6ecb1d8e6b4898a"}]}