)]}'
{"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d4925f968ef96ffe94c67e18478f05a97c278c94","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    _SIGNING_CA_FILE_NAME \u003d \u0027cacert.pem\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def __init__(self, app, conf):"},{"line_number":461,"context_line":"        from keystonemiddleware import opts"},{"line_number":462,"context_line":"        log \u003d logging.getLogger(conf.get(\u0027log_name\u0027, __name__))"},{"line_number":463,"context_line":"        log.info(_LI(\u0027Starting Keystone auth_token middleware\u0027))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1ddd46e0","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":43},"updated":"2016-06-13 14:15:35.000000000","message":"This needs a comment saying why it needs to be imported here","commit_id":"15cc760ced0b9452db0fdd7a0835db52c9433a01"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"26060c65d5d7ce68e2b26f0c7c742c5a064c1e7f","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    _SIGNING_CA_FILE_NAME \u003d \u0027cacert.pem\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def __init__(self, app, conf):"},{"line_number":461,"context_line":"        from keystonemiddleware import opts"},{"line_number":462,"context_line":"        log \u003d logging.getLogger(conf.get(\u0027log_name\u0027, __name__))"},{"line_number":463,"context_line":"        log.info(_LI(\u0027Starting Keystone auth_token middleware\u0027))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3846504f","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":43},"in_reply_to":"7aa08908_1ddd46e0","updated":"2016-06-13 14:22:14.000000000","message":"++","commit_id":"15cc760ced0b9452db0fdd7a0835db52c9433a01"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"da7f9763189483a6745c97c47f5ab56a76d196fe","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    _SIGNING_CA_FILE_NAME \u003d \u0027cacert.pem\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def __init__(self, app, conf):"},{"line_number":461,"context_line":"        from keystonemiddleware import opts"},{"line_number":462,"context_line":"        log \u003d logging.getLogger(conf.get(\u0027log_name\u0027, __name__))"},{"line_number":463,"context_line":"        log.info(_LI(\u0027Starting Keystone auth_token middleware\u0027))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_82fd4eb3","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":43},"in_reply_to":"7aa08908_1ddd46e0","updated":"2016-06-13 14:44:09.000000000","message":"I just took a look at the code and I don\u0027t see a reason why the code from keystonemiddleware opts isn\u0027t just moved into keystonemiddleware.auth_token. It is only logic about  auth_token anyway.","commit_id":"15cc760ced0b9452db0fdd7a0835db52c9433a01"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"18ebeb78b402a1ce07f314ee09516554699fe759","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    _SIGNING_CA_FILE_NAME \u003d \u0027cacert.pem\u0027"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def __init__(self, app, conf):"},{"line_number":461,"context_line":"        from keystonemiddleware import opts"},{"line_number":462,"context_line":"        log \u003d logging.getLogger(conf.get(\u0027log_name\u0027, __name__))"},{"line_number":463,"context_line":"        log.info(_LI(\u0027Starting Keystone auth_token middleware\u0027))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_22ad7a84","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":43},"in_reply_to":"7aa08908_82fd4eb3","updated":"2016-06-13 14:46:37.000000000","message":"true, think we can duplicate the code for now and add a warning to whom is importing keystonemiddleware.opts (if any?)?","commit_id":"15cc760ced0b9452db0fdd7a0835db52c9433a01"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"00d72f0c432dd6c4eea2dc4cfeea23aa4b14b686","unresolved":false,"context_lines":[{"line_number":231,"context_line":"from keystonemiddleware.auth_token import _request"},{"line_number":232,"context_line":"from keystonemiddleware.auth_token import _revocations"},{"line_number":233,"context_line":"from keystonemiddleware.auth_token import _signing_dir"},{"line_number":234,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":235,"context_line":"from keystonemiddleware.auth_token import _user_plugin"},{"line_number":236,"context_line":"from keystonemiddleware.i18n import _, _LC, _LE, _LI, _LW"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_6b559d4e","line":234,"range":{"start_line":234,"start_character":42,"end_line":234,"end_character":47},"updated":"2016-06-13 15:52:37.000000000","message":"isn\u0027t pep8 complaining about this? imports out of order","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"98019acd97dcacd71b8773e4c8163df4a5fb5144","unresolved":false,"context_lines":[{"line_number":231,"context_line":"from keystonemiddleware.auth_token import _request"},{"line_number":232,"context_line":"from keystonemiddleware.auth_token import _revocations"},{"line_number":233,"context_line":"from keystonemiddleware.auth_token import _signing_dir"},{"line_number":234,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":235,"context_line":"from keystonemiddleware.auth_token import _user_plugin"},{"line_number":236,"context_line":"from keystonemiddleware.i18n import _, _LC, _LE, _LI, _LW"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d6043816","line":234,"range":{"start_line":234,"start_character":42,"end_line":234,"end_character":47},"in_reply_to":"7aa08908_6b559d4e","updated":"2016-06-13 15:58:58.000000000","message":"Yes this would need to be fixed.","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"dd6397038ebf6b51d008dc6189cad94220101aa1","unresolved":false,"context_lines":[{"line_number":231,"context_line":"from keystonemiddleware.auth_token import _request"},{"line_number":232,"context_line":"from keystonemiddleware.auth_token import _revocations"},{"line_number":233,"context_line":"from keystonemiddleware.auth_token import _signing_dir"},{"line_number":234,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":235,"context_line":"from keystonemiddleware.auth_token import _user_plugin"},{"line_number":236,"context_line":"from keystonemiddleware.i18n import _, _LC, _LE, _LI, _LW"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f6ddf414","line":234,"range":{"start_line":234,"start_character":42,"end_line":234,"end_character":47},"in_reply_to":"7aa08908_d6043816","updated":"2016-06-13 16:07:11.000000000","message":"Done","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"}],"keystonemiddleware/opts.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ae9008f8681eff3a79f55f31fc00d49f5bda698b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from keystoneauth1 import loading"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from keystonemiddleware.auth_token import _base"},{"line_number":24,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2b6a75ed","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":47},"updated":"2016-06-13 15:53:17.000000000","message":"these 2 will still cause keystonemiddleware/auth_token/__init__.py to be evaluated","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"98019acd97dcacd71b8773e4c8163df4a5fb5144","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from keystoneauth1 import loading"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from keystonemiddleware.auth_token import _base"},{"line_number":24,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_96b3d04c","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":47},"in_reply_to":"7aa08908_2b6a75ed","updated":"2016-06-13 15:58:58.000000000","message":"I don\u0027t think this matters now that auth_token no longer imports this module.","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"c84417d2e89aeda072ee693bc8ff5de38fc14b11","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from keystoneauth1 import loading"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from keystonemiddleware.auth_token import _base"},{"line_number":24,"context_line":"from keystonemiddleware.auth_token import _opts"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f674d49c","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":47},"in_reply_to":"7aa08908_2b6a75ed","updated":"2016-06-13 15:57:09.000000000","message":"yes, but __init__ is not importing opts but _opts, so we are breaking the loop.","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"98019acd97dcacd71b8773e4c8163df4a5fb5144","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"},{"line_number":28,"context_line":"     _opts._OPTS + loading.get_auth_common_conf_options())"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_76de246e","line":28,"updated":"2016-06-13 15:58:58.000000000","message":"Isn\u0027t _auth.OPTS dramatically different from _opts._OPTS? auth_token_opts will now contains *all* of the options and not sure the ones it cares about.","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"eb9a5aa7d16865eefe317051ab1ad3b3c3ccf05a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"},{"line_number":28,"context_line":"     _opts._OPTS + loading.get_auth_common_conf_options())"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5c66a9ed","line":28,"in_reply_to":"7aa08908_31b3069c","updated":"2016-06-13 16:33:43.000000000","message":"Blah....don\u0027t listen to this last comment.","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"dd6397038ebf6b51d008dc6189cad94220101aa1","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"},{"line_number":28,"context_line":"     _opts._OPTS + loading.get_auth_common_conf_options())"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d6f39871","line":28,"in_reply_to":"7aa08908_76de246e","updated":"2016-06-13 16:07:11.000000000","message":"I\u0027m joining former _opts._OPTS and _auth.OPTS in  _opts._OPTS. My undersntanding is that both set of options are always registered, so I\u0027m not sure why to split them, am i missing something?","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"11224710e494619bca88ddb40a309fc75ccd4df6","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"auth_token_opts \u003d ["},{"line_number":27,"context_line":"    (_base.AUTHTOKEN_GROUP,"},{"line_number":28,"context_line":"     _opts._OPTS + loading.get_auth_common_conf_options())"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_31b3069c","line":28,"in_reply_to":"7aa08908_d6f39871","updated":"2016-06-13 16:27:46.000000000","message":"Whatever is using list_auth_token_opts expects to get back auth_token options and now it gets back *all* options. Does this cause a problem?","commit_id":"5e17305d33d20512d65e8a44952f311a3c0d9cf2"}]}
