)]}'
{"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5eba375bfc0d63c1de5438e95e71f2ccfb7b1452","unresolved":false,"context_lines":[{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        self._conf \u003d config.Config(\u0027auth_token\u0027,"},{"line_number":497,"context_line":"                                   _base.AUTHTOKEN_GROUP,"},{"line_number":498,"context_line":"                                   opts.list_auth_token_opts(),"},{"line_number":499,"context_line":"                                   conf)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        super(AuthProtocol, self).__init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_dc045916","line":498,"range":{"start_line":498,"start_character":35,"end_line":498,"end_character":62},"updated":"2016-06-13 16:32:12.000000000","message":"You have to change this call to the new list_auth_token_opts()","commit_id":"dcc7cd53438e52608a065384adee004b1f0cba03"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6271283d6576541ddbc0ed6e234eb6d7e1595632","unresolved":false,"context_lines":[{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        self._conf \u003d config.Config(\u0027auth_token\u0027,"},{"line_number":497,"context_line":"                                   _base.AUTHTOKEN_GROUP,"},{"line_number":498,"context_line":"                                   opts.list_auth_token_opts(),"},{"line_number":499,"context_line":"                                   conf)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        super(AuthProtocol, self).__init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7c4c4542","line":498,"range":{"start_line":498,"start_character":35,"end_line":498,"end_character":62},"in_reply_to":"7aa08908_dc045916","updated":"2016-06-13 16:35:16.000000000","message":"++ good catch. You don\u0027t have to, but it\u0027s definitely more correct.","commit_id":"dcc7cd53438e52608a065384adee004b1f0cba03"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"53543387548e080aeee6a1990394e5d707d3d6ea","unresolved":false,"context_lines":[{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        self._conf \u003d config.Config(\u0027auth_token\u0027,"},{"line_number":497,"context_line":"                                   _base.AUTHTOKEN_GROUP,"},{"line_number":498,"context_line":"                                   opts.list_auth_token_opts(),"},{"line_number":499,"context_line":"                                   conf)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        super(AuthProtocol, self).__init__("}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9cb81113","line":498,"range":{"start_line":498,"start_character":35,"end_line":498,"end_character":62},"in_reply_to":"7aa08908_dc045916","updated":"2016-06-13 16:35:05.000000000","message":"You\u0027re correct!","commit_id":"dcc7cd53438e52608a065384adee004b1f0cba03"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"53e6c92e5aef3db59e73527250f9d1c0838412e9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_auth_token_opts():"},{"line_number":251,"context_line":"    \"\"\"Return a list of oslo_config options available in auth_token middleware."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    The returned list includes all oslo_config options which may be registered"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9cebf1db","line":250,"range":{"start_line":250,"start_character":4,"end_line":250,"end_character":24},"updated":"2016-06-13 16:36:46.000000000","message":"(nit) this can be called list_all_opts since we\u0027re in auth_token there is no need to say auth_token in the method\u0027s name","commit_id":"4d7b72590b7d70dbd88fd3883551064226353b74"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"bde68fefe26a973f657f2dcd1f2799a362e1ffb9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_auth_token_opts():"},{"line_number":251,"context_line":"    \"\"\"Return a list of oslo_config options available in auth_token middleware."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    The returned list includes all oslo_config options which may be registered"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_17a7da0b","line":250,"range":{"start_line":250,"start_character":4,"end_line":250,"end_character":24},"in_reply_to":"7aa08908_3ca8fd8b","updated":"2016-06-13 16:54:41.000000000","message":"++ for list_opts, but you can\u0027t make it private since it\u0027s used outside this module. AUTH_TOKEN_OPTS could be though","commit_id":"4d7b72590b7d70dbd88fd3883551064226353b74"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"4ab9fb6bcd454540a995333cf409fede6d976124","unresolved":false,"context_lines":[{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_auth_token_opts():"},{"line_number":251,"context_line":"    \"\"\"Return a list of oslo_config options available in auth_token middleware."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    The returned list includes all oslo_config options which may be registered"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3ca8fd8b","line":250,"range":{"start_line":250,"start_character":4,"end_line":250,"end_character":24},"in_reply_to":"7aa08908_9cebf1db","updated":"2016-06-13 16:37:34.000000000","message":"Also, should we make it private ?","commit_id":"4d7b72590b7d70dbd88fd3883551064226353b74"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"7a49e1f23f11f41c08ff4f241747f490d2e66ba2","unresolved":false,"context_lines":[{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_opts():"},{"line_number":251,"context_line":"    \"\"\"Return a list of oslo_config options available in auth_token middleware."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    The returned list includes all oslo_config options which may be registered"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_ea55f51d","line":250,"range":{"start_line":250,"start_character":7,"end_line":250,"end_character":8},"updated":"2016-06-14 00:43:13.000000000","message":"I\u0027d really like both of these to be non-public, otherwise if we end up moving again we need to maintain them all.","commit_id":"cc58b62f1120f5a1b436618be82aea7c1a16a281"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"01dc728d3701b2c3e66ab1e1c11b147e462ecaed","unresolved":false,"context_lines":[{"line_number":247,"context_line":"]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def list_opts():"},{"line_number":251,"context_line":"    \"\"\"Return a list of oslo_config options available in auth_token middleware."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    The returned list includes all oslo_config options which may be registered"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9740d9a6","line":250,"range":{"start_line":250,"start_character":7,"end_line":250,"end_character":8},"in_reply_to":"7aa08908_ea55f51d","updated":"2016-06-14 02:07:50.000000000","message":"I agree with AUTH_TOKEN_OPTS being private. I mentioned that in a review or maybe in IRC, but list_opts is used by another module.","commit_id":"cc58b62f1120f5a1b436618be82aea7c1a16a281"}]}
