)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"a0a85b41ac8d51fb617cbcc07f038f719d0418a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As done in the method of \u0027_do_fetch_token\u0027, print the exception"},{"line_number":10,"context_line":"with log level of warning in \u0027fetch_token\u0027, which is helpful to"},{"line_number":11,"context_line":"dubug."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iba789d1986ab2f8209b72d9e01d75c4fa345eb39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_409524dc","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"updated":"2016-10-25 09:02:22.000000000","message":"debug*\n\nThis looks like you are still with debug mode where debug level should be applied, and cannot we just change the log level to acheive the same purpose?","commit_id":"bb4f2969273d6ed644f54d227645900520278020"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"37b53973b57639133ba7a1b955e28f449fe4f5db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As done in the method of \u0027_do_fetch_token\u0027, print the exception"},{"line_number":10,"context_line":"with log level of warning in \u0027fetch_token\u0027, which is helpful to"},{"line_number":11,"context_line":"dubug."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iba789d1986ab2f8209b72d9e01d75c4fa345eb39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da6895a0_c6214ca1","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"in_reply_to":"da6895a0_409524dc","updated":"2016-10-25 09:45:25.000000000","message":"Sorry, it causes you some misunderstanding. I will update the commit message. Thanks for your comments.","commit_id":"bb4f2969273d6ed644f54d227645900520278020"}],"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"73cd1eaad683f505f743ecddcf9ada015906719f","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            self.log.critical(_LC(\u0027Unable to validate token: %s\u0027), e)"},{"line_number":721,"context_line":"            raise webob.exc.HTTPServiceUnavailable()"},{"line_number":722,"context_line":"        except ksm_exceptions.InvalidToken:"},{"line_number":723,"context_line":"            self.log.debug(\u0027Token validation failure.\u0027, exc_info\u003dTrue)"},{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_27e866b4","side":"PARENT","line":723,"range":{"start_line":723,"start_character":55,"end_line":723,"end_character":69},"updated":"2016-10-24 01:51:58.000000000","message":"Shouldn\u0027t it already been done here? since debug is lower than warning, won\u0027t these exception message been shown for warning level? \n\nhttps://docs.python.org/2/library/logging.html#logging.Logger.debug","commit_id":"7ea888a2778ecf28b8e97c18839b29f75ff3a5f6"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"3aec41ab386060447e44aa6922837c4714c3af5e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            self.log.critical(_LC(\u0027Unable to validate token: %s\u0027), e)"},{"line_number":721,"context_line":"            raise webob.exc.HTTPServiceUnavailable()"},{"line_number":722,"context_line":"        except ksm_exceptions.InvalidToken:"},{"line_number":723,"context_line":"            self.log.debug(\u0027Token validation failure.\u0027, exc_info\u003dTrue)"},{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_4a139f0d","side":"PARENT","line":723,"range":{"start_line":723,"start_character":55,"end_line":723,"end_character":69},"in_reply_to":"da6895a0_27e866b4","updated":"2016-10-24 03:00:44.000000000","message":"If the log level is set as warning, then the logs which are\nprinted with lower log level will not be shown in the log file.\nGenerally, the log level will not be set as debug in the production environment. So, it is better to print the exception in the warning log as done in the method \u0027_do_fetch_token\u0027.","commit_id":"7ea888a2778ecf28b8e97c18839b29f75ff3a5f6"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"293574f1030da1a52bd47f9882a2c83a8228f3c9","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            self.log.critical(_LC(\u0027Unable to validate token: %s\u0027), e)"},{"line_number":721,"context_line":"            raise webob.exc.HTTPServiceUnavailable()"},{"line_number":722,"context_line":"        except ksm_exceptions.InvalidToken:"},{"line_number":723,"context_line":"            self.log.debug(\u0027Token validation failure.\u0027, exc_info\u003dTrue)"},{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_6cc6a84a","side":"PARENT","line":723,"range":{"start_line":723,"start_character":55,"end_line":723,"end_character":69},"in_reply_to":"da6895a0_4a139f0d","updated":"2016-10-25 01:24:19.000000000","message":"But the log will still be shown if the log level is defined as warning as you said in the production env, right?","commit_id":"7ea888a2778ecf28b8e97c18839b29f75ff3a5f6"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"cf691735df6f2b3f0f1b920d6e1d7b0b9a6a391c","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            self.log.critical(_LC(\u0027Unable to validate token: %s\u0027), e)"},{"line_number":721,"context_line":"            raise webob.exc.HTTPServiceUnavailable()"},{"line_number":722,"context_line":"        except ksm_exceptions.InvalidToken:"},{"line_number":723,"context_line":"            self.log.debug(\u0027Token validation failure.\u0027, exc_info\u003dTrue)"},{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_0cd28cd2","side":"PARENT","line":723,"range":{"start_line":723,"start_character":55,"end_line":723,"end_character":69},"in_reply_to":"da6895a0_6cc6a84a","updated":"2016-10-25 01:43:00.000000000","message":"If the log level is set as warning, the log on line 723 will not be shown in the log file. Because it is printed with log level of debug.","commit_id":"7ea888a2778ecf28b8e97c18839b29f75ff3a5f6"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"69b1258e7eebbf01be0d1957e0cf26d717beeabf","unresolved":false,"context_lines":[{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"},{"line_number":727,"context_line":"            self.log.warning(_LW(\u0027Authorization failed for token\u0027),"},{"line_number":728,"context_line":"                             exc_info\u003dTrue)"},{"line_number":729,"context_line":"            raise"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_621c2c78","line":727,"range":{"start_line":727,"start_character":21,"end_line":727,"end_character":28},"updated":"2016-11-14 16:28:42.000000000","message":"Shouldn\u0027t this be log.error?","commit_id":"49ae94ae1ba27e4b9b7e38b016d2727a61046b25"},{"author":{"_account_id":18266,"name":"zengchen","email":"chenzeng2@huawei.com","username":"zengchen"},"change_message_id":"2f00b3fccae4c67c7cfc47e1dee7e7687aca7275","unresolved":false,"context_lines":[{"line_number":724,"context_line":"            if token_hashes:"},{"line_number":725,"context_line":"                self._token_cache.set(token_hashes[0],"},{"line_number":726,"context_line":"                                      _CACHE_INVALID_INDICATOR)"},{"line_number":727,"context_line":"            self.log.warning(_LW(\u0027Authorization failed for token\u0027),"},{"line_number":728,"context_line":"                             exc_info\u003dTrue)"},{"line_number":729,"context_line":"            raise"},{"line_number":730,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_ca8d257d","line":727,"range":{"start_line":727,"start_character":21,"end_line":727,"end_character":28},"in_reply_to":"9a629dbe_621c2c78","updated":"2016-11-15 03:11:05.000000000","message":"Thanks for reviewing. I think the level of warning is enough, and stay the same as done as in \u0027_do_fetch_token\u0027.","commit_id":"49ae94ae1ba27e4b9b7e38b016d2727a61046b25"}]}