)]}'
{"keystonemiddleware/tests/unit/auth_token/test_base_middleware.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"ddb3ff1e8acdf0dbd2943e4bc52da68ad3d48326","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        m \u003d FetchingMiddleware(_do_cb, token_dict)"},{"line_number":112,"context_line":"        self.call(m, headers\u003d{\u0027X-Auth-Token\u0027: token_id})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # also try with whitespace in the token"},{"line_number":115,"context_line":"        self.call(m, headers\u003d{\u0027X-Auth-Token\u0027: token_id + \u0027\\r\u0027})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_invalid_user_token(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_a1f0fcca","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":34},"updated":"2017-07-31 17:49:28.000000000","message":"is \\r (carriage return) a whitespace? we should test with \u0027 \u0027 too","commit_id":"f7158c371a3c7cff3d3dd2a2479f986525397541"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"6651f1095729d7726ebdc7172d809230a5c97a44","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        m \u003d FetchingMiddleware(_do_cb, token_dict)"},{"line_number":112,"context_line":"        self.call(m, headers\u003d{\u0027X-Auth-Token\u0027: token_id})"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # also try with whitespace in the token"},{"line_number":115,"context_line":"        self.call(m, headers\u003d{\u0027X-Auth-Token\u0027: token_id + \u0027\\r\u0027})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_invalid_user_token(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f02c8c48","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":34},"in_reply_to":"df3967d1_a1f0fcca","updated":"2017-07-31 20:16:03.000000000","message":"yes, \\r is whitespace, but I can add a test with \u0027 \u0027 to go along with it.","commit_id":"f7158c371a3c7cff3d3dd2a2479f986525397541"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"8c3ede79083c3706b60024970e4cdf80fad12840","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        @webob.dec.wsgify"},{"line_number":91,"context_line":"        def _do_cb(req):"},{"line_number":92,"context_line":"            self.assertEqual(token_id, req.headers[\u0027X-Auth-Token\u0027].strip())"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            self.assertEqual(\u0027Confirmed\u0027, req.headers[\u0027X-Identity-Status\u0027])"},{"line_number":95,"context_line":"            self.assertNotIn(\u0027X-Service-Token\u0027, req.headers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_f0b6ccd9","line":92,"range":{"start_line":92,"start_character":29,"end_line":92,"end_character":74},"updated":"2017-07-31 20:27:06.000000000","message":"would be nice to have tested strip via a call to _do_fetch_token (where we added strip(). this test will keep passing if someone removes strip() from there), but I agree this helps showing strip() will work properly","commit_id":"efb1fb99d87f754a008877f2e2d391221cb43721"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"28abdbe1509aa162349bdc83a8fc756c3cbb4ae2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        @webob.dec.wsgify"},{"line_number":91,"context_line":"        def _do_cb(req):"},{"line_number":92,"context_line":"            self.assertEqual(token_id, req.headers[\u0027X-Auth-Token\u0027].strip())"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"            self.assertEqual(\u0027Confirmed\u0027, req.headers[\u0027X-Identity-Status\u0027])"},{"line_number":95,"context_line":"            self.assertNotIn(\u0027X-Service-Token\u0027, req.headers)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_642b3d94","line":92,"range":{"start_line":92,"start_character":29,"end_line":92,"end_character":74},"in_reply_to":"df3967d1_f0b6ccd9","updated":"2017-07-31 21:13:16.000000000","message":"_do_fetch_token is called indirectly here. This test will not keep passing if someone removes strip from _do_fetch_token. The strip() on this line is required to match up with that strip() in _do_fetch_token.","commit_id":"efb1fb99d87f754a008877f2e2d391221cb43721"}]}