)]}'
{"id":"openstack%2Fkeystonemiddleware~507101","triplet_id":"openstack%2Fkeystonemiddleware~master~I32d08e2dc4529150389e979709509ee0cea12ef4","project":"openstack/keystonemiddleware","branch":"master","topic":"bug/1718945","hashtags":[],"change_id":"I32d08e2dc4529150389e979709509ee0cea12ef4","subject":"Fix mocked URLs for new keystoneauth discovery","status":"ABANDONED","created":"2017-09-25 13:31:03.000000000","updated":"2017-09-25 14:43:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6c5abd9f346eedd19471133072677a93d8f10321","_number":507101,"virtual_id_number":507101,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"all":[{"date":"2017-09-25 14:14:57.000000000","_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-09-25 14:14:57.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"}],"messages":[{"id":"3a5aa777e9ef82cf001c1fc9fd49049a07681528","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-09-25 13:31:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a9689da05bf0a4a273b0293f8f8843449c2768a","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2017-09-25 14:14:57.000000000","message":"Patch Set 1:\n\nA similar patch has already been proposed https://review.openstack.org/#/c/504487/","accounts_in_message":[],"_revision_number":1},{"id":"dbf64eeed2b4b5b8a12dc965f371cf65244c7697","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-09-25 14:43:15.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"011eaee927be9b6c608f6a7be8f6a921bd36f150","revisions":{"011eaee927be9b6c608f6a7be8f6a921bd36f150":{"kind":"REWORK","_number":1,"created":"2017-09-25 13:31:03.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/01/507101/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/01/507101/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/01/507101/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/01/507101/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/01/507101/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/01/507101/1"}}},"commit":{"parents":[{"commit":"cd598a4f839bdd58722240f6a30b992af2ebbe69","subject":"Merge \"Add doc8 rule and check doc/source files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/cd598a4f839bdd58722240f6a30b992af2ebbe69"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2017-09-25 13:23:52.000000000","tz":120},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2017-09-25 13:23:52.000000000","tz":120},"subject":"Fix mocked URLs for new keystoneauth discovery","message":"Fix mocked URLs for new keystoneauth discovery\n\nIn keystoneauth a workaround was implemented for when the discovery\ndocument has an invalid scheme and host for its URLs[1]. This broke\nkeystonemiddleware\u0027s tests, revealing that keystonemiddleware was, in\none case, validating the wrong URL, and in another mocking the wrong\none. This patch updates the tests so that they are more accurately\nrepresenting how keystoneauth works.\n\nWhy should we change it here instead of reverting the keystoneauth\nchange? The URLs in the discovery document aren\u0027t validated in real\nlife, so the only URLs that can be trusted are the ones the user has\naccessed, such as the auth URL. Keystoneauth is right to fix the URLs,\nand the bad mocks in keystonemiddleware are only evidence that the tests\nwere wrong, not that the mocked URLs would have worked in real life.\n\n[1] https://review.openstack.org/#/c/494194\n\nChange-Id: I32d08e2dc4529150389e979709509ee0cea12ef4\nCloses-bug: #1718945\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/011eaee927be9b6c608f6a7be8f6a921bd36f150"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/011eaee927be9b6c608f6a7be8f6a921bd36f150"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cd598a4f839bdd58722240f6a30b992af2ebbe69","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}