)]}'
{"keystonemiddleware/_common/config.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"438458b7ae89a7bc0577596d2ff81bebaf6b0376","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            if v is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_9a01396d","line":49,"updated":"2017-10-26 18:22:55.000000000","message":"It seems like conf only ever has \"here\" and \"__file__\" (and the \"configkey\" that gnocchi and panko add in those cases), and not anything from the paste ini... so is this code actually useful as written? Does it need to be fixed to go get values from the file referenced by __file__? And only check a specific section rather than looking at all keys?","commit_id":"db5c60d221ff4e217ef7a60cae481246a0ccfdc3"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8efe95eff99ba360ffd304313b281d58526ad1ab","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            if v is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_631d750e","line":49,"in_reply_to":"3f4b6375_9a01396d","updated":"2017-10-30 15:35:25.000000000","message":"On devstack I see delay_auth_decision from the glance-api paste file, so I think it is doing something.","commit_id":"db5c60d221ff4e217ef7a60cae481246a0ccfdc3"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"438458b7ae89a7bc0577596d2ff81bebaf6b0376","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                type_, dest \u003d opt_types[k]"},{"line_number":54,"context_line":"                v \u003d type_(v)"},{"line_number":55,"context_line":"        except KeyError:  # nosec"},{"line_number":56,"context_line":"            # This option is not known to auth_token. v is not converted."},{"line_number":57,"context_line":"            _LOG.debug("},{"line_number":58,"context_line":"                \u0027The option \"%s\" in conf is not known to auth_token\u0027, k)"},{"line_number":59,"context_line":"        except ValueError as e:"},{"line_number":60,"context_line":"            raise exceptions.ConfigurationError("},{"line_number":61,"context_line":"                _(\u0027Unable to convert the value of %(key)s option into correct \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_fa16eda7","line":58,"range":{"start_line":56,"start_character":0,"end_line":58,"end_character":72},"updated":"2017-10-26 18:22:55.000000000","message":"this comment and log message are specific to auth_token, yet this is common code. If it\u0027s really specific to auth_token, it should move into the auth_token middleware and out of common code.","commit_id":"db5c60d221ff4e217ef7a60cae481246a0ccfdc3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"081d0f74f7755c0815962e7d817af9d109544a0a","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            # \u0027here\u0027 and \u0027__file__\u0027 come from paste.deploy"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_4dc71714","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"updated":"2018-01-02 20:58:43.000000000","message":"This works, but why doesn\u0027t keystonemiddleware just need its own configuration options? How come we have to parse everything?\n\nIs it possible to just get the keystone_authtoken section and deal with what\u0027s in there?","commit_id":"0c0eae3b1eb537159f26c82647fb61cc3de8536a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7b475860748119c47c30b964cf7efcc1400e3fcf","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            # \u0027here\u0027 and \u0027__file__\u0027 come from paste.deploy"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_1f2ed9f9","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"9f91af0f_4bdf9139","updated":"2018-03-22 02:18:54.000000000","message":"@Lance, like L52 said, the information in \"conf\" is come from paste.deploy or something added in code, not from config file. So keystonemiddleware can\u0027t decide what is in \"conf\".\n\nexample: https://github.com/openstack/glance/blob/master/etc/glance-api-paste.ini#L74\nthe \"conf\" here in Glance is like:\n{\n   \u0027delay_auth_decision\u0027: \u0027true\u0027,\n   \u0027__file__\u0027: \u0027/etc/glance/glance-api-paste.ini\u0027,\n   \u0027here\u0027: \u0027/etc/glance\u0027\n}\n\nSo actually I think it\u0027s a wrong usage by paste or panko/gnocchi itself. What keystonemiddleware can do is to skip the automatically generated ones. Or change the paste or panko/gnochhi to not pass the unconfig things.","commit_id":"0c0eae3b1eb537159f26c82647fb61cc3de8536a"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ecf506f725d1e4a71e6f7d03c5adfa906f94f71c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            # \u0027here\u0027 and \u0027__file__\u0027 come from paste.deploy"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_4bdf9139","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"9f91af0f_4dc71714","updated":"2018-01-08 19:00:42.000000000","message":"hence the second paragraph of the commit message, and Partial-Bug instead of Closes-Bug. I\u0027m sure there\u0027s a better way to do this, just not sure what that is offhand and don\u0027t have time to dig into it. Feel free to take over and propose something better.","commit_id":"0c0eae3b1eb537159f26c82647fb61cc3de8536a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"064c4a9af0fa5bb0a22d4d552f6bacf4d1d65fc8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        break"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    for k, v in conf.items():"},{"line_number":50,"context_line":"        dest \u003d k"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            # \u0027here\u0027 and \u0027__file__\u0027 come from paste.deploy"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_0705d6c0","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":20},"in_reply_to":"df7087c5_1f2ed9f9","updated":"2018-10-26 16:48:40.000000000","message":"tl;dr - paste is not so great in many ways.","commit_id":"0c0eae3b1eb537159f26c82647fb61cc3de8536a"}]}