)]}'
{"id":"openstack%2Fkeystonemiddleware~527466","triplet_id":"openstack%2Fkeystonemiddleware~master~I00e953abb3e835a94353fe458100c96e8e9c095a","project":"openstack/keystonemiddleware","branch":"master","topic":"bug/1737115","hashtags":[],"change_id":"I00e953abb3e835a94353fe458100c96e8e9c095a","subject":"lazy loading of oslo_cache","status":"MERGED","created":"2017-12-12 17:22:44.000000000","updated":"2017-12-13 22:47:10.000000000","submitted":"2017-12-13 22:47:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"527466-1513205230617-897524af","meta_rev_id":"61c19e1cef503e0a9d92e1b19b9d2b1c36f5e192","_number":527466,"virtual_id_number":527466,"owner":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-12-13 20:15:34.000000000","_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2017-12-13 22:47:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"recommended":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-12 19:12:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":1,"date":"2017-12-12 19:56:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2017-12-12 20:21:24.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":1,"date":"2017-12-13 03:23:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2017-12-12 20:21:24.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-12 17:24:05.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2017-12-12 19:12:56.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2017-12-12 19:56:32.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2017-12-12 20:21:24.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2017-12-13 03:23:14.000000000","updated_by":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"reviewer":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"state":"REVIEWER"},{"updated":"2017-12-13 20:15:34.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2017-12-13 22:47:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"440e7bd9dd7aa9be5f03c5e311e0ba779cf59127","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-12-12 17:22:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3668a15da9ef689016e6459d7f732fa074f73a51","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-12-12 18:05:51.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"dc9539cf45f7e26e0daeb748ec7eca7a0dcb2232","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2017-12-12 19:12:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e53ead25246b04e8e7e8c5479b22896aea8b1af7","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-12-12 19:56:32.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nWe should add a release note here since this could impact deployers. \n\nhttps://docs.openstack.org/keystone/latest/contributor/release-notes.html\n\nThanks for the patch!","accounts_in_message":[],"_revision_number":2},{"id":"e0501f081dd8866731467baebd4e9e337f339ff2","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2017-12-12 20:21:24.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"839bc783da9aa35e34e602ef357570f6b3f5850b","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2017-12-12 20:21:55.000000000","message":"Patch Set 2:\n\nApproving this (fast track) to get a fix in. We can revisit the lazy/load requirements addition down the line.","accounts_in_message":[],"_revision_number":2},{"id":"8634ca873889b58fa6e92dd15218efad8cac1de2","author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"date":"2017-12-13 03:23:14.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"39083fb98ad5233fa934c3ef4da1daf1967b6c21","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2017-12-13 20:15:34.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"8a197e65328acbb471b417edea4140349ef5f64b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-13 21:23:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/66/527466/2/check/openstack-tox-pep8/f3bd85e/ : SUCCESS in 4m 59s\n- openstack-tox-py27 http://logs.openstack.org/66/527466/2/check/openstack-tox-py27/62fe2cc/ : SUCCESS in 5m 05s\n- openstack-tox-py35 http://logs.openstack.org/66/527466/2/check/openstack-tox-py35/6db511e/ : SUCCESS in 6m 07s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/527466/2/check/build-openstack-sphinx-docs/e02d8ee/html/ : SUCCESS in 5m 37s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/66/527466/2/check/legacy-tempest-dsvm-neutron-src/29385bc/ : SUCCESS in 1h 06m 40s","accounts_in_message":[],"_revision_number":2},{"id":"e4f0eebc509c18f7b0dae9b78279f13bbdd228a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-13 21:23:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"86f11e7f05df150ae40eae8e916873823e31c833","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-13 22:47:10.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/66/527466/2/gate/openstack-tox-pep8/c1e5025/ : SUCCESS in 4m 06s\n- openstack-tox-py27 http://logs.openstack.org/66/527466/2/gate/openstack-tox-py27/8ae7e4a/ : SUCCESS in 4m 33s\n- openstack-tox-py35 http://logs.openstack.org/66/527466/2/gate/openstack-tox-py35/d7f39b3/ : SUCCESS in 3m 34s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/527466/2/gate/build-openstack-sphinx-docs/5358104/html/ : SUCCESS in 4m 05s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/66/527466/2/gate/legacy-tempest-dsvm-neutron-src/4a48c2a/ : SUCCESS in 1h 22m 08s","accounts_in_message":[],"_revision_number":2},{"id":"41895c943421e4496867f3009761b5676b653d2e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-13 22:47:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"35fa0e1da1b96a40aa2aa6dd2be378e4155a22ba","revisions":{"332d8683127661d070efa59ed1c42d67ea6d284a":{"kind":"REWORK","_number":1,"created":"2017-12-12 17:22:44.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/66/527466/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/66/527466/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/1"}}},"commit":{"parents":[{"commit":"db21ecd2b55578f9fecae29f9b1334ca5d60e28b","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/db21ecd2b55578f9fecae29f9b1334ca5d60e28b"}]}],"author":{"name":"Mehdi Abaakouk","email":"sileht@sileht.net","date":"2017-12-12 17:22:00.000000000","tz":60},"committer":{"name":"Mehdi Abaakouk","email":"sileht@sileht.net","date":"2017-12-12 17:22:01.000000000","tz":60},"subject":"lazy loading of oslo_cache","message":"lazy loading of oslo_cache\n\nNow, we depend on oslo.cache [1], and use the private/internal\nmemcache_pool code of the lib, making oslo.cache failing to import\ninstead of just log an error about missing requirement for selected\ndrivers at runtime.\n\nThis change restores the previous behavior by lazy loading the module.\n\nChange-Id: I00e953abb3e835a94353fe458100c96e8e9c095a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/332d8683127661d070efa59ed1c42d67ea6d284a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/332d8683127661d070efa59ed1c42d67ea6d284a"}]},"branch":"refs/heads/master"},"35fa0e1da1b96a40aa2aa6dd2be378e4155a22ba":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-12-12 18:05:51.000000000","uploader":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"ref":"refs/changes/66/527466/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/66/527466/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/66/527466/2"}}},"commit":{"parents":[{"commit":"db21ecd2b55578f9fecae29f9b1334ca5d60e28b","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/db21ecd2b55578f9fecae29f9b1334ca5d60e28b"}]}],"author":{"name":"Mehdi Abaakouk","email":"sileht@sileht.net","date":"2017-12-12 17:22:00.000000000","tz":60},"committer":{"name":"Mehdi Abaakouk","email":"sileht@sileht.net","date":"2017-12-12 18:05:28.000000000","tz":60},"subject":"lazy loading of oslo_cache","message":"lazy loading of oslo_cache\n\nNow, we depend on oslo.cache [1], and use the private/internal\nmemcache_pool code of the lib, making oslo.cache failing to import\ninstead of just log an error about missing requirement for selected\ndrivers at runtime.\n\nThis change restores the previous behavior by lazy loading the module.\n\n[1] 9d8e2836fe7fca186e0380d8a532540ff5cc5215\n\nChange-Id: I00e953abb3e835a94353fe458100c96e8e9c095a\nCloses-bug: #1737115\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/35fa0e1da1b96a40aa2aa6dd2be378e4155a22ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/35fa0e1da1b96a40aa2aa6dd2be378e4155a22ba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}