)]}'
{"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"47bce199755a6127290c9419828c02d6971b00b9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    presented. This allows the underlying service to determine if a"},{"line_number":73,"context_line":"    denial should use ``401 Unauthenticated`` or ``403 Forbidden``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"HTTP_OPENSTACK_SYSTEM_SCOPE"},{"line_number":76,"context_line":"    A dictionary relaying system information about the token\u0027s scope. This"},{"line_number":77,"context_line":"    attribute is only present if the token is system-scoped."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_920b3c8c","line":75,"updated":"2018-04-25 23:23:54.000000000","message":"I\u0027m not going to get picky, but the name here is odd. Everything else in this list is just X-\u003csomething\u003e, is the break intentional?","commit_id":"b7b163e5db60db0d8332a0bb668dde19e6a36a35"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b6d4255b9ed8a4e658684a18850b45977614d8de","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    presented. This allows the underlying service to determine if a"},{"line_number":73,"context_line":"    denial should use ``401 Unauthenticated`` or ``403 Forbidden``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"HTTP_OPENSTACK_SYSTEM_SCOPE"},{"line_number":76,"context_line":"    A dictionary relaying system information about the token\u0027s scope. This"},{"line_number":77,"context_line":"    attribute is only present if the token is system-scoped."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_89c07c2c","line":75,"in_reply_to":"9f6a8fd7_29b850c6","updated":"2018-05-02 15:53:41.000000000","message":"I don\u0027t expect us to replace all the headers (I would like us to do so, but it\u0027s a lot of work), but we should not add more x- prefixed headers.","commit_id":"b7b163e5db60db0d8332a0bb668dde19e6a36a35"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"985b2e91507a82579c3b8231d817dfb1b62bb4cf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    presented. This allows the underlying service to determine if a"},{"line_number":73,"context_line":"    denial should use ``401 Unauthenticated`` or ``403 Forbidden``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"HTTP_OPENSTACK_SYSTEM_SCOPE"},{"line_number":76,"context_line":"    A dictionary relaying system information about the token\u0027s scope. This"},{"line_number":77,"context_line":"    attribute is only present if the token is system-scoped."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_29b850c6","line":75,"in_reply_to":"9f6a8fd7_5c8cd634","updated":"2018-05-02 15:52:22.000000000","message":"https://tools.ietf.org/html/rfc6648 please stop using x-prefixed headers.","commit_id":"b7b163e5db60db0d8332a0bb668dde19e6a36a35"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"505465c50a8c37a311e692418aaca9f2ad96a505","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    presented. This allows the underlying service to determine if a"},{"line_number":73,"context_line":"    denial should use ``401 Unauthenticated`` or ``403 Forbidden``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"HTTP_OPENSTACK_SYSTEM_SCOPE"},{"line_number":76,"context_line":"    A dictionary relaying system information about the token\u0027s scope. This"},{"line_number":77,"context_line":"    attribute is only present if the token is system-scoped."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5c8cd634","line":75,"in_reply_to":"9f6a8fd7_920b3c8c","updated":"2018-04-26 03:29:08.000000000","message":"Agreed.  Look at the values after this:  Each is a simple string.  I don\u0027t think a dictionary will work. \n\nWhat about HTTP_X_SYSTEM_SCOPE as the value, andany non-Null value for now (True) to be expanded in the future.","commit_id":"b7b163e5db60db0d8332a0bb668dde19e6a36a35"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2ed84b48c5eecff10811e37976dd4613fc630402","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    presented. This allows the underlying service to determine if a"},{"line_number":73,"context_line":"    denial should use ``401 Unauthenticated`` or ``403 Forbidden``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"HTTP_OPENSTACK_SYSTEM_SCOPE"},{"line_number":76,"context_line":"    A string relaying system information about the token\u0027s scope. This"},{"line_number":77,"context_line":"    attribute is only present if the token is system-scoped. The string ``all``"},{"line_number":78,"context_line":"    means the token is scoped to the entire deployment system."}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_18f2e907","line":75,"updated":"2018-05-02 23:09:01.000000000","message":"nit: still looks weird that this doesn\u0027t have X- like everything else. NOt a blocker.","commit_id":"245c91f2e3d499498e5f0edd30c23504cda9d111"}],"keystonemiddleware/auth_token/_request.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"18577ddef0b5f9f40614551b42158abfc590d67e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    ResponseClass \u003d _AuthTokenResponse"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    _HEADER_TEMPLATE \u003d {"},{"line_number":77,"context_line":"        \u0027OpenStack%s-System-Scope\u0027: \u0027system\u0027,"},{"line_number":78,"context_line":"        \u0027X%s-Domain-Id\u0027: \u0027domain_id\u0027,"},{"line_number":79,"context_line":"        \u0027X%s-Domain-Name\u0027: \u0027domain_name\u0027,"},{"line_number":80,"context_line":"        \u0027X%s-Project-Id\u0027: \u0027project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_63159be4","line":77,"updated":"2018-04-24 22:50:35.000000000","message":"I don\u0027t think this belongs in the template but similar to _ADMIN_PROJECT_HEADER, we aren\u0027t doing substitution for AUTH or Service here are we?","commit_id":"1b8434b2dda0abee52b1bdc67b424e66bfd90c96"}]}