)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7f48c67be82dc8b108fae63ea3c804a4a8f67c8d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u0027timeout\u0027 conf option(DuplicateOptError) because it is registered at [2]."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1]: https://review.openstack.org/#/c/505764/"},{"line_number":27,"context_line":"[2]: https://github.com/openstack/glance/blob/master/glance/common/trust_auth.py#L21"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I641366cc857f585117eb7797543e18fdaed46561"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_a792ee56","line":27,"updated":"2018-07-19 07:12:42.000000000","message":"I\u0027m sure this patch will break at least Mistral (same reason as Glance)\nhttps://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L33\n\nSo if we want this option indeed, we should find a safer way. Such as using a new name like what \"http_connect_timeout\" does?","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"ea19cdf7bb41196030cb5039d0aba65522004822","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u0027timeout\u0027 conf option(DuplicateOptError) because it is registered at [2]."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1]: https://review.openstack.org/#/c/505764/"},{"line_number":27,"context_line":"[2]: https://github.com/openstack/glance/blob/master/glance/common/trust_auth.py#L21"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I641366cc857f585117eb7797543e18fdaed46561"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_896c80cf","line":27,"in_reply_to":"5f7c97a3_a792ee56","updated":"2018-07-20 13:49:34.000000000","message":"It will not fail for mistral as patch[1] will resolve this issue.\n[1]: https://review.openstack.org/#/c/572300/","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"}],"keystonemiddleware/auth_token/_opts.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"029000bb2588f69dbe51b3f567932b7ee8c70ca9","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                \u0027 in a future release and should be enabled if possible.\u0027),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027split_loggers\u0027,"},{"line_number":216,"context_line":"                default\u003dFalse,"},{"line_number":217,"context_line":"                help\u003d\u0027Log requests to multiple loggers.\u0027)"},{"line_number":218,"context_line":"]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6cc4c994","line":217,"updated":"2018-07-18 17:39:52.000000000","message":"Outside of the help text provided here, is there any documentation on how to use this, or how it is beneficial? That kind of information would be helpful for people looking to use this.","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7f48c67be82dc8b108fae63ea3c804a4a8f67c8d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                \u0027 in a future release and should be enabled if possible.\u0027),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027split_loggers\u0027,"},{"line_number":216,"context_line":"                default\u003dFalse,"},{"line_number":217,"context_line":"                help\u003d\u0027Log requests to multiple loggers.\u0027)"},{"line_number":218,"context_line":"]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_87cfb252","line":217,"in_reply_to":"5f7c97a3_6cc4c994","updated":"2018-07-19 07:12:42.000000000","message":"++, and where this split_loggers will be used?\nfor example, I think at least it should be called when creating the seesion[1]?\n\n[1]:https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L918","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"ea19cdf7bb41196030cb5039d0aba65522004822","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                \u0027 in a future release and should be enabled if possible.\u0027),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027split_loggers\u0027,"},{"line_number":216,"context_line":"                default\u003dFalse,"},{"line_number":217,"context_line":"                help\u003d\u0027Log requests to multiple loggers.\u0027)"},{"line_number":218,"context_line":"]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a9e61c49","line":217,"in_reply_to":"5f7c97a3_6cc4c994","updated":"2018-07-20 13:49:34.000000000","message":"Are you expecting release note here like added in[1].\n\n[1]: https://review.openstack.org/#/c/581219/","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"ea19cdf7bb41196030cb5039d0aba65522004822","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                \u0027 in a future release and should be enabled if possible.\u0027),"},{"line_number":215,"context_line":"    cfg.BoolOpt(\u0027split_loggers\u0027,"},{"line_number":216,"context_line":"                default\u003dFalse,"},{"line_number":217,"context_line":"                help\u003d\u0027Log requests to multiple loggers.\u0027)"},{"line_number":218,"context_line":"]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c9e91819","line":217,"in_reply_to":"5f7c97a3_87cfb252","updated":"2018-07-20 13:49:34.000000000","message":"This split_loggers conf option will be used in cinder-keystoneclient interaction while creating keystone client.\nRef: https://review.openstack.org/#/c/579765/","commit_id":"410838bf6b4ada35f47ae2d1c701cd7f0c3aed82"}]}