)]}'
{"keystonemiddleware/auth_token/_identity.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3a81ec605bca4eb70b0918e553b550a591f75e7e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Base class for operations on the Identity API server."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    The auth_token middleware needs to communicate with the Identity API server"},{"line_number":124,"context_line":"    to validate UUID tokens, signing certificates,"},{"line_number":125,"context_line":"    etc. This class encapsulates the data and methods to perform these"},{"line_number":126,"context_line":"    operations."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_51b3530a","line":124,"range":{"start_line":124,"start_character":16,"end_line":124,"end_character":20},"updated":"2018-10-30 18:10:12.000000000","message":"We should update this to not be implementation specific, but we can do that in a follow-up.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"178759667043a1afa2801d0a10723537900668a2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    \"\"\"Base class for operations on the Identity API server."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    The auth_token middleware needs to communicate with the Identity API server"},{"line_number":124,"context_line":"    to validate UUID tokens, signing certificates,"},{"line_number":125,"context_line":"    etc. This class encapsulates the data and methods to perform these"},{"line_number":126,"context_line":"    operations."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_54b5817c","line":124,"range":{"start_line":124,"start_character":16,"end_line":124,"end_character":20},"in_reply_to":"3f79a3b5_51b3530a","updated":"2018-10-30 19:06:40.000000000","message":"Yes we should. We should also rip out the UUID specific looking tests.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"}],"keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"2606b38f7fe9ec06699b1dc29019bf6df87ed623","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_init_does_not_call_http(self):"},{"line_number":571,"context_line":"        conf \u003d {"},{"line_number":572,"context_line":"            \u0027revocation_cache_time\u0027: \u00271\u0027"},{"line_number":573,"context_line":"        }"},{"line_number":574,"context_line":"        self.create_simple_middleware(conf\u003dconf)"},{"line_number":575,"context_line":"        self.assertLastPath(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ed2d1b45","line":572,"updated":"2018-10-26 18:41:44.000000000","message":"missed this one","commit_id":"784291b18590d3a4be21e1a38e2da91afb375406"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"2606b38f7fe9ec06699b1dc29019bf6df87ed623","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"        self.assert_valid_request_200("},{"line_number":1626,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"    def test_fallback_to_online_validation_with_revocation_list_error(self):"},{"line_number":1629,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027signed_token_scoped\u0027])"},{"line_number":1630,"context_line":"        self.assert_valid_request_200("},{"line_number":1631,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0d1417e9","line":1628,"updated":"2018-10-26 18:41:44.000000000","message":"remove the whole test","commit_id":"784291b18590d3a4be21e1a38e2da91afb375406"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"268f823f1c492c9146060c0a01b61c80c8b7526f","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    \"\"\"These tests are run once using v2 tokens and again using v3 tokens.\"\"\""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_init_does_not_call_http(self):"},{"line_number":571,"context_line":"        conf \u003d {"},{"line_number":572,"context_line":"            \u0027revocation_cache_time\u0027: \u00271\u0027"},{"line_number":573,"context_line":"        }"},{"line_number":574,"context_line":"        self.create_simple_middleware(conf\u003dconf)"},{"line_number":575,"context_line":"        self.assertLastPath(None)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c6e82716","line":573,"range":{"start_line":571,"start_character":0,"end_line":573,"end_character":9},"updated":"2018-10-29 14:07:39.000000000","message":"This needs to be removed, since we\u0027re removing that conf option.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d30edbb976036813a88b57c0a0f32196c8cf1b4b","unresolved":false,"context_lines":[{"line_number":568,"context_line":"    \"\"\"These tests are run once using v2 tokens and again using v3 tokens.\"\"\""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_init_does_not_call_http(self):"},{"line_number":571,"context_line":"        conf \u003d {"},{"line_number":572,"context_line":"            \u0027revocation_cache_time\u0027: \u00271\u0027"},{"line_number":573,"context_line":"        }"},{"line_number":574,"context_line":"        self.create_simple_middleware(conf\u003dconf)"},{"line_number":575,"context_line":"        self.assertLastPath(None)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7ca682c1","line":573,"range":{"start_line":571,"start_character":0,"end_line":573,"end_character":9},"in_reply_to":"3f79a3b5_c6e82716","updated":"2018-10-29 15:47:06.000000000","message":"Fixed in followup","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"268f823f1c492c9146060c0a01b61c80c8b7526f","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"        self.assert_valid_request_200("},{"line_number":1626,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"    def test_fallback_to_online_validation_with_revocation_list_error(self):"},{"line_number":1629,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027signed_token_scoped\u0027])"},{"line_number":1630,"context_line":"        self.assert_valid_request_200("},{"line_number":1631,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_66eb5310","line":1628,"updated":"2018-10-29 14:07:39.000000000","message":"this whole test needs to go away, since it is predicated on the existence of revocation lists that we\u0027re removing.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d30edbb976036813a88b57c0a0f32196c8cf1b4b","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"        self.assert_valid_request_200("},{"line_number":1626,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"    def test_fallback_to_online_validation_with_revocation_list_error(self):"},{"line_number":1629,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027signed_token_scoped\u0027])"},{"line_number":1630,"context_line":"        self.assert_valid_request_200("},{"line_number":1631,"context_line":"            self.token_dict[\u0027signed_token_scoped_pkiz\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3c756a33","line":1628,"in_reply_to":"3f79a3b5_66eb5310","updated":"2018-10-29 15:47:06.000000000","message":"This is removed in the next patch in the chain.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"}],"releasenotes/notes/bug-1649735-3c68f3243e474775.yaml":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"cc45c97fff865d6ae587b2f58fca335c91e5a6fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_b2369e00","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":33},"updated":"2018-10-26 18:25:12.000000000","message":"duplicate... I think you mean `revocation_cache_time`","commit_id":"e98adaf987265ceda06200af2d416d7053a8ee1b"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d84379da0b11f8620d6d57062209a9d0c75b85b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_0db17745","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":33},"in_reply_to":"3f79a3b5_b2369e00","updated":"2018-10-26 18:31:05.000000000","message":"yes","commit_id":"e98adaf987265ceda06200af2d416d7053a8ee1b"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"268f823f1c492c9146060c0a01b61c80c8b7526f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_e6de8369","line":7,"updated":"2018-10-29 14:07:39.000000000","message":"you\u0027ve reintroduced the issue that you\u0027d fixed in PS2... one of these should be `revocation_cache_time`.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"b50754adaa31bc3101868d24fe7d8f28a13567f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_81c98453","line":7,"in_reply_to":"3f79a3b5_5231ffed","updated":"2018-10-31 17:06:09.000000000","message":"This was reintroduced 5 times locally because of the volume of branch changes etc that I needed. It was easier to just do the various nits in a full followup.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"68e7c543e871721b82629644c8e000d6c3638bdb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_5231ffed","line":7,"in_reply_to":"3f79a3b5_9c8b5e15","updated":"2018-10-31 14:30:41.000000000","message":"rebase would only reintroduce this if you don\u0027t rebase correctly...","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d30edbb976036813a88b57c0a0f32196c8cf1b4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [`bug 1649735 \u003chttps://bugs.launchpad.net/keystone/+bug/1649735\u003e`_]"},{"line_number":5,"context_line":"    The auth_token middleware no longer attempts to retrieve the revocation"},{"line_number":6,"context_line":"    list from the Keystone server. The deprecated options"},{"line_number":7,"context_line":"    `check_revocations_for_cached` and `check_revocations_for_cached` have been"},{"line_number":8,"context_line":"    removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_9c8b5e15","line":7,"in_reply_to":"3f79a3b5_e6de8369","updated":"2018-10-29 15:47:06.000000000","message":"Fixed in followup to avoid rebase re-introducing this again.","commit_id":"546793f64c27e5b4688d9633d91ac1265907ffaf"}]}