)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"78c33c959cc92fd7209811cd56a9103e051b6f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"171a4881_98e81958","updated":"2022-05-06 15:54:34.000000000","message":"It would be nice to add some tests to ensure the right caching implementation is being used based on configs.","commit_id":"ae563035817854e22e26acbf23a842d1dc57f99b"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"dd4214e245649d6f166f22b64375ab771b8da982","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e6516b04_6839ebce","in_reply_to":"171a4881_98e81958","updated":"2022-08-04 02:51:23.000000000","message":"This is only a conditional judgment, and I think it\u0027s no nuch need to tests for the caching implementation.","commit_id":"ae563035817854e22e26acbf23a842d1dc57f99b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"6e62eadd5fc2cafd54b95ac4c0b2755a6f141753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"abe0ea12_29575b2a","updated":"2025-01-27 13:38:19.000000000","message":"This looks good, however thinking about supporting it in future releases, we should make sure any replacement memcached client library that we would like to consider in the future (to support TLS and mTLS) will also still support SASL.\n\nFor instance, pymemcached doesn\u0027t implement the binary protocol which is a pre-requisite [1], it also looks like the binary protocol is deprecated in favor of the meta protocol [2].\n[1] https://github.com/pinterest/pymemcache/issues/54\n[2] https://docs.memcached.org/protocols/meta/\n\nThe best way forward might be to migrate the codebase to use oslo.cache, having the ability to select the used backend.","commit_id":"667950355129bb04c671c4ceda46d63a9a6b45b0"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"776bb33608ac3627e42d99aff38534a0114f6a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"29ff8da2_5bb26077","updated":"2025-01-27 08:07:23.000000000","message":"recheck","commit_id":"667950355129bb04c671c4ceda46d63a9a6b45b0"}],"doc/requirements.txt":[{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"fa4f5f6c67d28b0f22f72b628cf3ca83a24035fc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"WebTest\u003e\u003d2.0.27 # MIT"},{"line_number":22,"context_line":"oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Only required for sasl/binary protocol"},{"line_number":25,"context_line":"python-binary-memcached\u003e\u003d0.29.0 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"9f560f44_7cd55643","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":40},"updated":"2020-08-13 08:19:50.000000000","message":"This comment is not required, reason can live in the commit message. And please move the requirement to the appropriate place in alphabetical order.","commit_id":"d8dbbb62c227c308547a92a9b88efd365b983e35"}],"test-requirements.txt":[{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"fa4f5f6c67d28b0f22f72b628cf3ca83a24035fc","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Bandit security code scanner"},{"line_number":23,"context_line":"bandit!\u003d1.6.0,\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Only required for sasl/binary protocol"},{"line_number":26,"context_line":"python-binary-memcached\u003e\u003d0.29.0 # MIT"}],"source_content_type":"text/plain","patch_set":4,"id":"9f560f44_bccfeeae","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":40},"updated":"2020-08-13 08:19:50.000000000","message":"same here","commit_id":"d8dbbb62c227c308547a92a9b88efd365b983e35"}]}