)]}'
{"keystonemiddleware/auth_token/_cache.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7af1819c427d24d6ff95dc83198bf0bdd0ced9b6","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class _MemcacheClientPool(object):"},{"line_number":72,"context_line":"    \"\"\"An memcached client pool that is eventlet safe.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, memcache_servers, arguments, **kwargs):"},{"line_number":75,"context_line":"        # NOTE(sileht): This will import python-memcached, we don\u0027t want"}],"source_content_type":"text/x-python","patch_set":5,"id":"de48c7a9_0aa7a847","line":72,"range":{"start_line":72,"start_character":7,"end_line":72,"end_character":9},"updated":"2021-02-08 16:29:14.000000000","message":"A","commit_id":"9df3ff3e0f630762609b900212c0bd8a25daf8ae"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"240b681de90fe43bebd83463f0cefb294c7cbf2a","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class _MemcacheClientPool(object):"},{"line_number":72,"context_line":"    \"\"\"An memcached client pool that is eventlet safe.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, memcache_servers, arguments, **kwargs):"},{"line_number":75,"context_line":"        # NOTE(sileht): This will import python-memcached, we don\u0027t want"}],"source_content_type":"text/x-python","patch_set":5,"id":"51673d8d_b2e32533","line":72,"range":{"start_line":72,"start_character":7,"end_line":72,"end_character":9},"in_reply_to":"de48c7a9_0aa7a847","updated":"2021-02-19 11:36:35.000000000","message":"Done","commit_id":"9df3ff3e0f630762609b900212c0bd8a25daf8ae"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0e6475df365b7bc7cd6a7ec9c488aa1c27117333","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    \"\"\"An memcached client pool that is eventlet safe.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, memcache_servers, arguments, **kwargs):"},{"line_number":75,"context_line":"        # NOTE(sileht): This will import python-memcached, we don\u0027t want"},{"line_number":76,"context_line":"        # it as hard dependency, so lazy load it."},{"line_number":77,"context_line":"        from oslo_cache import _memcache_pool"},{"line_number":78,"context_line":"        self._pool \u003d _memcache_pool.MemcacheClientPool(memcache_servers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"41bd552e_81a18cf5","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":1},"updated":"2021-02-04 10:54:43.000000000","message":"Lazy loading is still necessary?","commit_id":"9df3ff3e0f630762609b900212c0bd8a25daf8ae"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"240b681de90fe43bebd83463f0cefb294c7cbf2a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \"\"\"An memcached client pool that is eventlet safe.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, memcache_servers, arguments, **kwargs):"},{"line_number":75,"context_line":"        # NOTE(sileht): This will import python-memcached, we don\u0027t want"},{"line_number":76,"context_line":"        # it as hard dependency, so lazy load it."},{"line_number":77,"context_line":"        from oslo_cache import _memcache_pool"},{"line_number":78,"context_line":"        self._pool \u003d _memcache_pool.MemcacheClientPool(memcache_servers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9c08f5_3cae298b","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":1},"in_reply_to":"2a84e4ca_46598571","updated":"2021-02-19 11:36:35.000000000","message":"Done","commit_id":"9df3ff3e0f630762609b900212c0bd8a25daf8ae"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"53cc4721a2dacfc7843b2765ec53261adf502a34","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    \"\"\"An memcached client pool that is eventlet safe.\"\"\""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __init__(self, memcache_servers, arguments, **kwargs):"},{"line_number":75,"context_line":"        # NOTE(sileht): This will import python-memcached, we don\u0027t want"},{"line_number":76,"context_line":"        # it as hard dependency, so lazy load it."},{"line_number":77,"context_line":"        from oslo_cache import _memcache_pool"},{"line_number":78,"context_line":"        self._pool \u003d _memcache_pool.MemcacheClientPool(memcache_servers,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2a84e4ca_46598571","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":1},"in_reply_to":"41bd552e_81a18cf5","updated":"2021-02-04 11:06:13.000000000","message":"Well, this comment belong to line below it.\nWhy ? Because in the end memcache is part of oslo.cache here :\n - https://github.com/openstack/oslo.cache/blob/master/oslo_cache/_memcache_pool.py\n\nBasically I didn\u0027t changed anything in MemcacheClientPool class, just remove conditional and set oslo.cache implementation by default.","commit_id":"9df3ff3e0f630762609b900212c0bd8a25daf8ae"}]}