)]}'
{"id":"openstack%2Fkeystonemiddleware~777553","triplet_id":"openstack%2Fkeystonemiddleware~stable%2Fvictoria~I0e96334b65a0bf369ebf1d88651d13feb8d2ecac","project":"openstack/keystonemiddleware","branch":"stable/victoria","topic":"bug/1883659-stable/victoria","hashtags":[],"change_id":"I0e96334b65a0bf369ebf1d88651d13feb8d2ecac","subject":"Switch to eventlet-safe oslo.cache\u0027s MemcacheClientPool","status":"ABANDONED","created":"2021-02-26 14:04:35.000000000","updated":"2021-04-11 07:42:44.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":773939,"cherry_pick_of_patch_set":8,"meta_rev_id":"a987743f915e71fbf9a8de78f9b48bd4cb084f95","_number":777553,"virtual_id_number":777553,"owner":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-02-26 17:20:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-26 15:42:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-23 15:57:43.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"CC"}],"messages":[{"id":"33bb24f8ef3d3ca065b9891983f7933686e5b717","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-02-26 14:04:35.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ae86cc3805f64e1d6967b3f74992903ee113543d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-26 15:42:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/220384133674452fb45be27f814b168c : SUCCESS in 3m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2ed44b1ac77843d78f19db8353b38a39 : FAILURE in 2m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cf5c0eb0ccc349c3a3996ddab7ebd6be : SUCCESS in 3m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ed48f29ce75044b29e5d74341b12d575 : SUCCESS in 3m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1f8cbe87aad24dd1af608c312ea911f0 : SUCCESS in 4m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/878047d780a441828bfacbd70fa3f5ca : SUCCESS in 5m 37s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/80ae47e4f670428aad0534b8ef06256e : SUCCESS in 1h 35m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a2bdd802eda4462f8aa809c675350bb0 : SUCCESS in 4m 03s","accounts_in_message":[],"_revision_number":1},{"id":"6b997cdb7b9aa676c9ea5a5fcfd80a8c33960b19","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-02-26 15:49:36.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"19ab8c2f9632a6e2219276b47ed40ba71f4dbd3c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-26 17:20:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0bdd3fb478da45c185fc0e32bbc2f721 : SUCCESS in 5m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4d40fbd6d95045ba8b15bce3834b470c : SUCCESS in 3m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/61f8df62b2954f84bcbc1adf4c047c42 : SUCCESS in 4m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/07cbcc5c8197469887d33ae9f7fdead9 : SUCCESS in 4m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70dedc8b140c471d8c6c28ae3befde24 : SUCCESS in 6m 11s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6b0901410c9e4ba5bd0552f311c1eb8f : SUCCESS in 1h 26m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ddf674a8c00842dfada82b5977dd664d : SUCCESS in 4m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/919d73ae310c42ed90f8e1b8b829af1e : FAILURE in 3m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"591bfa04da93ff0f1e3c585ead43781c104b450c","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-03-23 15:57:43.000000000","message":"Patch Set 2:\n\nPlease can you `cherry-pick -x` these changes to allow to retrieve the backports history.","accounts_in_message":[],"_revision_number":2},{"id":"204ebedd7dfc018ff25ad0d7bbc9f32ff9907d20","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-03-24 20:03:03.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e Please can you `cherry-pick -x` these changes to allow to retrieve the backports history.\n\nHi, for ussuri I was able to do it from master ..for victoria I\u0027m getting \n\nDo you really want to submit the above commits?\nType \u0027yes\u0027 to confirm, other to cancel: yes\nremote: \nremote: Processing changes: refs: 1\nremote: Processing changes: refs: 1, done            \nremote: commit 68e2de7: warning: subject \u003e50 characters; use shorter first paragraph        \nTo ssh://review.opendev.org:29418/openstack/keystonemiddleware.git\n ! [remote rejected] HEAD -\u003e refs/for/master%topic\u003dbug/1883659 (change https://review.opendev.org/c/openstack/keystonemiddleware/+/773991 closed)\nerror: failed to push some refs to \u0027ssh://review.opendev.org:29418/openstack/keystonemiddleware.git\u0027\n\nI\u0027ve already tried to shorten commit message..but didn\u0027t help.","accounts_in_message":[],"_revision_number":2},{"id":"da0f2ae659ae2b6b7069f35e4cebca17224fc9f6","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-04-08 12:27:39.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e Please can you `cherry-pick -x` these changes to allow to retrieve the backports history.\n\u003e \n\u003e Hi, for ussuri I was able to do it from master ..for victoria I\u0027m getting \n\u003e \n\u003e Do you really want to submit the above commits?\n\u003e Type \u0027yes\u0027 to confirm, other to cancel: yes\n\u003e remote: \n\u003e remote: Processing changes: refs: 1\n\u003e remote: Processing changes: refs: 1, done            \n\u003e remote: commit 68e2de7: warning: subject \u003e50 characters; use shorter first paragraph        \n\u003e To ssh://review.opendev.org:29418/openstack/keystonemiddleware.git\n\u003e  ! [remote rejected] HEAD -\u003e refs/for/master%topic\u003dbug/1883659 (change https://review.opendev.org/c/openstack/keystonemiddleware/+/773991 closed)\n\u003e error: failed to push some refs to \u0027ssh://review.opendev.org:29418/openstack/keystonemiddleware.git\u0027\n\u003e \n\u003e I\u0027ve already tried to shorten commit message..but didn\u0027t help.\n\nHm concerning the commit message it\u0027s just a warning, that\u0027s not the problem.\nYour problem here is that you refer to a closed review (https://review.opendev.org/c/openstack/keystonemiddleware/+/773991 (already merged)). \n\nSo either you inadvertently tried to push another commit or you used a wrong \"change-id\" here.","accounts_in_message":[],"_revision_number":2},{"id":"a987743f915e71fbf9a8de78f9b48bd4cb084f95","tag":"autogenerated:gerrit:abandon","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2021-04-11 07:42:44.000000000","message":"Abandoned\n\nabandon for victoria, wallaby is going to be released in few days","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c89cdba7c12761c8e876be9bfb99d477bb63d3d4","revisions":{"26fa38d34091942d3bd45976fbfb95e9e777938a":{"kind":"REWORK","_number":1,"created":"2021-02-26 14:04:35.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/53/777553/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/53/777553/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/1"}}},"commit":{"parents":[{"commit":"654d31a1bd32968bfa008a117a60b58e18d68df8","subject":"Merge \"Change the default Identity endpoint to internal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/654d31a1bd32968bfa008a117a60b58e18d68df8"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-02-10 13:47:17.000000000","tz":60},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-02-26 14:04:35.000000000","tz":0},"subject":"Switch to eventlet-safe oslo.cache\u0027s MemcacheClientPool","message":"Switch to eventlet-safe oslo.cache\u0027s MemcacheClientPool\n\nIn past days there were discussions about various issues\nwith memcached connections [1][2][3].\n\nAfter investigation it looks like common root cause for above\nproblems is keystonemiddleware. More precisely said the way\nhow keystonemiddleware is caching tokens.\n\nCurrently it\u0027s using some home-made CachePool with direct\nusage of memcached library, moreover it looks like its\napproach is not eventlet-safe.\nDiscussion can be mainly found in [4].\n\nFortunately keystonemiddleware can use \"advanced cache pool\",\nwhich is oslo.cache\u0027s implementation and was added long time ago [5],\nbut it is turned on only if memcache_use_advanced_pool\u003dTrue.\n\nThis patch is switching to more elaborated oslo.cache CachePool\nand adding deprecation warning about eventlet-unsafe variant\nof keystonemiddleware\u0027s memcache pool.\n\nHow to reproduce ?\n\nwith memcache_use_advanced_pool\u003dFalse\n\n1. Build clean ENV of openstack\n2. Deploy core projects (keystone,glance,nova,placement...)\n3. Run while true; do COMMAND FOR SERVICE; done\n   - several bashes, in parallel (5-7)\n\nCOMMAND FOR SERVICE:\n- openstack network list\n- openstack volume list\n- openstack server list\n- openstack image list\n\n4. Check memcached connections (which will grow up):\n    - ss | grep 11211 | wc -l   every second\n\nHow to fix and test it ?\n\nRepeat above, to fix:\n - with memcache_use_advanced_pool\u003dTrue\n   OR\n - apply this patch\n\nCompare measurements in graph.\n\n[1] https://bugs.launchpad.net/keystonemiddleware/+bug/1892852\n[2] https://bugs.launchpad.net/oslo.cache/+bug/1888394\n[3] https://bugs.launchpad.net/keystonemiddleware/+bug/1883659\n\n[4] https://review.opendev.org/c/openstack/oslo.cache/+/742193\n\n[5] https://review.opendev.org/c/openstack/keystonemiddleware/+/268664\n\nCloses-Bug: #1883659\nCloses-Bug: #1892852\nCloses-Bug: #1888394\n\nChange-Id: I0e96334b65a0bf369ebf1d88651d13feb8d2ecac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/26fa38d34091942d3bd45976fbfb95e9e777938a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/26fa38d34091942d3bd45976fbfb95e9e777938a"}]},"branch":"refs/heads/stable/victoria"},"c89cdba7c12761c8e876be9bfb99d477bb63d3d4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-02-26 15:49:36.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/53/777553/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/53/777553/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/53/777553/2"}}},"commit":{"parents":[{"commit":"5f91032ae5cb074e0e54cbcc2ddda8a58ebbb522","subject":"Updating lower-constraints job as non voting","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/5f91032ae5cb074e0e54cbcc2ddda8a58ebbb522"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-02-10 13:47:17.000000000","tz":60},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2021-02-26 15:49:36.000000000","tz":0},"subject":"Switch to eventlet-safe oslo.cache\u0027s MemcacheClientPool","message":"Switch to eventlet-safe oslo.cache\u0027s MemcacheClientPool\n\nIn past days there were discussions about various issues\nwith memcached connections [1][2][3].\n\nAfter investigation it looks like common root cause for above\nproblems is keystonemiddleware. More precisely said the way\nhow keystonemiddleware is caching tokens.\n\nCurrently it\u0027s using some home-made CachePool with direct\nusage of memcached library, moreover it looks like its\napproach is not eventlet-safe.\nDiscussion can be mainly found in [4].\n\nFortunately keystonemiddleware can use \"advanced cache pool\",\nwhich is oslo.cache\u0027s implementation and was added long time ago [5],\nbut it is turned on only if memcache_use_advanced_pool\u003dTrue.\n\nThis patch is switching to more elaborated oslo.cache CachePool\nand adding deprecation warning about eventlet-unsafe variant\nof keystonemiddleware\u0027s memcache pool.\n\nHow to reproduce ?\n\nwith memcache_use_advanced_pool\u003dFalse\n\n1. Build clean ENV of openstack\n2. Deploy core projects (keystone,glance,nova,placement...)\n3. Run while true; do COMMAND FOR SERVICE; done\n   - several bashes, in parallel (5-7)\n\nCOMMAND FOR SERVICE:\n- openstack network list\n- openstack volume list\n- openstack server list\n- openstack image list\n\n4. Check memcached connections (which will grow up):\n    - ss | grep 11211 | wc -l   every second\n\nHow to fix and test it ?\n\nRepeat above, to fix:\n - with memcache_use_advanced_pool\u003dTrue\n   OR\n - apply this patch\n\nCompare measurements in graph.\n\n[1] https://bugs.launchpad.net/keystonemiddleware/+bug/1892852\n[2] https://bugs.launchpad.net/oslo.cache/+bug/1888394\n[3] https://bugs.launchpad.net/keystonemiddleware/+bug/1883659\n\n[4] https://review.opendev.org/c/openstack/oslo.cache/+/742193\n\n[5] https://review.opendev.org/c/openstack/keystonemiddleware/+/268664\n\nCloses-Bug: #1883659\nCloses-Bug: #1892852\nCloses-Bug: #1888394\n\nChange-Id: I0e96334b65a0bf369ebf1d88651d13feb8d2ecac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/c89cdba7c12761c8e876be9bfb99d477bb63d3d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/c89cdba7c12761c8e876be9bfb99d477bb63d3d4"}]},"branch":"refs/heads/stable/victoria","description":"Rebase"}},"requirements":[],"submit_records":[],"submit_requirements":[]}