)]}'
{"id":"openstack%2Fkeystonemiddleware~878171","triplet_id":"openstack%2Fkeystonemiddleware~master~I71ce7d04d5708e766be718d1b316c007f6758fa2","project":"openstack/keystonemiddleware","branch":"master","topic":"877808-fixup","attention_set":{},"removed_from_attention_set":{"597":{"account":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"last_update":"2023-05-05 14:21:48.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I71ce7d04d5708e766be718d1b316c007f6758fa2","subject":"Use conf paramter instead of a global for s3_token","status":"ABANDONED","created":"2023-03-21 20:50:40.000000000","updated":"2023-05-05 14:21:48.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"08254896426a4924132566bdac0e394669cc1b97","_number":878171,"virtual_id_number":878171,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"tag":"autogenerated:zuul:check","value":1,"date":"2023-03-21 22:09:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"all":[{"value":1,"date":"2023-03-24 15:07:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-21 22:09:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-24 15:07:53.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2023-03-24 15:15:44.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"state":"CC"}],"messages":[{"id":"ef3a300c58c5b5132ae4e099d6cfcb3dd8d1912f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2023-03-21 20:50:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a21acea4012a662d9761445948c84fa079ab6f51","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2023-03-21 20:52:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ce8f1fb91589abb534a12d2a653d8a38583b771c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-21 22:09:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7091ea449eef48098caa4cd4dc558dfa\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d52414cda74f4940a79bcc8f63d0ee27 : SUCCESS in 3m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c7fb69eada2b4ba98b0f7fc46fdbec7f : SUCCESS in 3m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fc3ae4609c914aeb954f987c54ffc870 : SUCCESS in 3m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3fc3e69c39904c7c94efe403b6c586a6 : SUCCESS in 3m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3eb7d49aa7bb4418907d6c71fb913c2a : SUCCESS in 3m 31s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dcbf4bbb7a484b9fbe57a6cae165ceb5 : SUCCESS in 5m 54s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ad6364b1cc7a48458c41002283e7705a : SUCCESS in 1h 05m 29s","accounts_in_message":[],"_revision_number":2},{"id":"c19bc050ab0436d5b57af6119990e7629cacfc00","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2023-03-24 15:07:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"18d08b80b90ec6addc1de643e8b531c0d40a698f","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2023-03-24 15:15:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"08254896426a4924132566bdac0e394669cc1b97","tag":"autogenerated:gerrit:abandon","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2023-05-05 14:21:48.000000000","message":"Abandoned\n\nWe\u0027re going to deprecate the whole s3_token anyway.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1f0b7d1f17115085bb1a180e11eec8396ab922e6","revisions":{"28a5230b7a636d9a7bd58c2088190b61e15e5256":{"kind":"REWORK","_number":1,"created":"2023-03-21 20:50:40.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/71/878171/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/71/878171/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/1"}}},"commit":{"parents":[{"commit":"92cdf8a0a5df0a7862eaa950060794a43b8ad4ec","subject":"Add timeout for requests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/92cdf8a0a5df0a7862eaa950060794a43b8ad4ec"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-03-21 20:45:25.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-03-21 20:50:11.000000000","tz":-300},"subject":"Use conf paramter instead of a global for s3_token","message":"Use conf paramter instead of a global for s3_token\n\nThe keystonemiddleware is used in Swift, which does not\nhave oslo_confg. You can load the module, but the parameters\nwill never get set to anything.\n\nThis patch undoes the change[1] that introduced the use\nof oslo_config in s3_token. But we keep the same in ec2_token,\nbecause it works there and for the purpose of documenting it.\n\n[1] I0c022c3cc57f30530ebdef6e434753ece2bdf912\n\nChange-Id: I71ce7d04d5708e766be718d1b316c007f6758fa2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/28a5230b7a636d9a7bd58c2088190b61e15e5256"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/28a5230b7a636d9a7bd58c2088190b61e15e5256"}]},"branch":"refs/heads/master"},"1f0b7d1f17115085bb1a180e11eec8396ab922e6":{"kind":"REWORK","_number":2,"created":"2023-03-21 20:52:41.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/71/878171/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystonemiddleware","ref":"refs/changes/71/878171/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystonemiddleware refs/changes/71/878171/2"}}},"commit":{"parents":[{"commit":"92cdf8a0a5df0a7862eaa950060794a43b8ad4ec","subject":"Add timeout for requests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/92cdf8a0a5df0a7862eaa950060794a43b8ad4ec"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-03-21 20:45:25.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2023-03-21 20:52:34.000000000","tz":-300},"subject":"Use conf paramter instead of a global for s3_token","message":"Use conf paramter instead of a global for s3_token\n\nThe keystonemiddleware is used in Swift, which does not\nhave oslo_confg. You can load the module, but the parameters\nwill never get set to anything.\n\nThis patch undoes the change[1] that introduced the use\nof oslo_config in s3_token. But we keep the same in ec2_token,\nbecause it works there and for the purpose of documenting it.\n\n[1] I0c022c3cc57f30530ebdef6e434753ece2bdf912\n\nChange-Id: I71ce7d04d5708e766be718d1b316c007f6758fa2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/1f0b7d1f17115085bb1a180e11eec8396ab922e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystonemiddleware/commit/1f0b7d1f17115085bb1a180e11eec8396ab922e6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}