)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c9a9c786eae0f79f2b5d1d2b6e5b93435caadbbc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b8f3752_ec9a593a","updated":"2025-11-16 13:14:44.000000000","message":"Hmm I see cryptography is imported only when encryption for memcached is enabled, then I\u0027m wondering if it should be in extra dependencies instead of hard dependencies ?","commit_id":"017c2f5cfbbf22c50859516bf655afdd44191a33"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a9f0b914551c0eb292a5906722168e5b730a45e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b7168d0_cf9cdbdf","updated":"2025-11-16 13:13:10.000000000","message":"Probably this should have been done when https://review.opendev.org/c/openstack/keystonemiddleware/+/451941 was merged","commit_id":"017c2f5cfbbf22c50859516bf655afdd44191a33"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"594279429d9e02459063dad50018df6b4e3265dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7cd76696_f54a9a65","in_reply_to":"1b8f3752_ec9a593a","updated":"2025-11-17 02:50:15.000000000","message":"See https://opendev.org/openstack/keystonemiddleware/src/commit/310b25afd09a52c8cd043d370ce9e5515caba29b/keystonemiddleware/auth_token/_memcache_crypt.py#L39-L46 , which makes the library optional unless encryption is requested.","commit_id":"017c2f5cfbbf22c50859516bf655afdd44191a33"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b5c65c36e2ed545e08d0bcde76f9172522d7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0d2e286_2834f643","in_reply_to":"410da59a_d2f73f08","updated":"2025-11-24 09:04:55.000000000","message":"Done","commit_id":"017c2f5cfbbf22c50859516bf655afdd44191a33"},{"author":{"_account_id":37432,"name":"Koya Watanabe","display_name":"Koya Watanabe","email":"koywatan@lycorp.co.jp","username":"koya-watanabe"},"change_message_id":"eb41c8f99211d35c0ea0c95374b9ea249a2d1812","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"410da59a_d2f73f08","in_reply_to":"7cd76696_f54a9a65","updated":"2025-11-22 07:58:54.000000000","message":"@kajinamit@oss.nttdata.com\nI changed to explicitly state that the `cryptography` package is an optional dependency of `keystonemiddleware` package.\nHow does that sound?","commit_id":"017c2f5cfbbf22c50859516bf655afdd44191a33"},{"author":{"_account_id":37432,"name":"Koya Watanabe","display_name":"Koya Watanabe","email":"koywatan@lycorp.co.jp","username":"koya-watanabe"},"change_message_id":"503f962de68571cf1a30d2a9b641826931921e60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63ae17a8_f3538e5f","updated":"2025-11-23 23:51:20.000000000","message":"@masahito.muroi@linecorp.com fixed. thank you.","commit_id":"9f16c76a6029595cb38c04656f13db834de9a021"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10b5c65c36e2ed545e08d0bcde76f9172522d7de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1dafa7cb_ed38ae3f","updated":"2025-11-24 09:04:55.000000000","message":"LGTM. Thanks","commit_id":"9f16c76a6029595cb38c04656f13db834de9a021"}],"setup.cfg":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"07ebb5e908065eac5619a7583001bbd8a967a837","unresolved":true,"context_lines":[{"line_number":29,"context_line":"[extras]"},{"line_number":30,"context_line":"audit_notifications \u003d"},{"line_number":31,"context_line":"  oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":32,"context_line":"memcache_crypt \u003d"},{"line_number":33,"context_line":"  cryptography\u003e\u003d2.7 # BSD/Apache-2.0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"efe2bb3a_7073fb3c","line":32,"updated":"2025-11-23 14:43:24.000000000","message":"It\u0027s `memcache_encryption`, isn\u0027t it?\n\n\n```suggestion\nmemcache_encryption \u003d\n```","commit_id":"11e9c91f8440954ab93f697f0d10982ee716afe5"},{"author":{"_account_id":37432,"name":"Koya Watanabe","display_name":"Koya Watanabe","email":"koywatan@lycorp.co.jp","username":"koya-watanabe"},"change_message_id":"503f962de68571cf1a30d2a9b641826931921e60","unresolved":false,"context_lines":[{"line_number":29,"context_line":"[extras]"},{"line_number":30,"context_line":"audit_notifications \u003d"},{"line_number":31,"context_line":"  oslo.messaging\u003e\u003d5.29.0 # Apache-2.0"},{"line_number":32,"context_line":"memcache_crypt \u003d"},{"line_number":33,"context_line":"  cryptography\u003e\u003d2.7 # BSD/Apache-2.0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[entry_points]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"574de52f_6fb0b22a","line":32,"in_reply_to":"efe2bb3a_7073fb3c","updated":"2025-11-23 23:51:20.000000000","message":"Done","commit_id":"11e9c91f8440954ab93f697f0d10982ee716afe5"}]}
