)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4abe5509_8917b0a5","updated":"2026-09-21 11:36:27.000000000","message":"This is a good idea, but I think we can split it up further to make it easier to review. Would you mind doing so? Feel free to ignore my patches above this one: I\u0027ll respin those myself","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00cf0a36bf3a0d2826f3cbf9078404cb8c967a69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"30b18aa4_19c2364f","updated":"2026-09-21 13:36:50.000000000","message":"Thanks, this is *much* easier to review now 🙏\n\nOne issue inline though","commit_id":"68eb1372b24b4650da062e71cda68eef75465876"}],"keystonemiddleware/auth_token/__init__.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":true,"context_lines":[{"line_number":840,"context_line":"                cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":841,"context_line":"                conf\u003dself._conf.oslo_conf_obj,"},{"line_number":842,"context_line":"            )"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        cache_kwargs \u003d dict("},{"line_number":845,"context_line":"            cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":846,"context_line":"            env_cache_name\u003dself._conf.get(\u0027cache\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"51f5ba6e_7f9cfa28","line":843,"updated":"2026-09-21 11:36:27.000000000","message":"As a follow-up, do we want to start logging a deprecation warning here so we can start the clock ticking for removal in a future SLURP release?","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00cf0a36bf3a0d2826f3cbf9078404cb8c967a69","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":841,"context_line":"                conf\u003dself._conf.oslo_conf_obj,"},{"line_number":842,"context_line":"            )"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        cache_kwargs \u003d dict("},{"line_number":845,"context_line":"            cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":846,"context_line":"            env_cache_name\u003dself._conf.get(\u0027cache\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"a79e1c37_70efd999","line":843,"in_reply_to":"5039eb71_ba7d53a6","updated":"2026-09-21 13:36:50.000000000","message":"Okay, let\u0027s kick this to touch for now.","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7ffc67d71377c920d5cf2877d1a971d239da8f85","unresolved":true,"context_lines":[{"line_number":840,"context_line":"                cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":841,"context_line":"                conf\u003dself._conf.oslo_conf_obj,"},{"line_number":842,"context_line":"            )"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        cache_kwargs \u003d dict("},{"line_number":845,"context_line":"            cache_time\u003dint(self._conf.get(\u0027token_cache_time\u0027)),"},{"line_number":846,"context_line":"            env_cache_name\u003dself._conf.get(\u0027cache\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"5039eb71_ba7d53a6","line":843,"in_reply_to":"51f5ba6e_7f9cfa28","updated":"2026-09-21 13:01:39.000000000","message":"That\u0027s probably an important point we should discuss.\n\nI think we definitely want to deprecate and remove advanced pool which heavily depends on oslo.cache, while I\u0027m unsure if we should remove the built-in memcache backend too at this stage.","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"}],"keystonemiddleware/auth_token/_cache.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7544c110fe80520e4b0db6a2938084ebf9e00b62","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            # unprotect_data will return None if raw_cached is None"},{"line_number":246,"context_line":"            return crypt.unprotect_data(context, data)"},{"line_number":247,"context_line":"        except memcache_crypt.InvalidMacError as e:"},{"line_number":248,"context_line":"            self._LOG.info(\"Unable to deserialize, %s\", e)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        # this should have the same effect as data not"}],"source_content_type":"text/x-python","patch_set":14,"id":"916a0718_915e475b","line":247,"updated":"2026-08-26 05:03:03.000000000","message":"pep8: F821 undefined name \u0027memcache_crypt\u0027","commit_id":"1bab4a6fae955dc7ba3d9c9b1a81c630d7dad873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            yield client"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TokenSerializer(object):"},{"line_number":129,"context_line":"    \"\"\"Serialize and deserialize cache data"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"3e836b15_bfc7ef8c","line":128,"updated":"2026-09-21 11:36:27.000000000","message":"nit: this would have been easier to review as a prelude change since IMO it stands by itself","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cbaa83ae680ed8dfb8618a0e661b15efe09013b5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            yield client"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class TokenSerializer(object):"},{"line_number":129,"context_line":"    \"\"\"Serialize and deserialize cache data"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"e76f0239_34625acd","line":128,"in_reply_to":"3e836b15_bfc7ef8c","updated":"2026-09-21 12:55:44.000000000","message":"I\u0027ve created a separate change to introduce serializers.","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"}],"keystonemiddleware/auth_token/_crypt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7cdf75a7_f8ba54a4","updated":"2026-09-21 11:36:27.000000000","message":"nit: I\u0027d probably have dragged this out to a separate prelude patch","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cbaa83ae680ed8dfb8618a0e661b15efe09013b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"32fd88e9_675c4a14","in_reply_to":"7cdf75a7_f8ba54a4","updated":"2026-09-21 12:55:44.000000000","message":"Done","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"}],"keystonemiddleware/auth_token/_opts.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":true,"context_lines":[{"line_number":79,"context_line":"               \u0027 tokens, the middleware caches previously-seen tokens for a\u0027"},{"line_number":80,"context_line":"               \u0027 configurable duration (in seconds). Set to -1 to disable\u0027"},{"line_number":81,"context_line":"               \u0027 caching completely.\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027cache_security_strategy\u0027,"},{"line_number":83,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":84,"context_line":"               choices\u003d((\u0027None\u0027,"},{"line_number":85,"context_line":"                         \u0027Token data is not authenticated or encrypted.\u0027),"},{"line_number":86,"context_line":"                        (\u0027MAC\u0027,"},{"line_number":87,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":88,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":89,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":90,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":91,"context_line":"               ignore_case\u003dTrue,"},{"line_number":92,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data\u0027"},{"line_number":93,"context_line":"               \u0027 should be authenticated or authenticated and encrypted.\u0027),"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027cache_secret_key\u0027,"},{"line_number":95,"context_line":"               secret\u003dTrue,"},{"line_number":96,"context_line":"               deprecated_name\u003d\u0027memcache_secret_key\u0027,"},{"line_number":97,"context_line":"               help\u003d\u0027(Optional, mandatory if cache_security_strategy is\u0027"},{"line_number":98,"context_line":"               \u0027 defined) This string is used for key derivation.\u0027),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027memcache_tls_enabled\u0027,"},{"line_number":100,"context_line":"                default\u003dFalse,"},{"line_number":101,"context_line":"                help\u003d\u0027(Optional) Global toggle for TLS usage when comunicating\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"c6e89226_184cf6ad","line":98,"range":{"start_line":82,"start_character":0,"end_line":98,"end_character":68},"updated":"2026-09-21 11:36:27.000000000","message":"nit: I\u0027d probably have dragged these out to a separate prelude patch also","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cbaa83ae680ed8dfb8618a0e661b15efe09013b5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               \u0027 tokens, the middleware caches previously-seen tokens for a\u0027"},{"line_number":80,"context_line":"               \u0027 configurable duration (in seconds). Set to -1 to disable\u0027"},{"line_number":81,"context_line":"               \u0027 caching completely.\u0027),"},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027cache_security_strategy\u0027,"},{"line_number":83,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":84,"context_line":"               choices\u003d((\u0027None\u0027,"},{"line_number":85,"context_line":"                         \u0027Token data is not authenticated or encrypted.\u0027),"},{"line_number":86,"context_line":"                        (\u0027MAC\u0027,"},{"line_number":87,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":88,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":89,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":90,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":91,"context_line":"               ignore_case\u003dTrue,"},{"line_number":92,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data\u0027"},{"line_number":93,"context_line":"               \u0027 should be authenticated or authenticated and encrypted.\u0027),"},{"line_number":94,"context_line":"    cfg.StrOpt(\u0027cache_secret_key\u0027,"},{"line_number":95,"context_line":"               secret\u003dTrue,"},{"line_number":96,"context_line":"               deprecated_name\u003d\u0027memcache_secret_key\u0027,"},{"line_number":97,"context_line":"               help\u003d\u0027(Optional, mandatory if cache_security_strategy is\u0027"},{"line_number":98,"context_line":"               \u0027 defined) This string is used for key derivation.\u0027),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027memcache_tls_enabled\u0027,"},{"line_number":100,"context_line":"                default\u003dFalse,"},{"line_number":101,"context_line":"                help\u003d\u0027(Optional) Global toggle for TLS usage when comunicating\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"b6dc71c4_3fd25595","line":98,"range":{"start_line":82,"start_character":0,"end_line":98,"end_character":68},"in_reply_to":"c6e89226_184cf6ad","updated":"2026-09-21 12:55:44.000000000","message":"Done","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"}],"keystonemiddleware/external_oauth2_token.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ef4e5c1ef082fb5651ab16d18aac9d112a3d54f","unresolved":true,"context_lines":[{"line_number":138,"context_line":"               help\u003d\u0027In order to prevent excessive effort spent validating \u0027"},{"line_number":139,"context_line":"                    \u0027tokens, the middleware caches previously-seen tokens \u0027"},{"line_number":140,"context_line":"                    \u0027for a configurable duration (in seconds). Set to -1 to \u0027"},{"line_number":141,"context_line":"                    \u0027disable caching completely.\u0027),"},{"line_number":142,"context_line":"    cfg.StrOpt(\u0027cache_security_strategy\u0027,"},{"line_number":143,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":144,"context_line":"               choices\u003d((\u0027None\u0027,"},{"line_number":145,"context_line":"                         \u0027Token data is not authenticated or encrypted.\u0027),"},{"line_number":146,"context_line":"                        (\u0027MAC\u0027,"},{"line_number":147,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":148,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":149,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":150,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":151,"context_line":"               ignore_case\u003dTrue,"},{"line_number":152,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data \u0027"},{"line_number":153,"context_line":"                    \u0027should be authenticated or authenticated and encrypted.\u0027),"},{"line_number":154,"context_line":"    cfg.StrOpt(\u0027cache_secret_key\u0027,"},{"line_number":155,"context_line":"               secret\u003dTrue,"},{"line_number":156,"context_line":"               deprecated_name\u003d\u0027memcache_secret_key\u0027,"},{"line_number":157,"context_line":"               help\u003d\u0027(Optional, mandatory if cache_security_strategy is \u0027"},{"line_number":158,"context_line":"                    \u0027defined) This string is used for key derivation.\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027memcache_pool_dead_retry\u0027,"},{"line_number":160,"context_line":"               default\u003d5 * 60,"},{"line_number":161,"context_line":"               help\u003d\u0027(Optional) Number of seconds memcached server is \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1c92bc3d_1758f664","line":158,"range":{"start_line":141,"start_character":51,"end_line":158,"end_character":72},"updated":"2026-09-21 11:36:27.000000000","message":"These too","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cbaa83ae680ed8dfb8618a0e661b15efe09013b5","unresolved":false,"context_lines":[{"line_number":138,"context_line":"               help\u003d\u0027In order to prevent excessive effort spent validating \u0027"},{"line_number":139,"context_line":"                    \u0027tokens, the middleware caches previously-seen tokens \u0027"},{"line_number":140,"context_line":"                    \u0027for a configurable duration (in seconds). Set to -1 to \u0027"},{"line_number":141,"context_line":"                    \u0027disable caching completely.\u0027),"},{"line_number":142,"context_line":"    cfg.StrOpt(\u0027cache_security_strategy\u0027,"},{"line_number":143,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":144,"context_line":"               choices\u003d((\u0027None\u0027,"},{"line_number":145,"context_line":"                         \u0027Token data is not authenticated or encrypted.\u0027),"},{"line_number":146,"context_line":"                        (\u0027MAC\u0027,"},{"line_number":147,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":148,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":149,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":150,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":151,"context_line":"               ignore_case\u003dTrue,"},{"line_number":152,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data \u0027"},{"line_number":153,"context_line":"                    \u0027should be authenticated or authenticated and encrypted.\u0027),"},{"line_number":154,"context_line":"    cfg.StrOpt(\u0027cache_secret_key\u0027,"},{"line_number":155,"context_line":"               secret\u003dTrue,"},{"line_number":156,"context_line":"               deprecated_name\u003d\u0027memcache_secret_key\u0027,"},{"line_number":157,"context_line":"               help\u003d\u0027(Optional, mandatory if cache_security_strategy is \u0027"},{"line_number":158,"context_line":"                    \u0027defined) This string is used for key derivation.\u0027),"},{"line_number":159,"context_line":"    cfg.IntOpt(\u0027memcache_pool_dead_retry\u0027,"},{"line_number":160,"context_line":"               default\u003d5 * 60,"},{"line_number":161,"context_line":"               help\u003d\u0027(Optional) Number of seconds memcached server is \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"fbd8612a_847dbfaa","line":158,"range":{"start_line":141,"start_character":51,"end_line":158,"end_character":72},"in_reply_to":"1c92bc3d_1758f664","updated":"2026-09-21 12:55:44.000000000","message":"Done","commit_id":"7f2ff8696e3f58415f914566be63698138ac343b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00cf0a36bf3a0d2826f3cbf9078404cb8c967a69","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":148,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":149,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":150,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":151,"context_line":"               ignore_case\u003dTrue,"},{"line_number":152,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":153,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"4de47a3b_804dcd28","line":150,"updated":"2026-09-21 13:36:50.000000000","message":"duplicate","commit_id":"68eb1372b24b4650da062e71cda68eef75465876"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8119bb9df2efca5f08ba08e6619661061cfa7d07","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                         \u0027Token data is authenticated (with HMAC).\u0027),"},{"line_number":148,"context_line":"                        (\u0027ENCRYPT\u0027,"},{"line_number":149,"context_line":"                         \u0027Token data is encrypted and authenticated.\u0027)),"},{"line_number":150,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":151,"context_line":"               ignore_case\u003dTrue,"},{"line_number":152,"context_line":"               deprecated_name\u003d\u0027memcache_security_strategy\u0027,"},{"line_number":153,"context_line":"               help\u003d\u0027(Optional) If defined, indicate whether token data \u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"1686b995_28c86d99","line":150,"in_reply_to":"4de47a3b_804dcd28","updated":"2026-09-21 14:16:39.000000000","message":"This wasn\u0027t caught during rebase ...","commit_id":"68eb1372b24b4650da062e71cda68eef75465876"}],"keystonemiddleware/tests/unit/test_external_oauth2_token_middleware.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"650b581460fabfec338fbf3c7cc1b23d3edc3a4e","unresolved":false,"context_lines":[{"line_number":2014,"context_line":"                              _cache.TokenSerializer)"},{"line_number":2015,"context_line":""},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def test_token_cache_factory_oslo_secure(self):"},{"line_number":2018,"context_line":"        conf \u003d copy.deepcopy(self._test_conf)"},{"line_number":2019,"context_line":"        conf[\"use_oslo_cache\"] \u003d True"},{"line_number":2020,"context_line":"        conf[\"cache_secret_key\"] \u003d \"test_key\""}],"source_content_type":"text/x-python","patch_set":20,"id":"bd872d5a_18d665cb","line":2017,"updated":"2026-09-21 15:58:45.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"092f623d01188eca9e6b7beff94d165a1a0eed02"}]}