)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1a76ee5aab700d71a8ec0c70b9132f5e8b789dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29e5aa9b_3fe9aa72","updated":"2026-09-21 21:33:03.000000000","message":"I think pre-commit is not the right tool for mypy since we need all dependencies of the package to be installed (including test dependencies). Let\u0027s do this with `tox`","commit_id":"dfd83766f7d2e06cfc4dbaa9b00d4d70eb4989ba"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c53d45f7b77a653b025f243cdced24d08aee3c3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"59552767_18bbfd40","in_reply_to":"155f065b_f17a2b48","updated":"2026-10-06 08:42:12.000000000","message":"I\u0027m the biggest fan on pre-commit, but there are few issues with using it for this.\n\n1. You can\u0027t enable stricter typing (which should be the goal for a library like this) unless you install all dependencies. This means you end up duplicating the requirements files / the `dependencies` section of `pyproject.toml` in multiple places\n2. pre-commit caches dependencies, so if you fix a typing bug in a dependency you have to ask people to clean their pre-commit cache. This bit us regularly when we were rapidly adding hints to projects.\n3. `mypy` itself is slow (much slower that `ruff`) and it slows down the pre-commit hook.\n\nAs a result of these issues, we\u0027ve switched to using tox for all mypy invocations (included via the pep8 target). Yes, you lose the ability to catch things with pre-commit but it\u0027s an acceptable cost to address the above and a `tox -e mypy` run is \"fast enough\" to run when you\u0027ve added a large amount of code. I also have mypy enabled in Vim (via ALE) so I catch most issues as I\u0027m editing.","commit_id":"dfd83766f7d2e06cfc4dbaa9b00d4d70eb4989ba"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"b3ed5fd92c5169184fc5055b14bac5adc88f4a5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"155f065b_f17a2b48","in_reply_to":"29e5aa9b_3fe9aa72","updated":"2026-10-05 16:52:50.000000000","message":"keystone, codegenerator run mypy in pre-commit since quite a while without issues saving CI time (saved me multiple times already)","commit_id":"dfd83766f7d2e06cfc4dbaa9b00d4d70eb4989ba"}]}