)]}'
{"id":"openstack%2Fkeystone~1001573","triplet_id":"openstack%2Fkeystone~master~Ibada8b4977d285dfafff9ac13ec7c7195c8b5d6d","project":"openstack/keystone","branch":"master","topic":"secure-rbac","attention_set":{"38589":{"account":{"_account_id":38589,"name":"Moutaz Chaara","display_name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","username":"tz3","status":"SAP SE"},"last_update":"2026-08-19 22:42:46.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ibada8b4977d285dfafff9ac13ec7c7195c8b5d6d","subject":"Fix project-admin bypass in GET /v3/limits","status":"NEW","created":"2026-08-19 21:02:28.000000000","updated":"2026-08-19 22:42:46.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"782ce4a5b9dd80cc3f319ebde383bbcad1e05f85","_number":1001573,"virtual_id_number":1001573,"owner":{"_account_id":38589,"name":"Moutaz Chaara","display_name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","username":"tz3","status":"SAP SE"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-08-19 22:42:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-19 21:39:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-08-19 22:42:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"81f285f8aaf8d6f0544bc9ce9b25d892d9117d93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":38589,"name":"Moutaz Chaara","display_name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","username":"tz3","status":"SAP SE"},"date":"2026-08-19 21:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e0bd325dd6e160e2d7b2fdfc66d258e1f9f17c96","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 21:39:38.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cc6e26c945094385bdde0d44c8e4ba47\n\n- openstack-tox-py311-arm64 https://zuul.opendev.org/t/openstack/build/56d74b0304f8459eb5338904b273a202 : SUCCESS in 23m 26s (non-voting)\n- openstack-tox-py313-arm64 https://zuul.opendev.org/t/openstack/build/76aaeded3dcd43fea87b19e7baf574d7 : SUCCESS in 23m 05s (non-voting)\n- openstack-tox-py314-arm64 https://zuul.opendev.org/t/openstack/build/e7b89160315d44cbb1692bc1b87f064c : SUCCESS in 33m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"782ce4a5b9dd80cc3f319ebde383bbcad1e05f85","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-19 22:42:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/bb92dbb131434f83bb39919ba70153cf\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8b25030bc65a47d48df839368327d4a7 : SUCCESS in 14m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5947275be24b4e2c917d34bbc47fc8e0 : SUCCESS in 4m 18s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/dee80c23a8114b1fac3c19e5661d1734 : SUCCESS in 8m 33s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/b2f9b7d5b78e43628247a80b700399b1 : SUCCESS in 8m 42s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/0b7927b5991e43a181c30e7c0eb31cbc : SUCCESS in 11m 19s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/839ceb98cc334aa5b1b5684337581a14 : SUCCESS in 14m 27s\n- grenade https://zuul.opendev.org/t/openstack/build/4cba28448af54f29ad206e61635e2477 : SUCCESS in 37m 10s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cf5bb6a8ad8a453f9b81db85237fae85 : SUCCESS in 1h 34m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cf807dd0a8b2490c9784cea9788c0dd2 : SUCCESS in 12m 41s\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/296d625bf55349caa9e9ca3fc04ffd23 : SUCCESS in 13m 50s (non-voting)\n- keystone-tempest https://zuul.opendev.org/t/openstack/build/5951a81ca81f41ebafec9282f86f1228 : FAILURE in 27m 38s\n- keystone-tempest-fips https://zuul.opendev.org/t/openstack/build/c5c5cdc3f9f34aeab145827aeebb6df3 : FAILURE in 14m 41s (non-voting)\n- keystone-tempest-federation https://zuul.opendev.org/t/openstack/build/15d69dbe16354f59bb5484de5999b9dc : FAILURE in 19m 40s (non-voting)\n- keystone-tempest-federation-k2k https://zuul.opendev.org/t/openstack/build/ab373a920f204a5da46c4fa5c5b41d06 : FAILURE in 49m 04s\n- keystone-tempest-oidc-federation https://zuul.opendev.org/t/openstack/build/be71faaf220d46528540bfe4ca76c035 : FAILURE in 42m 22s\n- keystone-tempest-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/39818d3568b0441a95ec061c264df1d0 : SUCCESS in 29m 57s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/733e1531fafe4134aa674be99c9107c3 : SUCCESS in 56m 02s\n- keystone-protection-functional https://zuul.opendev.org/t/openstack/build/5e0985896ccf46459a24c436c4f2536a : FAILURE in 42m 26s\n- codegenerator-openapi-identity-tips-with-api-ref https://zuul.opendev.org/t/openstack/build/fa640031cf5e4dee9926127a742e43ba : SUCCESS in 4m 50s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job keystone-tempest-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job keystone-tempest-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"404bf7499dd6fb5259e6f63bb417849449df944a","revisions":{"404bf7499dd6fb5259e6f63bb417849449df944a":{"kind":"REWORK","_number":1,"created":"2026-08-19 21:02:28.000000000","uploader":{"_account_id":38589,"name":"Moutaz Chaara","display_name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","username":"tz3","status":"SAP SE"},"ref":"refs/changes/73/1001573/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/73/1001573/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/73/1001573/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/73/1001573/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/73/1001573/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/73/1001573/1"}}},"commit":{"parents":[{"commit":"16afc813b7e6de727d8a91e065d7824b06e32925","subject":"Merge \"Abandon server-side paged search cursor when sizelimit is reached\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/16afc813b7e6de727d8a91e065d7824b06e32925"}]}],"author":{"name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","date":"2026-08-19 16:27:24.000000000","tz":120},"committer":{"name":"Moutaz Chaara","email":"moutaz.chaara@sap.com","date":"2026-08-19 21:02:09.000000000","tz":120},"subject":"Fix project-admin bypass in GET /v3/limits","message":"Fix project-admin bypass in GET /v3/limits\n\nCommit 8a42793e7 (I8f59c59b) introduced a superuser block in the\nlist_limits handler that granted unfiltered access to any token\ncarrying role:admin or role:service, regardless of scope:\n\n    superuser \u003d (\n        self.oslo_context.system_scope\n        or (\u0027admin\u0027 in self.oslo_context.roles)\n        or (\u0027service\u0027 in self.oslo_context.roles)\n    )\n\nA project-scoped token with role:admin therefore sees limits from\nevery project and domain in the deployment — a privilege that should\nbelong only to system-scoped tokens.\n\nRestore the original pre-commit shape: bypass the scope filter only\nfor system-scoped tokens and service tokens (role:service). Remove\nthe bare \u0027admin\u0027 in roles check entirely.\n\nCloses-Bug: #2161508\nChange-Id: Ibada8b4977d285dfafff9ac13ec7c7195c8b5d6d\nSigned-off-by: Moutaz Chaara \u003cmoutaz.chaara@sap.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/404bf7499dd6fb5259e6f63bb417849449df944a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/404bf7499dd6fb5259e6f63bb417849449df944a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}