)]}'
{"id":"openstack%2Fkeystone~1002335","triplet_id":"openstack%2Fkeystone~stable%2F2025.1~I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33","project":"openstack/keystone","branch":"stable/2025.1","attention_set":{"14250":{"account":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"last_update":"2026-08-25 17:29:14.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33","subject":"credentials: reject delegated tokens, restrict PATCH to blob only","status":"NEW","created":"2026-08-25 15:57:31.000000000","updated":"2026-08-26 21:45:28.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1e44e343b4551911fd820f044af41d18e37e4f7f","_number":1002335,"virtual_id_number":1002335,"owner":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-08-26 21:45:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-25 15:58:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bf968eb1481d21e8a3ae8e0da597fafb98532306","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-08-25 15:57:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"efd9a339e173c58e294685165fc26bc56e875afe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-25 15:58:59.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.\nWarning:\n  Error merging gerrit/openstack/keystone for 1002308,1","accounts_in_message":[],"_revision_number":1},{"id":"55c14d3bdfbf7df37d13671045bf3cd4cc32b69d","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-08-25 16:00:12.000000000","message":"Patch Set 1:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"cde9e3af5b73a96df4bbf0b60dc891e91121c10f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-08-25 16:17:55.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b7d2058007f194a0ba1a9e27751f06185a232a22","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-25 17:29:14.000000000","message":"Patch Set 2: Verified-1\n\n(4 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/9c80726d8c61444c952471a36f2053fe\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8311137620df401b98eb94dcd539f2c2 : FAILURE in 15m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c7433a08ce4a4decb4ae94e96c4765d4 : FAILURE in 7m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9fa7e0e74028435ead7105b0ad32cb47 : FAILURE in 13m 16s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/95bbe93f9f3340198d3875d2b74e0ed7 : FAILURE in 14m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0b5b7efd1d44485f9518f04d2819669c : SUCCESS in 16m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b49e39b01e7d42da828cccd51a0076a6 : SUCCESS in 15m 05s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/09c759e739474b15972dcea147598ade : FAILURE in 7m 48s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/2f9bc500e35c45049428d26e974bbc5e : FAILURE in 29m 49s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/4ead5c25d2ff415892ff1a29c98724bd : FAILURE in 31m 52s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/4e2d63d7f9254d6b802d86fd760c38db : SUCCESS in 21m 08s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/cc17234a7d7e438aac3529e3092b48f3 : FAILURE in 12m 33s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/364f8cfbdd8e40e88356ca2e511be0fe : SUCCESS in 30m 07s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ef2d26deca4f473f8e4acb4d6bc297fe : FAILURE in 9m 56s\n- grenade https://zuul.opendev.org/t/openstack/build/d7440b2fc2c24020a09e7ab098f9075e : FAILURE in 32m 59s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1426bf7987f4458286d95eac94ef9259 : FAILURE in 8m 34s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/c0d18e2091e74983ac8ed2b8566d29c0 : SUCCESS in 32m 38s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  Comments left for invalid file keystone/tests/unit/test_v3_auth.py\n  Comments left for invalid file keystone/tests/unit/test_v3_trust.py","accounts_in_message":[],"_revision_number":2},{"id":"f09400a5ad21a9c05e99fb8032901195135c83c1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"real_author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2026-08-26 07:12:48.000000000","message":"Patch Set 3: Patch Set 2 was rebased on behalf of \u003cGERRIT_ACCOUNT_14250\u003e\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"}],"_revision_number":3},{"id":"9feada45b581aecc500a1709bee0c7469e69c8b5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-26 09:00:23.000000000","message":"Patch Set 3: Verified-1\n\n(4 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/bad0873a98cc42ca855e546189be49b4\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b262b32b86ad441f8abbd87bd493ff00 : FAILURE in 17m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0c357af9654748e7a188dc113dee93f4 : FAILURE in 7m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/43ba414c5435461083d5282fda55f59d : FAILURE in 13m 06s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/09b81f394a6a4722916eef8412c8819a : FAILURE in 8m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b987737037cd43cb993ff0925b6b74ca : SUCCESS in 8m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7de62e0c4f7e4af3b1b208de0b1c9d47 : SUCCESS in 17m 39s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/7f90b146e2854a67bbfafcb5794378a1 : SUCCESS in 39m 40s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/6fe1dcf965ba4ec994fda05a7f826c19 : FAILURE in 25m 54s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/17f82a99cdcb4413b1d7bfba45e84543 : FAILURE in 32m 04s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/5613203606844076ab2ec4cbedc50e81 : SUCCESS in 32m 08s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/2197538de0fa49ebaca437f95797639e : FAILURE in 10m 49s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/59c1a3e5e9914fb291aebd8a86b466c4 : SUCCESS in 36m 09s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/071b3b4dfca544b39f0801f7a916a85c : SUCCESS in 1h 22m 52s\n- grenade https://zuul.opendev.org/t/openstack/build/c9daf9096a104b33b616c6c521b8d8d8 : FAILURE in 37m 55s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5acd78ed499e4ca0aa385e51d01d1c97 : SUCCESS in 49m 20s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/974345ca74f7441c93626eab04360efa : SUCCESS in 16m 13s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":3},{"id":"1c23f88e169904ca7231791640325efc0a3f7e72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"date":"2026-08-26 20:40:55.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"NEVER\")\n","accounts_in_message":[],"_revision_number":4},{"id":"1e44e343b4551911fd820f044af41d18e37e4f7f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-08-26 21:45:28.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fde582fc2bfb4d399e52a5212373f8dd\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/344af6f33e384441ae4c3226e114d634 : SUCCESS in 21m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c56cf004105249169e4a1b3576f5541a : SUCCESS in 3m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d044798b50ca4686b3518c2fb5c43b54 : SUCCESS in 13m 49s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b0f5def60ea04702bf7202be17d621f6 : SUCCESS in 7m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2258dc93fb94439db41a6defc0580c10 : SUCCESS in 13m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/208f73c5dbad42eda5b2f7eb9357c47d : SUCCESS in 14m 00s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/32e065d8f0e847daa63044d9709ab9ed : SUCCESS in 33m 37s\n- keystone-dsvm-py3-functional-fips https://zuul.opendev.org/t/openstack/build/e72fac22b18948ae8f18207babd30e55 : FAILURE in 15m 19s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy https://zuul.opendev.org/t/openstack/build/05139a03ec1849688740fce2f66b74e7 : FAILURE in 14m 13s (non-voting)\n- keystone-dsvm-py3-functional-federation-ubuntu-jammy-k2k https://zuul.opendev.org/t/openstack/build/2ebb2e75197b419e95a87bb51f5b39dc : SUCCESS in 28m 17s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/95d5e3363cc44113905869df7d60ed87 : FAILURE in 9m 03s (non-voting)\n- keystone-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/a5f305110e8f4a64a5ab042479c6b7d4 : SUCCESS in 38m 39s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/4e1a547227e3466fb34e53490572d917 : SUCCESS in 55m 13s\n- grenade https://zuul.opendev.org/t/openstack/build/dcca52f4e5f54f7fa765eca2258c9da5 : FAILURE in 54m 01s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9a13d9c48fe04332a1ef8a60bbb839c7 : SUCCESS in 30m 46s\n- keystone-dsvm-functional-oidc-federation https://zuul.opendev.org/t/openstack/build/069f684b947e418bae10a5738ded7a16 : SUCCESS in 15m 27s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job keystone-dsvm-py3-functional-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"bdeffd83fa51d2babc9a8df3f6ec7e4be0e469bf","revisions":{"0677812534027e929fa579459f1fabdde0694a77":{"kind":"REWORK","_number":1,"created":"2026-08-25 15:57:31.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/35/1002335/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/35/1002335/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/35/1002335/1"}}},"commit":{"parents":[{"commit":"82830ba1cee972bc8577772e930e2e78ea4bfc3c","subject":"auth: reject delegated tokens from token-method reauthentication","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/82830ba1cee972bc8577772e930e2e78ea4bfc3c"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-21 11:06:22.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-08-25 15:56:48.000000000","tz":120},"subject":"credentials: reject delegated tokens, restrict PATCH to blob only","message":"credentials: reject delegated tokens, restrict PATCH to blob only\n\nDelegated tokens (application_credential, OAuth1, trust, and\nec2credential) could read, create, modify, or delete credentials\nvia /v3/credentials and the OS-EC2 compat endpoint. The existing\nguards only compared project_id and never treated ec2credential\nas delegated.\n\nReplace those guards with a primary-auth-only gate: any token\nwhose methods aren\u0027t entirely primary auth methods, or that\ncarries a trust_id, is rejected from GET/POST/PATCH/DELETE on\nthose endpoints. This also removes trust/OAuth1 EC2 credential\ncreation, never a deliberate feature (bug 1242597 /\nOSSA-2013-032).\n\nPATCH now only accepts `blob`; `type`, `user_id`, and\n`project_id` are immutable after creation. Delete and recreate\nthe credential to change them.\n\nNarrow the existing, deprecated\nallow_insecure_admin_trust_cross_project_credentials_access\noption (LP#2150089) to ec2-type credentials only, matching its\ndocumented use case: an admin-role trust used to list/sync EC2\ncredentials.\n\nAn empty token.methods list is treated as delegated.\n\nUses keystone.api._shared.delegation from the LP#2153453 change.\n\nCloses-Bug: #2159643\nDepends-On: https://review.opendev.org/c/openstack/tempest/+/1002295\nDepends-On: https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1002296\nChange-Id: I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33\nAssisted-by: Cursor Grok 4.6 \u003cnoreply@cursor.com\u003e\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n(cherry picked from commit 3a1409e4d4ebe0232b72ba2ec52b66bb53ab3b81)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/0677812534027e929fa579459f1fabdde0694a77"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/0677812534027e929fa579459f1fabdde0694a77"}]},"branch":"refs/heads/stable/2025.1"},"9ac54130cced303e7b186d28336f3aff43e4b751":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-08-25 16:17:55.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/35/1002335/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/35/1002335/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/35/1002335/2"}}},"commit":{"parents":[{"commit":"645e01796946d5858fafb7cacbc12e6222166c8d","subject":"auth: reject delegated tokens from token-method reauthentication","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/645e01796946d5858fafb7cacbc12e6222166c8d"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-21 11:06:22.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-08-25 16:17:55.000000000","tz":0},"subject":"credentials: reject delegated tokens, restrict PATCH to blob only","message":"credentials: reject delegated tokens, restrict PATCH to blob only\n\nDelegated tokens (application_credential, OAuth1, trust, and\nec2credential) could read, create, modify, or delete credentials\nvia /v3/credentials and the OS-EC2 compat endpoint. The existing\nguards only compared project_id and never treated ec2credential\nas delegated.\n\nReplace those guards with a primary-auth-only gate: any token\nwhose methods aren\u0027t entirely primary auth methods, or that\ncarries a trust_id, is rejected from GET/POST/PATCH/DELETE on\nthose endpoints. This also removes trust/OAuth1 EC2 credential\ncreation, never a deliberate feature (bug 1242597 /\nOSSA-2013-032).\n\nPATCH now only accepts `blob`; `type`, `user_id`, and\n`project_id` are immutable after creation. Delete and recreate\nthe credential to change them.\n\nNarrow the existing, deprecated\nallow_insecure_admin_trust_cross_project_credentials_access\noption (LP#2150089) to ec2-type credentials only, matching its\ndocumented use case: an admin-role trust used to list/sync EC2\ncredentials.\n\nAn empty token.methods list is treated as delegated.\n\nUses keystone.api._shared.delegation from the LP#2153453 change.\n\nCloses-Bug: #2159643\nDepends-On: https://review.opendev.org/c/openstack/tempest/+/1002295\nDepends-On: https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1002296\nChange-Id: I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33\nAssisted-by: Cursor Grok 4.6 \u003cnoreply@cursor.com\u003e\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n(cherry picked from commit 3a1409e4d4ebe0232b72ba2ec52b66bb53ab3b81)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9ac54130cced303e7b186d28336f3aff43e4b751"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9ac54130cced303e7b186d28336f3aff43e4b751"}]},"branch":"refs/heads/stable/2025.1","description":"Rebase","conflicts":{"base":"82830ba1cee972bc8577772e930e2e78ea4bfc3c","ours":"0677812534027e929fa579459f1fabdde0694a77","theirs":"645e01796946d5858fafb7cacbc12e6222166c8d","merge_strategy":"recursive","contains_conflicts":false}},"937f295a0b1190f13ab5ab26419f8b34c3430138":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-08-26 07:12:48.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"real_uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/35/1002335/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/35/1002335/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/35/1002335/3"}}},"commit":{"parents":[{"commit":"f2761bb60a7e48510ab22c4865d9601345422ce9","subject":"auth: reject delegated tokens from token-method reauthentication","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f2761bb60a7e48510ab22c4865d9601345422ce9"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-21 11:06:22.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-08-26 07:12:48.000000000","tz":0},"subject":"credentials: reject delegated tokens, restrict PATCH to blob only","message":"credentials: reject delegated tokens, restrict PATCH to blob only\n\nDelegated tokens (application_credential, OAuth1, trust, and\nec2credential) could read, create, modify, or delete credentials\nvia /v3/credentials and the OS-EC2 compat endpoint. The existing\nguards only compared project_id and never treated ec2credential\nas delegated.\n\nReplace those guards with a primary-auth-only gate: any token\nwhose methods aren\u0027t entirely primary auth methods, or that\ncarries a trust_id, is rejected from GET/POST/PATCH/DELETE on\nthose endpoints. This also removes trust/OAuth1 EC2 credential\ncreation, never a deliberate feature (bug 1242597 /\nOSSA-2013-032).\n\nPATCH now only accepts `blob`; `type`, `user_id`, and\n`project_id` are immutable after creation. Delete and recreate\nthe credential to change them.\n\nNarrow the existing, deprecated\nallow_insecure_admin_trust_cross_project_credentials_access\noption (LP#2150089) to ec2-type credentials only, matching its\ndocumented use case: an admin-role trust used to list/sync EC2\ncredentials.\n\nAn empty token.methods list is treated as delegated.\n\nUses keystone.api._shared.delegation from the LP#2153453 change.\n\nCloses-Bug: #2159643\nDepends-On: https://review.opendev.org/c/openstack/tempest/+/1002295\nDepends-On: https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1002296\nChange-Id: I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33\nAssisted-by: Cursor Grok 4.6 \u003cnoreply@cursor.com\u003e\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n(cherry picked from commit 3a1409e4d4ebe0232b72ba2ec52b66bb53ab3b81)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/937f295a0b1190f13ab5ab26419f8b34c3430138"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/937f295a0b1190f13ab5ab26419f8b34c3430138"}]},"branch":"refs/heads/stable/2025.1","description":"Rebase","conflicts":{"base":"645e01796946d5858fafb7cacbc12e6222166c8d","ours":"9ac54130cced303e7b186d28336f3aff43e4b751","theirs":"f2761bb60a7e48510ab22c4865d9601345422ce9","merge_strategy":"recursive","contains_conflicts":false}},"bdeffd83fa51d2babc9a8df3f6ec7e4be0e469bf":{"kind":"REWORK","_number":4,"created":"2026-08-26 20:40:55.000000000","uploader":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"ref":"refs/changes/35/1002335/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/35/1002335/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/35/1002335/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/35/1002335/4"}}},"commit":{"parents":[{"commit":"f2761bb60a7e48510ab22c4865d9601345422ce9","subject":"auth: reject delegated tokens from token-method reauthentication","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f2761bb60a7e48510ab22c4865d9601345422ce9"}]}],"author":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-07-21 11:06:22.000000000","tz":120},"committer":{"name":"Grzegorz Grasza","email":"xek@redhat.com","date":"2026-08-26 20:40:52.000000000","tz":120},"subject":"credentials: reject delegated tokens, restrict PATCH to blob only","message":"credentials: reject delegated tokens, restrict PATCH to blob only\n\nDelegated tokens (application_credential, OAuth1, trust, and\nec2credential) could read, create, modify, or delete credentials\nvia /v3/credentials and the OS-EC2 compat endpoint. The existing\nguards only compared project_id and never treated ec2credential\nas delegated.\n\nReplace those guards with a primary-auth-only gate: any token\nwhose methods aren\u0027t entirely primary auth methods, or that\ncarries a trust_id, is rejected from GET/POST/PATCH/DELETE on\nthose endpoints. This also removes trust/OAuth1 EC2 credential\ncreation, never a deliberate feature (bug 1242597 /\nOSSA-2013-032).\n\nPATCH now only accepts `blob`; `type`, `user_id`, and\n`project_id` are immutable after creation. Delete and recreate\nthe credential to change them.\n\nNarrow the existing, deprecated\nallow_insecure_admin_trust_cross_project_credentials_access\noption (LP#2150089) to ec2-type credentials only, matching its\ndocumented use case: an admin-role trust used to list/sync EC2\ncredentials.\n\nAn empty token.methods list is treated as delegated.\n\nUses keystone.api._shared.delegation from the LP#2153453 change.\n\nCloses-Bug: #2159643\nDepends-On: https://review.opendev.org/c/openstack/tempest/+/1002295\nDepends-On: https://review.opendev.org/c/openstack/keystone-tempest-plugin/+/1002296\nChange-Id: I0d0c0e1a1d0728655e559fbe12ed3fd117d17d33\nAssisted-by: Cursor Grok 4.6 \u003cnoreply@cursor.com\u003e\nSigned-off-by: Grzegorz Grasza \u003cxek@redhat.com\u003e\n(cherry picked from commit 3a1409e4d4ebe0232b72ba2ec52b66bb53ab3b81)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/bdeffd83fa51d2babc9a8df3f6ec7e4be0e469bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/bdeffd83fa51d2babc9a8df3f6ec7e4be0e469bf"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
