)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3434aa6baa166d4154de369fd286ebf9b629554f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes the following flake8 issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"./keystone/trust/backends/kvs.py:102:13: F402 import \u0027trust\u0027 from line 23 shadowed by loop variable"},{"line_number":12,"context_line":"        for trust in self.db.get(\u0027trustee-%s\u0027 % trustee_user_id, []):"},{"line_number":13,"context_line":"            ^"},{"line_number":14,"context_line":"./keystone/trust/backends/kvs.py:108:13: F402 import \u0027trust\u0027 from line 23 shadowed by loop variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_58583357","line":11,"updated":"2014-06-18 06:51:24.000000000","message":"could you fix this commit message? it exceeded the 80 character limit","commit_id":"c8e6d633c4e6b78b43d32bbce2310f451199e327"},{"author":{"_account_id":7145,"name":"Christoph Gysin","email":"christoph.gysin@gmail.com","username":"chris"},"change_message_id":"6ea0c26a38d8ea94bb6156243dae309c8f869d76","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes the following flake8 issues:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"./keystone/trust/backends/kvs.py:102:13: F402 import \u0027trust\u0027 from line 23 shadowed by loop variable"},{"line_number":12,"context_line":"        for trust in self.db.get(\u0027trustee-%s\u0027 % trustee_user_id, []):"},{"line_number":13,"context_line":"            ^"},{"line_number":14,"context_line":"./keystone/trust/backends/kvs.py:108:13: F402 import \u0027trust\u0027 from line 23 shadowed by loop variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_f55745c8","line":11,"in_reply_to":"1ae5cdf2_58583357","updated":"2014-06-18 08:36:42.000000000","message":"These are straight from flake8, but I can wrap them after the filename and line number.","commit_id":"c8e6d633c4e6b78b43d32bbce2310f451199e327"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ad2dc741597af5983335b5743e45e3aacaa8f308","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christoph Gysin \u003cchristoph.gysin@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-18 16:44:06 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix flake8 issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes the following flake8 issues:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ae5cdf2_a012d0b1","line":7,"updated":"2014-06-18 14:30:46.000000000","message":"I\u0027d rather see a commit message more like: https://review.openstack.org/#/c/30478/\n\nI can tell from the code changes where the errors were.","commit_id":"2bf62455182afe9a5f957788bade895b63530eaf"}],"keystone/assignment/backends/ldap.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"73a06d14b4d62e1d22cfc987ff27daa2b03daf44","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        except ldap.NO_SUCH_OBJECT:"},{"line_number":575,"context_line":"            roles \u003d []"},{"line_number":576,"context_line":"        res \u003d []"},{"line_number":577,"context_line":"        for role_dn, __ in roles:"},{"line_number":578,"context_line":"            # ldap.dn.dn2str returns an array, where the first"},{"line_number":579,"context_line":"            # element is the first segment."},{"line_number":580,"context_line":"            # For a role assignment, this contains the role ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ff139762","line":577,"updated":"2014-06-18 13:37:08.000000000","message":"i\u0027d much prefer to see a leading underscore, but actually say what the variable is:\n\n  for role_dn, _something in roles:\n\nbut i have no idea what that something is","commit_id":"9ed79528d526dfcf54499997ab5070c38084ed4c"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"ad2dc741597af5983335b5743e45e3aacaa8f308","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            conn.unbind_s()"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        res \u003d []"},{"line_number":611,"context_line":"        for role_dn, __ in roles:"},{"line_number":612,"context_line":"            # ldap.dn.str2dn returns a list, where the first"},{"line_number":613,"context_line":"            # element is the first RDN."},{"line_number":614,"context_line":"            # For a role assignment, this contains the role ID,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b4ff7100","line":611,"updated":"2014-06-18 14:30:46.000000000","message":"Should this use the same convention as above instead of a double underscore?","commit_id":"2bf62455182afe9a5f957788bade895b63530eaf"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"73a06d14b4d62e1d22cfc987ff27daa2b03daf44","unresolved":false,"context_lines":[{"line_number":634,"context_line":"                user_id\u003duser_ref[\u0027id\u0027],"},{"line_number":635,"context_line":"                tenant_id\u003dproject_ref[\u0027id\u0027],"},{"line_number":636,"context_line":"                role_id\u003drole_ref[\u0027id\u0027])"},{"line_number":637,"context_line":"        del role_ref"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        role_list \u003d self.assignment_api.get_roles_for_user_and_project("},{"line_number":640,"context_line":"            user_id\u003duser_ref[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7ae07526","line":637,"updated":"2014-06-18 13:37:08.000000000","message":"because it won\u0027t be immediately obvious to future contributors why you need to delete the role_ref here, i\u0027d rather see this fixed by using a different variable name in the list comprehension below, like \n\n  self.assertEqual(set(role_list), set([r[\u0027id\u0027] for r in role_ref_list]))","commit_id":"9ed79528d526dfcf54499997ab5070c38084ed4c"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"e9e4f8e0701eca5108537f92594a0adfb836b430","unresolved":false,"context_lines":[{"line_number":640,"context_line":"            tenant_id\u003dproject_ref[\u0027id\u0027])"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"        self.assertEqual(set(role_list),"},{"line_number":643,"context_line":"                         set([r[\u0027id\u0027] for r in role_ref_list]))"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def test_get_role_by_user_and_project(self):"},{"line_number":646,"context_line":"        roles_ref \u003d self.assignment_api.get_roles_for_user_and_project("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_43b2ece5","line":643,"updated":"2014-06-18 18:05:38.000000000","message":"Easier for the tiring eyes if i instead of r.  \n\nEx.  set([i[\u0027id\u0027] for i in role_ref_list])","commit_id":"fcc29504b222e1b2777d1e2c230df1ae558ac54b"}],"keystone/tests/test_content_types.py":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"3434aa6baa166d4154de369fd286ebf9b629554f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"from testtools import matchers"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from keystone.common import extension as extn"},{"line_number":23,"context_line":"from keystone import config"},{"line_number":24,"context_line":"from keystone.tests import rest"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9800fb03","line":22,"updated":"2014-06-18 06:51:24.000000000","message":"I would still prefer a full name for this, instead of extn","commit_id":"c8e6d633c4e6b78b43d32bbce2310f451199e327"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7e2207b03445445ae02d9b862384811d1acf3cc6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"from testtools import matchers"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from keystone.common import extension as extn"},{"line_number":23,"context_line":"from keystone import config"},{"line_number":24,"context_line":"from keystone.tests import rest"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ab4c7e77","line":22,"in_reply_to":"1ae5cdf2_95a7e1a6","updated":"2014-06-18 09:40:05.000000000","message":"I don\u0027t see that as an issue. For instance, this is valid:\n\nself.assertValidExtensionListResponse(\n    r, keystone_extension.PUBLIC_EXTENSIONS)","commit_id":"c8e6d633c4e6b78b43d32bbce2310f451199e327"},{"author":{"_account_id":7145,"name":"Christoph Gysin","email":"christoph.gysin@gmail.com","username":"chris"},"change_message_id":"6ea0c26a38d8ea94bb6156243dae309c8f869d76","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"from testtools import matchers"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from keystone.common import extension as extn"},{"line_number":23,"context_line":"from keystone import config"},{"line_number":24,"context_line":"from keystone.tests import rest"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_95a7e1a6","line":22,"in_reply_to":"1ae5cdf2_9800fb03","updated":"2014-06-18 08:36:42.000000000","message":"What do you suggest? extension is already taken, and keystone_extension will cause some lines to become longer than 79 characters.","commit_id":"c8e6d633c4e6b78b43d32bbce2310f451199e327"}]}