)]}'
{"keystone/token/providers/common.py":[{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a1468ed7156b1e31df2421ea046dc99c933d961c","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            try:"},{"line_number":404,"context_line":"                self.token_api.get_token(token_id)"},{"line_number":405,"context_line":"            except exception.TokenNotFound:"},{"line_number":406,"context_line":"                six.reraise(exc_info)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return (token_id, token_data)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_103ba438","line":406,"updated":"2014-06-27 05:24:49.000000000","message":"Why do we even need to re raise since we are not doing anything with the exception.  Can\u0027t it just propagate?","commit_id":"c80c57732f01133775be75f6b3a06b46dc8ce5e0"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"2492abea31cacc9c4b15510641551b4d98dcc26f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            try:"},{"line_number":404,"context_line":"                self.token_api.get_token(token_id)"},{"line_number":405,"context_line":"            except exception.TokenNotFound:"},{"line_number":406,"context_line":"                six.reraise(exc_info)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        return (token_id, token_data)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a6bec1fd","line":406,"in_reply_to":"1ae5cdf2_103ba438","updated":"2014-07-01 19:56:02.000000000","message":"No. This line will raise the exception caught on line 399, not the one caught on 405.","commit_id":"c80c57732f01133775be75f6b3a06b46dc8ce5e0"},{"author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"change_message_id":"69b334b2df9db5da73cea1a07f02c66110b42ed2","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                self.token_api.get_token(token_id)"},{"line_number":374,"context_line":"            except exception.TokenNotFound:"},{"line_number":375,"context_line":"                six.reraise(exc_info)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_token_version(self, token_data):"},{"line_number":378,"context_line":"        if token_data and isinstance(token_data, dict):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_9f8f1b2e","line":375,"updated":"2014-07-17 14:59:13.000000000","message":"This should be `six.reraise(*exc_info)`.","commit_id":"0bdc8e177066a890e483f5fc21c686e401f767d9"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"066fd687d02637b03ff905d2b5b7bb26da7ff1e7","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                self.token_api.get_token(token_id)"},{"line_number":374,"context_line":"            except exception.TokenNotFound:"},{"line_number":375,"context_line":"                six.reraise(exc_info)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_token_version(self, token_data):"},{"line_number":378,"context_line":"        if token_data and isinstance(token_data, dict):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_025ac082","line":375,"in_reply_to":"baada198_02e9f219","updated":"2014-07-17 23:08:33.000000000","message":"Good catch.  What error would user see when the code goes down this path with exc_info and not *exc_info?  If user would in fact see an error, how did it escape testing? :)","commit_id":"0bdc8e177066a890e483f5fc21c686e401f767d9"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"07df3639827cf35c2b57307397ea693b9dfc327c","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                self.token_api.get_token(token_id)"},{"line_number":374,"context_line":"            except exception.TokenNotFound:"},{"line_number":375,"context_line":"                six.reraise(exc_info)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_token_version(self, token_data):"},{"line_number":378,"context_line":"        if token_data and isinstance(token_data, dict):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_02e9f219","line":375,"in_reply_to":"baada198_9f8f1b2e","updated":"2014-07-17 15:09:05.000000000","message":"Oops. Nice catch.","commit_id":"0bdc8e177066a890e483f5fc21c686e401f767d9"}]}