)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"020c282e6db711ed771b1d14a261a94a55602caf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change of ID being passed around is for supporting"},{"line_number":18,"context_line":"non-persistent tokens."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: configuration.rst updated to reflect the change in"},{"line_number":21,"context_line":"           configuration options for keystone cache layer."},{"line_number":22,"context_line":"bp: non-persistent-tokens"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_2f3c9fbe","line":19,"updated":"2014-06-27 22:28:05.000000000","message":"Maybe add SecurityImpact flag?","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bcba4f750e3b35c14a01e60d201a27e151cc311c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change of ID being passed around is for supporting"},{"line_number":18,"context_line":"non-persistent tokens."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DocImpact: configuration.rst updated to reflect the change in"},{"line_number":21,"context_line":"           configuration options for keystone cache layer."},{"line_number":22,"context_line":"bp: non-persistent-tokens"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab895d6_a2afc42a","line":19,"in_reply_to":"1ae5cdf2_2f3c9fbe","updated":"2014-06-29 04:31:19.000000000","message":"Doesn\u0027t really change security in any meaningful way here. Other changes will and will be marked as such","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"}],"etc/keystone.conf.sample":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"020c282e6db711ed771b1d14a261a94a55602caf","unresolved":false,"context_lines":[{"line_number":143,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":146,"context_line":"#qpid_hostname\u003dlocalhost"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"# Qpid broker port. (integer value)"},{"line_number":149,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_444ab2ad","line":146,"updated":"2014-06-27 22:28:05.000000000","message":"Are we purposely changing the hostname from \"keystone\" to \"localhost\" in the sample file?","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"020c282e6db711ed771b1d14a261a94a55602caf","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":202,"context_line":"# (string value)"},{"line_number":203,"context_line":"#rabbit_host\u003dlocalhost"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":206,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_442b9294","line":203,"updated":"2014-06-27 22:28:05.000000000","message":"Are we purposely changing the hostname from \"keystone\" to \"localhost\" in the sample file?","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bcba4f750e3b35c14a01e60d201a27e151cc311c","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":202,"context_line":"# (string value)"},{"line_number":203,"context_line":"#rabbit_host\u003dlocalhost"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":206,"context_line":"# (integer value)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"dab895d6_c2acb838","line":203,"in_reply_to":"1ae5cdf2_442b9294","updated":"2014-06-29 04:31:19.000000000","message":"This is generated automatically by the sample config generator. I make sure the venv is up to date and run the generator. \"localhost\" is probably more accurate than \"keystone\" as localhost would \"work\" and keystone might not. Same applies to all of these comments here.","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"020c282e6db711ed771b1d14a261a94a55602caf","unresolved":false,"context_lines":[{"line_number":820,"context_line":"#"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"# URL for connecting to the LDAP server. (string value)"},{"line_number":823,"context_line":"#url\u003dldap://localhost"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"# User BindDN to query the LDAP server. (string value)"},{"line_number":826,"context_line":"#user\u003d\u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_2407661e","line":823,"updated":"2014-06-27 22:28:05.000000000","message":"Are we purposely changing the hostname from \"keystone\" to \"localhost\" in the sample file?","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"020c282e6db711ed771b1d14a261a94a55602caf","unresolved":false,"context_lines":[{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"# SSL certificate subject (auto generated certificate)."},{"line_number":1290,"context_line":"# (string value)"},{"line_number":1291,"context_line":"#cert_subject\u003d/C\u003dUS/ST\u003dUnset/L\u003dUnset/O\u003dUnset/CN\u003dlocalhost"},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"[stats]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_4402b20c","line":1291,"updated":"2014-06-27 22:28:05.000000000","message":"Are we purposely changing the hostname from \"keystone\" to \"localhost\" in the sample file?","commit_id":"af3bd291f361503d0a9ba7978deea91d604a4e81"}],"keystone/common/cache/core.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"87b8eff43b5df1b9b8c4369e501c1722dc28e3e3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # mangler provided by dogpile.cache. This ensures we always use a fixed"},{"line_number":137,"context_line":"        # size cache-key."},{"line_number":138,"context_line":"        if region.key_mangler is None:"},{"line_number":139,"context_line":"            region.key_mangler \u003d util.sha1_mangle_key"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        for class_path in CONF.cache.proxies:"},{"line_number":142,"context_line":"            # NOTE(morganfainberg): if we have any proxy wrappers, we should"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab895d6_56d06553","line":139,"updated":"2014-06-30 02:15:15.000000000","message":"If a key mangler is not defined, we should log that no key_mangler is provided and we are using the default SHA-1 mangle key.","commit_id":"19e1db785d5774cbdddc2646e729eb0c327d214f"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c75029827b307084f0ae718f71f5931b1f165898","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # mangler provided by dogpile.cache. This ensures we always use a fixed"},{"line_number":137,"context_line":"        # size cache-key."},{"line_number":138,"context_line":"        if region.key_mangler is None:"},{"line_number":139,"context_line":"            region.key_mangler \u003d util.sha1_mangle_key"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        for class_path in CONF.cache.proxies:"},{"line_number":142,"context_line":"            # NOTE(morganfainberg): if we have any proxy wrappers, we should"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_11f989c8","line":139,"in_reply_to":"baada198_1f77d503","updated":"2014-07-01 04:09:46.000000000","message":"Agreed, if we are to log then region plus key_mangler would be useful.","commit_id":"19e1db785d5774cbdddc2646e729eb0c327d214f"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"b5e65f7ef8aa36827a3231c56357b4bef991d5f8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        # mangler provided by dogpile.cache. This ensures we always use a fixed"},{"line_number":137,"context_line":"        # size cache-key."},{"line_number":138,"context_line":"        if region.key_mangler is None:"},{"line_number":139,"context_line":"            region.key_mangler \u003d util.sha1_mangle_key"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        for class_path in CONF.cache.proxies:"},{"line_number":142,"context_line":"            # NOTE(morganfainberg): if we have any proxy wrappers, we should"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1f77d503","line":139,"in_reply_to":"dab895d6_56d06553","updated":"2014-07-01 03:33:33.000000000","message":"Why only log that no mangler is defined? If anything I think we could LOG.debug the region and the key_mangler.","commit_id":"19e1db785d5774cbdddc2646e729eb0c327d214f"}]}