)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"e59860674c5a09fd5e2117f1563eecb8f6903508","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-30 20:28:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix docs for pki_setup and ssl_setup references"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make sure we document that pki_setup and ssl_setup scripts are not"},{"line_number":10,"context_line":"intended for production deployments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_b9a44958","line":7,"updated":"2014-07-01 01:45:03.000000000","message":"Looks like we fix docs and scripts here. We should be explicit in the subject line.","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-30 20:28:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix docs for pki_setup and ssl_setup references"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make sure we document that pki_setup and ssl_setup scripts are not"},{"line_number":10,"context_line":"intended for production deployments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_44eee4ed","line":7,"in_reply_to":"baada198_b9a44958","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"}],"doc/source/configuration.rst":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6b55d7d83f7b23c7cb9117c0436a4cf5d8351998","unresolved":false,"context_lines":[{"line_number":372,"context_line":"Keystone tokens. This is a low probability attack vector, as compromise of"},{"line_number":373,"context_line":"a Keystone service machine\u0027s filesystem security almost certainly means the"},{"line_number":374,"context_line":"attacker will be able to gain direct access to the token backend. For"},{"line_number":375,"context_line":"production deployments, the use of ``keystone-manage pki_setup`` is"},{"line_number":376,"context_line":"discouraged since it is mainly a development tool."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"The files need to be in the locations specified by the top level Keystone"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_f9ac0138","line":375,"updated":"2014-07-01 01:48:39.000000000","message":"This may sound better at the beginning of the paragraph.\n\n\"This is a debug tool (blah, blah). In production an external CA should be used instead (blah, blah)....\"","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":372,"context_line":"Keystone tokens. This is a low probability attack vector, as compromise of"},{"line_number":373,"context_line":"a Keystone service machine\u0027s filesystem security almost certainly means the"},{"line_number":374,"context_line":"attacker will be able to gain direct access to the token backend. For"},{"line_number":375,"context_line":"production deployments, the use of ``keystone-manage pki_setup`` is"},{"line_number":376,"context_line":"discouraged since it is mainly a development tool."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"The files need to be in the locations specified by the top level Keystone"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_04ceac5a","line":375,"in_reply_to":"baada198_f9ac0138","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"e59860674c5a09fd5e2117f1563eecb8f6903508","unresolved":false,"context_lines":[{"line_number":373,"context_line":"a Keystone service machine\u0027s filesystem security almost certainly means the"},{"line_number":374,"context_line":"attacker will be able to gain direct access to the token backend. For"},{"line_number":375,"context_line":"production deployments, the use of ``keystone-manage pki_setup`` is"},{"line_number":376,"context_line":"discouraged since it is mainly a development tool."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"The files need to be in the locations specified by the top level Keystone"},{"line_number":379,"context_line":"configuration file as specified in the above section.  Additionally, the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_791711a4","line":376,"updated":"2014-07-01 01:45:03.000000000","message":"How is this line different to the start of the paragraph? Or is it a case of re-iterating that \"keystone-manage pki_setup\" should not be used in production? If this is the case I would propose re-phrasing to use a stronger word than \"discourage\" i.e.\n\n\"\nWe recommend that you do not use \u0027\u0027keystone-manage pki_setup\u0027\u0027 in a production environment.\n\"","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":373,"context_line":"a Keystone service machine\u0027s filesystem security almost certainly means the"},{"line_number":374,"context_line":"attacker will be able to gain direct access to the token backend. For"},{"line_number":375,"context_line":"production deployments, the use of ``keystone-manage pki_setup`` is"},{"line_number":376,"context_line":"discouraged since it is mainly a development tool."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"The files need to be in the locations specified by the top level Keystone"},{"line_number":379,"context_line":"configuration file as specified in the above section.  Additionally, the"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_e4d0d8f9","line":376,"in_reply_to":"baada198_791711a4","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6b55d7d83f7b23c7cb9117c0436a4cf5d8351998","unresolved":false,"context_lines":[{"line_number":649,"context_line":"used to encrypt communications with keystone. In the event that a Certificate"},{"line_number":650,"context_line":"Authority is not given a testing one will be created."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"It is likely in a production environment that these certificates will be"},{"line_number":653,"context_line":"created and provided externally. Note that ``ssl_setup`` is a development tool"},{"line_number":654,"context_line":"and not intended to be used for production deployments."},{"line_number":655,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_194e15c2","line":652,"updated":"2014-07-01 01:48:39.000000000","message":"I would change this to have much stronger language. It\u0027s not that it\u0027s likely production environments will do this externally, it\u0027s recommended to only use this for development environments.","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":649,"context_line":"used to encrypt communications with keystone. In the event that a Certificate"},{"line_number":650,"context_line":"Authority is not given a testing one will be created."},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"It is likely in a production environment that these certificates will be"},{"line_number":653,"context_line":"created and provided externally. Note that ``ssl_setup`` is a development tool"},{"line_number":654,"context_line":"and not intended to be used for production deployments."},{"line_number":655,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_44d8a41d","line":652,"in_reply_to":"baada198_194e15c2","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b083a7fbc4d4bf1bd760e23bc3aced67e69ba72d","unresolved":false,"context_lines":[{"line_number":651,"context_line":""},{"line_number":652,"context_line":"It is likely in a production environment that these certificates will be"},{"line_number":653,"context_line":"created and provided externally. Note that ``ssl_setup`` is a development tool"},{"line_number":654,"context_line":"and is only recommended for developments environment. We do not recommend using"},{"line_number":655,"context_line":"``ssl_setup`` for production environments."},{"line_number":656,"context_line":""},{"line_number":657,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_4b3b9eea","line":654,"updated":"2014-07-07 05:32:25.000000000","message":"nit: s/developments/development","commit_id":"bb34e70d04f336a58859a83abe17598672d308a9"}],"keystone/cli.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6b55d7d83f7b23c7cb9117c0436a4cf5d8351998","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":124,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":125,"context_line":"       NOT intended for production use, see Keystone Configuration"},{"line_number":126,"context_line":"       documentation for details.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    name \u003d \u0027pki_setup\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b97289e3","line":125,"updated":"2014-07-01 01:48:39.000000000","message":"There should be a blank line above this. Also make this a complete sentence by: This is NOT intended...","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":124,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":125,"context_line":"       NOT intended for production use, see Keystone Configuration"},{"line_number":126,"context_line":"       documentation for details.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    name \u003d \u0027pki_setup\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_043cec2e","line":125,"in_reply_to":"baada198_b97289e3","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"e59860674c5a09fd5e2117f1563eecb8f6903508","unresolved":false,"context_lines":[{"line_number":123,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":124,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":125,"context_line":"       NOT intended for production use, see Keystone Configuration"},{"line_number":126,"context_line":"       documentation for details.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    name \u003d \u0027pki_setup\u0027"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_79cc7136","line":126,"updated":"2014-07-01 01:45:03.000000000","message":"Could we also output a log message that states that \u0027pki_setup\u0027 should not be used in production?","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6b55d7d83f7b23c7cb9117c0436a4cf5d8351998","unresolved":false,"context_lines":[{"line_number":123,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":124,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":125,"context_line":"       NOT intended for production use, see Keystone Configuration"},{"line_number":126,"context_line":"       documentation for details.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    name \u003d \u0027pki_setup\u0027"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f97321e5","line":126,"updated":"2014-07-01 01:48:39.000000000","message":"The \"\"\" should be on a line by itself","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":123,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":124,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":125,"context_line":"       NOT intended for production use, see Keystone Configuration"},{"line_number":126,"context_line":"       documentation for details.\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    name \u003d \u0027pki_setup\u0027"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2449f0d0","line":126,"in_reply_to":"baada198_f97321e5","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"6b55d7d83f7b23c7cb9117c0436a4cf5d8351998","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":138,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. NOT intended"},{"line_number":139,"context_line":"       for production use, see Keystone Configuration documentation for"},{"line_number":140,"context_line":"       details.\"\"\""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_397e79af","line":138,"updated":"2014-07-01 01:48:39.000000000","message":"Same things here as above","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":138,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. NOT intended"},{"line_number":139,"context_line":"       for production use, see Keystone Configuration documentation for"},{"line_number":140,"context_line":"       details.\"\"\""},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6431280b","line":138,"in_reply_to":"baada198_397e79af","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"e59860674c5a09fd5e2117f1563eecb8f6903508","unresolved":false,"context_lines":[{"line_number":137,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":138,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. NOT intended"},{"line_number":139,"context_line":"       for production use, see Keystone Configuration documentation for"},{"line_number":140,"context_line":"       details.\"\"\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    name \u003d \u0027ssl_setup\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f9d7a1bd","line":140,"updated":"2014-07-01 01:45:03.000000000","message":"Similar comment as above for \u0027ssl_setup\u0027?","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9242344a909498db54cd503b4b16441cfd3d6354","unresolved":false,"context_lines":[{"line_number":137,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":138,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. NOT intended"},{"line_number":139,"context_line":"       for production use, see Keystone Configuration documentation for"},{"line_number":140,"context_line":"       details.\"\"\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    name \u003d \u0027ssl_setup\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_4455041c","line":140,"in_reply_to":"baada198_f9d7a1bd","updated":"2014-07-01 02:45:17.000000000","message":"Done","commit_id":"9bb98834822fb765da8e46b9a4bf2e87f818c524"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"5f2fce04c2bfb9eb52d5c2615a8ec62756eb2d2b","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":129,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":130,"context_line":"       This is NOT intended for production use, see Keystone Configuration"},{"line_number":131,"context_line":"       documentation for details."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7fa0d1f4","line":130,"updated":"2014-07-01 02:59:03.000000000","message":"Put a newline above this line and dedent it. Also dedent the line below.\nhttp://legacy.python.org/dev/peps/pep-0008/#documentation-strings","commit_id":"cb01efc9459f61d084c123f363318274187885a2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ba142571139d9ff936c4f7b926f9e686d2ce701a","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class PKISetup(BaseCertificateSetup):"},{"line_number":129,"context_line":"    \"\"\"Set up Key pairs and certificates for token signing and verification."},{"line_number":130,"context_line":"       This is NOT intended for production use, see Keystone Configuration"},{"line_number":131,"context_line":"       documentation for details."},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_baadfb8a","line":130,"in_reply_to":"baada198_7fa0d1f4","updated":"2014-07-01 16:52:59.000000000","message":"Done","commit_id":"cb01efc9459f61d084c123f363318274187885a2"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"5f2fce04c2bfb9eb52d5c2615a8ec62756eb2d2b","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":147,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. This is NOT"},{"line_number":148,"context_line":"       intended for production use, see Keystone Configuration documentation"},{"line_number":149,"context_line":"       for details."},{"line_number":150,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9fa5a506","line":147,"updated":"2014-07-01 02:59:03.000000000","message":"Same here.","commit_id":"cb01efc9459f61d084c123f363318274187885a2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ba142571139d9ff936c4f7b926f9e686d2ce701a","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class SSLSetup(BaseCertificateSetup):"},{"line_number":147,"context_line":"    \"\"\"Create key pairs and certificates for HTTPS connections. This is NOT"},{"line_number":148,"context_line":"       intended for production use, see Keystone Configuration documentation"},{"line_number":149,"context_line":"       for details."},{"line_number":150,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_daaaaf6f","line":147,"in_reply_to":"baada198_9fa5a506","updated":"2014-07-01 16:52:59.000000000","message":"Done","commit_id":"cb01efc9459f61d084c123f363318274187885a2"}]}