)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"9d1b522cd29d868fe1cfbf7761616c1b30018030","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"# SSL_CLIENT_VERIFY is one of the environment variables set by"},{"line_number":1412,"context_line":"# Apache mod_ssl to indicate the manner in which the incoming"},{"line_number":1413,"context_line":"# SSL X.509 clientcertificate was validated. WARNING: This"},{"line_number":1414,"context_line":"# value have security implications. Do  not change it unless"},{"line_number":1415,"context_line":"# you know exactly what you are doing! (list value)"},{"line_number":1416,"context_line":"#accept_ssl_client_verify_status\u003dSUCCESS"},{"line_number":1417,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_8f35adf8","line":1414,"updated":"2014-07-21 22:34:10.000000000","message":"Remove the extract space between \"Do  not\"","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"62befac4e15250898681016f8385528f21915d02","unresolved":false,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"# The SSL client certificate attribute where Keystone user_id"},{"line_number":1423,"context_line":"# is conveyed. (string value)"},{"line_number":1424,"context_line":"#user_id_attribute\u003dSSL_CLIENT_S_DN_UID"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"# The SSL client certificate attribute where Keystone username"},{"line_number":1427,"context_line":"# is conveyed. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_fe196b7a","line":1424,"updated":"2014-07-22 04:50:50.000000000","message":"Are these name universal?  Those are the names defined by Apache for SSL attributes.  How about other webserver or eventlet?  If not please mention they are Apache specific","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"309f2233282a38bf5c1e9c3198c9d5be9afb48a2","unresolved":false,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"# The SSL client certificate attribute where Keystone user_id"},{"line_number":1423,"context_line":"# is conveyed. (string value)"},{"line_number":1424,"context_line":"#user_id_attribute\u003dSSL_CLIENT_S_DN_UID"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"# The SSL client certificate attribute where Keystone username"},{"line_number":1427,"context_line":"# is conveyed. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_44ea880f","line":1424,"in_reply_to":"baada198_fe196b7a","updated":"2014-07-22 05:27:33.000000000","message":"They are Apache mod_ssl specific, I thought I made it abundantly clear in the spec.\n\nhttps://review.openstack.org/#/c/105913/\n\nBut sure, I can explicitly mention it again here just to make it less confusing.","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"}],"keystone/auth/plugins/external.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"cfaac8ee8142e43fda33668d0361b81120c52e9b","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _get_attribute(self, context, attribute_name):"},{"line_number":239,"context_line":"        if attribute_name is not None:"},{"line_number":240,"context_line":"            return context[\u0027environment\u0027].get(attribute_name)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _get_domain_attributes(self, context):"},{"line_number":243,"context_line":"        # use default domain ID as this plugin is not domain-aware"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7af2959b","line":240,"updated":"2014-07-01 09:48:55.000000000","message":"I made a small test: \ndef f(attr):\n    if attr is not None:\n        return attr\n    \np1 \u003d f(\u0027marek\u0027)\np2 \u003d f(None)\nprint p1, p2\n\u003e\u003e marek None\n\nso essentially you\u0027re reimplementing  .get().\nIf you want ring the bells because attribute_name is not present in the environment I\u0027d rather use context[\u0027environment\u0027][key] and KeyError exception.","commit_id":"2f1d9c644757f7b3b3e2843d1d2a5a46a5fe3682"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"68533a933f9d6fa643eabf42281882554a7e27bd","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            domain_id \u003d CONF.identity.default_domain_id"},{"line_number":188,"context_line":"        user_ref \u003d self.identity_api.get_user_by_name(username, domain_id)"},{"line_number":189,"context_line":"        return user_ref"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"@dependency.requires(\u0027assignment_api\u0027, \u0027identity_api\u0027)"},{"line_number":193,"context_line":"class X509SSLCert(auth.AuthMethodHandler):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a9d5e2ba","line":190,"updated":"2014-07-08 16:30:52.000000000","message":"Which takes precedence?  Token or Cert?\n\nIf Apache is configured to client cert is optional and the user sends a request with client cert and token, which takes precedence?","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            domain_id \u003d CONF.identity.default_domain_id"},{"line_number":188,"context_line":"        user_ref \u003d self.identity_api.get_user_by_name(username, domain_id)"},{"line_number":189,"context_line":"        return user_ref"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"@dependency.requires(\u0027assignment_api\u0027, \u0027identity_api\u0027)"},{"line_number":193,"context_line":"class X509SSLCert(auth.AuthMethodHandler):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_04579327","line":190,"in_reply_to":"baada198_a9d5e2ba","updated":"2014-07-08 17:25:35.000000000","message":"This is for authentication request. The \"method\" in the auth payload dictate which one to use.\n\nPOST /v3/auth/tokens\n\n{\"auth\": {\"identity\": {\n    \"methods\": [\"x509\"]\n...\n\nThe plugin is only called if method is \"x509\".","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"68533a933f9d6fa643eabf42281882554a7e27bd","unresolved":false,"context_lines":[{"line_number":193,"context_line":"class X509SSLCert(auth.AuthMethodHandler):"},{"line_number":194,"context_line":"    \"\"\"X.509 SSL client certificate authentication."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    This plugin is not domain-aware."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    This method must be used in conjunction with Apache mod_ssl. This also"},{"line_number":199,"context_line":"    implies that Keystone must also be running in Apache mod_wsgi."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_691caa78","line":196,"updated":"2014-07-08 16:30:52.000000000","message":"If the plugin is not domain aware then all the comments regarding domain related attributes should go to DomainAware  Cert class","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"class X509SSLCert(auth.AuthMethodHandler):"},{"line_number":194,"context_line":"    \"\"\"X.509 SSL client certificate authentication."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    This plugin is not domain-aware."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    This method must be used in conjunction with Apache mod_ssl. This also"},{"line_number":199,"context_line":"    implies that Keystone must also be running in Apache mod_wsgi."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_8d3027a0","line":196,"in_reply_to":"baada198_691caa78","updated":"2014-07-08 17:25:35.000000000","message":"k, will do","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"68533a933f9d6fa643eabf42281882554a7e27bd","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    The auth method accepts the following configurations from the"},{"line_number":218,"context_line":"    `[x509_ssl_cert_auth]` section in the Keystone configuration file."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    - `user_id_attribute` - the SSL client certificate attribute where"},{"line_number":221,"context_line":"                            Keystone user_id is conveyed."},{"line_number":222,"context_line":"    - `username_attribute` - the SSL client certificate attribute where"},{"line_number":223,"context_line":"                             Keystone username is conveyed."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c96bf61d","line":220,"updated":"2014-07-08 16:30:52.000000000","message":"On example please?\nDo you expect certs to include optional attributes?","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    The auth method accepts the following configurations from the"},{"line_number":218,"context_line":"    `[x509_ssl_cert_auth]` section in the Keystone configuration file."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    - `user_id_attribute` - the SSL client certificate attribute where"},{"line_number":221,"context_line":"                            Keystone user_id is conveyed."},{"line_number":222,"context_line":"    - `username_attribute` - the SSL client certificate attribute where"},{"line_number":223,"context_line":"                             Keystone username is conveyed."}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_8dd74723","line":220,"in_reply_to":"baada198_c96bf61d","updated":"2014-07-08 17:25:35.000000000","message":"A cert can carry any attributes, however, we can care about these.","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"68533a933f9d6fa643eabf42281882554a7e27bd","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    - `user_id_attribute` - the SSL client certificate attribute where"},{"line_number":221,"context_line":"                            Keystone user_id is conveyed."},{"line_number":222,"context_line":"    - `username_attribute` - the SSL client certificate attribute where"},{"line_number":223,"context_line":"                             Keystone username is conveyed."},{"line_number":224,"context_line":"    - `user_domain_id_attribute` - the SSL client certificate attribute"},{"line_number":225,"context_line":"                                   where Keystone user domain ID is conveyed"},{"line_number":226,"context_line":"                                   Will be ignored if plugin is not"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e40e1f32","line":223,"updated":"2014-07-08 16:30:52.000000000","message":"Move these comments to the domain aware class","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    - `user_id_attribute` - the SSL client certificate attribute where"},{"line_number":221,"context_line":"                            Keystone user_id is conveyed."},{"line_number":222,"context_line":"    - `username_attribute` - the SSL client certificate attribute where"},{"line_number":223,"context_line":"                             Keystone username is conveyed."},{"line_number":224,"context_line":"    - `user_domain_id_attribute` - the SSL client certificate attribute"},{"line_number":225,"context_line":"                                   where Keystone user domain ID is conveyed"},{"line_number":226,"context_line":"                                   Will be ignored if plugin is not"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_addc0b48","line":223,"in_reply_to":"baada198_e40e1f32","updated":"2014-07-08 17:25:35.000000000","message":"Done","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"810f68ad7c1e870f1e810024bf4c2c99f6ddc004","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def _assert_ssl_client_verify(self, context):"},{"line_number":249,"context_line":"        client_verify \u003d context[\u0027environment\u0027].get(\u0027SSL_CLIENT_VERIFY\u0027)"},{"line_number":250,"context_line":"        allow_status \u003d CONF.x509_ssl_cert_auth.accept_ssl_client_verify_status"},{"line_number":251,"context_line":"        if client_verify not in allow_status:"},{"line_number":252,"context_line":"            msg \u003d _(\u0027Unable to verify incoming SSL X.509 client certificate.\u0027)"},{"line_number":253,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a6862fb7","line":251,"updated":"2014-07-14 15:14:40.000000000","message":"It should log the received vs expected values at least in debug mode. This is a free-form configuration option so a user may have a typo, bad casing, etc.","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08c7a3646210bea8a0ecfd9a271a239ef79e289e","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def _assert_ssl_client_verify(self, context):"},{"line_number":249,"context_line":"        client_verify \u003d context[\u0027environment\u0027].get(\u0027SSL_CLIENT_VERIFY\u0027)"},{"line_number":250,"context_line":"        allow_status \u003d CONF.x509_ssl_cert_auth.accept_ssl_client_verify_status"},{"line_number":251,"context_line":"        if client_verify not in allow_status:"},{"line_number":252,"context_line":"            msg \u003d _(\u0027Unable to verify incoming SSL X.509 client certificate.\u0027)"},{"line_number":253,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_784bc4b0","line":251,"in_reply_to":"baada198_a6862fb7","updated":"2014-07-21 21:08:25.000000000","message":"Agreed. Will log the incoming status.","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"810f68ad7c1e870f1e810024bf4c2c99f6ddc004","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def authenticate(self, context, auth_info, auth_context):"},{"line_number":256,"context_line":"        # make sure the incoming client cert is verified by Apache"},{"line_number":257,"context_line":"        # frontend"},{"line_number":258,"context_line":"        self._assert_ssl_client_verify(context)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_217a0988","line":256,"updated":"2014-07-14 15:14:40.000000000","message":"More free-form fields full of complex SSL subject components. Should there be logging to help aid debugging?","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"08c7a3646210bea8a0ecfd9a271a239ef79e289e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            raise exception.Unauthorized(msg)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def authenticate(self, context, auth_info, auth_context):"},{"line_number":256,"context_line":"        # make sure the incoming client cert is verified by Apache"},{"line_number":257,"context_line":"        # frontend"},{"line_number":258,"context_line":"        self._assert_ssl_client_verify(context)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_932cf994","line":256,"in_reply_to":"baada198_217a0988","updated":"2014-07-21 21:08:25.000000000","message":"Sure I can log the SSL_* properties as debug logs.","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"47ce15acff5c4c9fc443a7566c738a2f47dcbd12","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            if user_id:"},{"line_number":270,"context_line":"                user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":271,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":272,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":273,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":274,"context_line":"                        user_domain_name)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_11a2699a","line":271,"updated":"2014-07-08 21:06:59.000000000","message":"In case of username, if domain_id and domain_name data is missing, is there a need to raise validation error similar to password auth plugin?\n\nhttps://github.com/openstack/keystone/blob/master/keystone/auth/plugins/password.py#L85","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"da9c84d546dc62d822211d2156ad4edafa507e72","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        try:"},{"line_number":269,"context_line":"            if user_id:"},{"line_number":270,"context_line":"                user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":271,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":272,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":273,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":274,"context_line":"                        user_domain_name)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a7ba5fbe","line":271,"in_reply_to":"baada198_11a2699a","updated":"2014-07-08 22:04:52.000000000","message":"will do","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"47ce15acff5c4c9fc443a7566c738a2f47dcbd12","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        user_domain_name)[\u0027id\u0027]"},{"line_number":275,"context_line":"                user_ref \u003d self.identity_api.get_user_by_name(username,"},{"line_number":276,"context_line":"                                                              user_domain_id)"},{"line_number":277,"context_line":"            auth_context[\u0027user_id\u0027] \u003d user_ref[\u0027id\u0027]"},{"line_number":278,"context_line":"        except (exception.UserNotFound, exception.DomainNotFound) as e:"},{"line_number":279,"context_line":"            LOG.exception(e)"},{"line_number":280,"context_line":"            raise exception.Unauthorized(e)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_19053514","line":277,"updated":"2014-07-08 21:06:59.000000000","message":"user_ref can be undefined if user_id and username is not provided as part of cert attributes. \n\nIs user_id or username attribute mandatory attribute in cert?","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"da9c84d546dc62d822211d2156ad4edafa507e72","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        user_domain_name)[\u0027id\u0027]"},{"line_number":275,"context_line":"                user_ref \u003d self.identity_api.get_user_by_name(username,"},{"line_number":276,"context_line":"                                                              user_domain_id)"},{"line_number":277,"context_line":"            auth_context[\u0027user_id\u0027] \u003d user_ref[\u0027id\u0027]"},{"line_number":278,"context_line":"        except (exception.UserNotFound, exception.DomainNotFound) as e:"},{"line_number":279,"context_line":"            LOG.exception(e)"},{"line_number":280,"context_line":"            raise exception.Unauthorized(e)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_279f2f52","line":277,"in_reply_to":"baada198_19053514","updated":"2014-07-08 22:04:52.000000000","message":"good point! lemme add a check","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"62befac4e15250898681016f8385528f21915d02","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    contains `+StdEnvVars` and the `SSLUserName` directive must set to a"},{"line_number":205,"context_line":"    valid SSL requirement enviroment attribute."},{"line_number":206,"context_line":"    For example::"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        SSLOptions +StdEnvVars"},{"line_number":209,"context_line":"        SSLUserName SSL_CLIENT_S_DN_CN"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_be41b33a","line":207,"updated":"2014-07-22 04:50:50.000000000","message":"Also SSLClientVerify should be set to optional","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"309f2233282a38bf5c1e9c3198c9d5be9afb48a2","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    contains `+StdEnvVars` and the `SSLUserName` directive must set to a"},{"line_number":205,"context_line":"    valid SSL requirement enviroment attribute."},{"line_number":206,"context_line":"    For example::"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        SSLOptions +StdEnvVars"},{"line_number":209,"context_line":"        SSLUserName SSL_CLIENT_S_DN_CN"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_21974646","line":207,"in_reply_to":"baada198_be41b33a","updated":"2014-07-22 05:27:33.000000000","message":"I can mention it, but that\u0027s really deployment-specific as some deployer may mandate client validation while some may not.","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"62befac4e15250898681016f8385528f21915d02","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    def _assert_ssl_client_verify(self, context):"},{"line_number":250,"context_line":"        client_verify \u003d context[\u0027environment\u0027].get(\u0027SSL_CLIENT_VERIFY\u0027)"},{"line_number":251,"context_line":"        allow_status \u003d CONF.x509_ssl_cert_auth.accept_ssl_client_verify_status"},{"line_number":252,"context_line":"        if client_verify not in allow_status:"},{"line_number":253,"context_line":"            msg \u003d _(\u0027Unable to verify incoming SSL X.509 client certificate. \u0027"},{"line_number":254,"context_line":"                    \u0027Invalid SSL client certificate verification \u0027"},{"line_number":255,"context_line":"                    \u0027status: %s\u0027) % client_verify"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_5e86d765","line":252,"updated":"2014-07-22 04:50:50.000000000","message":"You should validate only for SUCCESS state. What will happen if the accept_status in config is FAILED.  Will you allow failed cert?","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"309f2233282a38bf5c1e9c3198c9d5be9afb48a2","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    def _assert_ssl_client_verify(self, context):"},{"line_number":250,"context_line":"        client_verify \u003d context[\u0027environment\u0027].get(\u0027SSL_CLIENT_VERIFY\u0027)"},{"line_number":251,"context_line":"        allow_status \u003d CONF.x509_ssl_cert_auth.accept_ssl_client_verify_status"},{"line_number":252,"context_line":"        if client_verify not in allow_status:"},{"line_number":253,"context_line":"            msg \u003d _(\u0027Unable to verify incoming SSL X.509 client certificate. \u0027"},{"line_number":254,"context_line":"                    \u0027Invalid SSL client certificate verification \u0027"},{"line_number":255,"context_line":"                    \u0027status: %s\u0027) % client_verify"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2415943c","line":252,"in_reply_to":"baada198_5e86d765","updated":"2014-07-22 05:27:33.000000000","message":"I was contemplating whether to hardcode it to allow SUCCESS only or leave some room for other states like GENEROUS. Reason I am leaving it as configurable was I want deployers to have options. But I am OK with it either way.","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"94acd52b1cc538b654465d1637fca336b14110e1","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            if user_id:"},{"line_number":281,"context_line":"                user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":282,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":283,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":284,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":285,"context_line":"                        user_domain_name)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_724bdc86","line":282,"updated":"2014-07-21 23:02:57.000000000","message":"Line 196 indicated that this plugin is not domain-aware, however if user_id is not supplied, then the code has dependency on user_domain_*.","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"66643b43a88f3843892caa7f94696773c271f123","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            if user_id:"},{"line_number":281,"context_line":"                user_ref \u003d self.identity_api.get_user(user_id)"},{"line_number":282,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":283,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":284,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":285,"context_line":"                        user_domain_name)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_0697c290","line":282,"in_reply_to":"baada198_724bdc86","updated":"2014-07-22 00:27:18.000000000","message":"Domain information is always there regardless. The the non domain-aware, we just always use the default domain. See line 247. Non domain-aware basically means it only works with default domain users.","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"62befac4e15250898681016f8385528f21915d02","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":283,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":284,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":285,"context_line":"                        user_domain_name)[\u0027id\u0027]"},{"line_number":286,"context_line":"                user_ref \u003d self.identity_api.get_user_by_name(username,"},{"line_number":287,"context_line":"                                                              user_domain_id)"},{"line_number":288,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_bedd3372","line":285,"updated":"2014-07-22 04:50:50.000000000","message":"Dangerous code. What if the domain_name doesn\u0027t exist?","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"309f2233282a38bf5c1e9c3198c9d5be9afb48a2","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            elif username and (user_domain_id or user_domain_name):"},{"line_number":283,"context_line":"                if user_domain_name and not user_domain_id:"},{"line_number":284,"context_line":"                    user_domain_id \u003d self.assignment_api.get_domain_by_name("},{"line_number":285,"context_line":"                        user_domain_name)[\u0027id\u0027]"},{"line_number":286,"context_line":"                user_ref \u003d self.identity_api.get_user_by_name(username,"},{"line_number":287,"context_line":"                                                              user_domain_id)"},{"line_number":288,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_8106521a","line":285,"in_reply_to":"baada198_bedd3372","updated":"2014-07-22 05:27:33.000000000","message":"Not sure if I understand. You\u0027ll get DomainNotFound exception if domain doesn\u0027t exist. What\u0027s dangerous?","commit_id":"181075ba9d0ebccc7db9f10a2193e104c73eec95"}],"keystone/common/config.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"44049d58d9044ac87c80118c1db052c08231d105","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                   default\u003d\u0027keystone.auth.plugins.external.DefaultDomain\u0027,"},{"line_number":688,"context_line":"                   help\u003d\u0027The external (REMOTE_USER) auth plugin module.\u0027),"},{"line_number":689,"context_line":"    ],"},{"line_number":690,"context_line":"    \u0027x509_ssl_cert_auth\u0027: ["},{"line_number":691,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027,"},{"line_number":692,"context_line":"                   default\u003d\u0027SSL_CLIENT_S_DN_UID\u0027,"},{"line_number":693,"context_line":"                   help\u003d\u0027The SSL client certificate attribute where \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_21301407","line":690,"updated":"2014-07-08 12:34:41.000000000","message":"Ideally, these values would be managed by the mapping plugin.  We should look at refactoring LDAP, Kerberos, and X509 to use that, with a way to load the mapping from a config file.","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                   default\u003d\u0027keystone.auth.plugins.external.DefaultDomain\u0027,"},{"line_number":688,"context_line":"                   help\u003d\u0027The external (REMOTE_USER) auth plugin module.\u0027),"},{"line_number":689,"context_line":"    ],"},{"line_number":690,"context_line":"    \u0027x509_ssl_cert_auth\u0027: ["},{"line_number":691,"context_line":"        cfg.StrOpt(\u0027user_id_attribute\u0027,"},{"line_number":692,"context_line":"                   default\u003d\u0027SSL_CLIENT_S_DN_UID\u0027,"},{"line_number":693,"context_line":"                   help\u003d\u0027The SSL client certificate attribute where \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0a479d1e","line":690,"in_reply_to":"baada198_21301407","updated":"2014-07-08 17:25:35.000000000","message":"I agree. I can help with the refactoring work after this one is done. Doing refactoring work and this one at the same time is a bit too much.","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"3b479455c66b0edb147a2f8f6662a4baca2030c1","unresolved":false,"context_lines":[{"line_number":718,"context_line":"                         \u0027manner in which the incoming SSL X.509 client \u0027"},{"line_number":719,"context_line":"                         \u0027certificate was validated. \u0027"},{"line_number":720,"context_line":"                         \u0027WARNING: This value have security implications. Do \u0027"},{"line_number":721,"context_line":"                         \u0027 not change it unless you know exactly what you are \u0027"},{"line_number":722,"context_line":"                         \u0027doing!\u0027),"},{"line_number":723,"context_line":"    ],"},{"line_number":724,"context_line":"    \u0027paste_deploy\u0027: ["}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_89b6d73c","line":721,"updated":"2014-07-11 16:39:33.000000000","message":"nit: extra whitespace at start of line","commit_id":"e18c85ffaa6d72bc7b93dc9d9be6d52eb18b8fbc"}],"keystone/tests/test_v3.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"44049d58d9044ac87c80118c1db052c08231d105","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            context[\u0027environment\u0027][\u0027REMOTE_DOMAIN\u0027] \u003d remote_domain"},{"line_number":1159,"context_line":"        if not auth_data:"},{"line_number":1160,"context_line":"            auth_data \u003d self.build_authentication_request("},{"line_number":1161,"context_line":"                kerberos\u003dkerberos, x509\u003dx509)[\u0027auth\u0027]"},{"line_number":1162,"context_line":"        no_context \u003d None"},{"line_number":1163,"context_line":"        auth_info \u003d auth.controllers.AuthInfo.create(no_context, auth_data)"},{"line_number":1164,"context_line":"        auth_context \u003d {\u0027extras\u0027: {}, \u0027method_names\u0027: []}"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_414ee897","line":1161,"updated":"2014-07-08 12:34:41.000000000","message":"We should probably start making kerberos/x509 into some enumeration.","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"eaef51873d9dbf50ae58a38bbdf6660b0a2fd7d9","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            context[\u0027environment\u0027][\u0027REMOTE_DOMAIN\u0027] \u003d remote_domain"},{"line_number":1159,"context_line":"        if not auth_data:"},{"line_number":1160,"context_line":"            auth_data \u003d self.build_authentication_request("},{"line_number":1161,"context_line":"                kerberos\u003dkerberos, x509\u003dx509)[\u0027auth\u0027]"},{"line_number":1162,"context_line":"        no_context \u003d None"},{"line_number":1163,"context_line":"        auth_info \u003d auth.controllers.AuthInfo.create(no_context, auth_data)"},{"line_number":1164,"context_line":"        auth_context \u003d {\u0027extras\u0027: {}, \u0027method_names\u0027: []}"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2dc71b66","line":1161,"in_reply_to":"baada198_414ee897","updated":"2014-07-08 17:25:35.000000000","message":"good idea, lemme give it a shot","commit_id":"6bb86fe7971f250163395d450ccac06f7bafa789"}]}
