)]}'
{"keystone/assignment/backends/sql.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7b4c37eddad1ce01c8fb197603bd6ebf281411ff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                raise exception.ProjectNotFound(project_id\u003dtenant_name)"},{"line_number":57,"context_line":"            return project_ref.to_dict()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def get_project_hierarchy(self, tenant_id):"},{"line_number":60,"context_line":"        with sql.transaction() as session:"},{"line_number":61,"context_line":"            tenant \u003d self._get_project(session, tenant_id).to_dict()"},{"line_number":62,"context_line":"            hierarchy \u003d tenant[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3b93bca4","line":59,"updated":"2014-07-01 12:18:42.000000000","message":"I\u0027d have thought \u0027project_id\u0027 would a better term, since the \u0027tenant\u0027 term is being depreciated.  Also relevant for other variables in this method.","commit_id":"5225ed21a135720979a797135269469add15576c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7b4c37eddad1ce01c8fb197603bd6ebf281411ff","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            while tenant[\u0027parent_project_id\u0027] is not None:"},{"line_number":64,"context_line":"                parent_tenant \u003d self._get_project(session,"},{"line_number":65,"context_line":"                        tenant[\u0027parent_project_id\u0027]).to_dict()"},{"line_number":66,"context_line":"                #NOTE Keep compatible with Vishy\u0027s code"},{"line_number":67,"context_line":"                hierarchy \u003d parent_tenant[\u0027id\u0027] + \u0027.\u0027 + hierarchy"},{"line_number":68,"context_line":"                tenant \u003d parent_tenant"},{"line_number":69,"context_line":"            return hierarchy"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_bb526c11","line":66,"updated":"2014-07-01 12:18:42.000000000","message":"This needs to be more descriptive - readers won\u0027t know what \"Vishy\u0027s code\" means.  Also, please use the standard note format, i.e.:\n\n#NOTE(author): Keep.....","commit_id":"5225ed21a135720979a797135269469add15576c"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7b4c37eddad1ce01c8fb197603bd6ebf281411ff","unresolved":false,"context_lines":[{"line_number":581,"context_line":"    name \u003d sql.Column(sql.String(64), nullable\u003dFalse)"},{"line_number":582,"context_line":"    domain_id \u003d sql.Column(sql.String(64), sql.ForeignKey(\u0027domain.id\u0027),"},{"line_number":583,"context_line":"                           nullable\u003dFalse)"},{"line_number":584,"context_line":"    parent_project_id \u003d sql.Column(sql.String(64))"},{"line_number":585,"context_line":"    description \u003d sql.Column(sql.Text())"},{"line_number":586,"context_line":"    enabled \u003d sql.Column(sql.Boolean)"},{"line_number":587,"context_line":"    extra \u003d sql.Column(sql.JsonBlob())"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_3b6f3c94","line":584,"updated":"2014-07-01 12:18:42.000000000","message":"should this be a foreign key?","commit_id":"5225ed21a135720979a797135269469add15576c"}],"keystone/common/sql/migrate_repo/versions/051_add_parent_project.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7b4c37eddad1ce01c8fb197603bd6ebf281411ff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    # SQLite does not support constraints, and querying the constraints"},{"line_number":51,"context_line":"    # raises an exception"},{"line_number":52,"context_line":"    if migrate_engine.name \u003d\u003d \u0027sqlite\u0027:"},{"line_number":53,"context_line":"        return"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    migration_helpers.remove_constraints(list_constraints(migrate_engine))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1be7d813","line":53,"updated":"2014-07-01 12:18:42.000000000","message":"so if we running sqlite, we leave the parent_project_id column in place?","commit_id":"5225ed21a135720979a797135269469add15576c"}]}