)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"b5cc5b6c2e3edc25563cb374b4fc7e7cd988afcf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawomir Gonet \u003csgonet@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-01 13:44:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exception messages format changed to match one used in other componetns (no period at the end of message in cases where it can make problems while copying from terminal)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9a74f865f0813469f215bc6b4dd8a934fbf8f44"},{"line_number":10,"context_line":"Closes-Bug: #1313837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_f4031171","line":7,"updated":"2014-07-01 13:41:52.000000000","message":"spelling correction: components\n\nI\u0027d also just simplify by saying: \n\n\nCorrect exception message format by removing period\n\nException messages format changed to match one used in other components by removing the period at the end of message.","commit_id":"78e8c769fb045631cf3792e135d5b959e91804c7"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3dd9077c55ca4c908da183e7fbc2fd4407190935","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-07-01 13:44:56 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exception messages format changed to match one used in other componetns (no period at the end of message in cases where it can make problems while copying from terminal)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9a74f865f0813469f215bc6b4dd8a934fbf8f44"},{"line_number":10,"context_line":"Closes-Bug: #1313837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_49026d3f","line":8,"updated":"2014-07-01 12:06:21.000000000","message":"The first line should be limited to 50 characters and should not end with a period (commit messages over 72 characters will be rejected by the gate).\n\nSuggested reading: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"78e8c769fb045631cf3792e135d5b959e91804c7"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"16a360ecd68a89512233617a28f413f174010ce7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawomir Gonet \u003csgonet@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-01 19:54:01 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Exception messages format changed to match one"},{"line_number":8,"context_line":"used in other componetns (no period at the end"},{"line_number":9,"context_line":"of message in cases where it can make problems"},{"line_number":10,"context_line":"while copying from terminal)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_201e1c71","line":7,"updated":"2014-07-01 17:59:32.000000000","message":"Closer, but like Marek suggested: https://wiki.openstack.org/wiki/GitCommitMessages\n\nThe first line should be a 50 character summary. After that should be a newline and then you can add paragraph details. The additional lines can be up to 72 characters.","commit_id":"b81139afbddc975147d985c45e489cc55c342d48"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"197cc49863c955c7b0f48f31e9c7538baa6ae1c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawomir Gonet \u003csgonet@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-01 20:12:20 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ending periods in exceptioon messages deleted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of messages contained period at the end of line right after key"},{"line_number":10,"context_line":"content. This created bad user experience while copying from the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_bbf17dcf","line":7,"updated":"2014-07-01 18:14:48.000000000","message":"exception","commit_id":"92951291d19eafc29e6c2a762c9e2255b1bc5752"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"8f818ded9084129d70fa2708abb511452d57f180","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of messages contained a period at the end of line right after key"},{"line_number":10,"context_line":"content. This created bad user experience while copying from the"},{"line_number":11,"context_line":"terminal because this perdiod was usually copied too."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If9a74f865f0813469f215bc6b4dd8a934fbf8f44"},{"line_number":14,"context_line":"Closes-Bug: #1313837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_828a62bd","line":11,"updated":"2014-07-02 17:11:04.000000000","message":"period","commit_id":"45c496665f28b022ea45bd50adace6292467f76b"}],"keystone/exception.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0f1755aba392473db2ceed2c5337648db5a9f911","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class TrustUseLimitReached(Forbidden):"},{"line_number":249,"context_line":"    message_format \u003d _(\"No remaining uses for trust %(trust_id)s\")"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class CredentialNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c0dba019","line":249,"updated":"2014-07-01 17:45:51.000000000","message":"Even though the original didn\u0027t have a comma, I think that adding a : would make it more consistent.","commit_id":"78e8c769fb045631cf3792e135d5b959e91804c7"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"0f1755aba392473db2ceed2c5337648db5a9f911","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class Conflict(Error):"},{"line_number":270,"context_line":"    message_format \u003d _(\"Conflict occurred attempting to store %(type)s\""},{"line_number":271,"context_line":"                       \" %(details)s\")"},{"line_number":272,"context_line":"    code \u003d 409"},{"line_number":273,"context_line":"    title \u003d \u0027Conflict\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_002cb801","line":270,"updated":"2014-07-01 17:45:51.000000000","message":"I would probably put a : after %(type)s so that some punctuation separates the values.","commit_id":"78e8c769fb045631cf3792e135d5b959e91804c7"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"16a360ecd68a89512233617a28f413f174010ce7","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class Conflict(Error):"},{"line_number":270,"context_line":"    message_format \u003d _(\"Conflict occurred attempting to store: %(type)s\""},{"line_number":271,"context_line":"                       \" %(details)s\")"},{"line_number":272,"context_line":"    code \u003d 409"},{"line_number":273,"context_line":"    title \u003d \u0027Conflict\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_bb1dfd68","line":270,"updated":"2014-07-01 17:59:32.000000000","message":"I still think that there should be something between type and details to visually separate the two.","commit_id":"b81139afbddc975147d985c45e489cc55c342d48"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"4ee60f20ca143f08ef77165028de41ba87abe460","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"class IdentityProviderNotFound(NotFound):"},{"line_number":261,"context_line":"    message_format \u003d _(\"Could not find IdentityProvider: %(idp_id)s\")"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class FederatedProtocolNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_fca048f6","line":261,"updated":"2014-07-01 23:26:38.000000000","message":"Nit: \"IdentityProvider\" should be two words \"Identity Provider\"","commit_id":"92951291d19eafc29e6c2a762c9e2255b1bc5752"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"4ee60f20ca143f08ef77165028de41ba87abe460","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class FederatedProtocolNotFound(NotFound):"},{"line_number":265,"context_line":"    message_format \u003d _(\"Could not find federated protocol %(protocol_id)s for\""},{"line_number":266,"context_line":"                       \" IdentityProvider: %(idp_id)s\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class Conflict(Error):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_fc792894","line":266,"updated":"2014-07-01 23:26:38.000000000","message":"As above: \"IdentityProvider\" should be two words","commit_id":"92951291d19eafc29e6c2a762c9e2255b1bc5752"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"197cc49863c955c7b0f48f31e9c7538baa6ae1c5","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class Conflict(Error):"},{"line_number":270,"context_line":"    message_format \u003d _(\"Conflict occurred attempting to store: %(type)s\""},{"line_number":271,"context_line":"                       \" %(details)s\")"},{"line_number":272,"context_line":"    code \u003d 409"},{"line_number":273,"context_line":"    title \u003d \u0027Conflict\u0027"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1ba7c9be","line":271,"updated":"2014-07-01 18:14:48.000000000","message":"This is getting into a nitpick but I\u0027d prefer:\n\n\"Conflict occurred attempting to store %(type)s: %(details)s\")","commit_id":"92951291d19eafc29e6c2a762c9e2255b1bc5752"}]}
