)]}'
{"keystone/token/backends/kvs.py":[{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"051857e8a4a2539784ed3b295342328ed1e7c949","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from keystone.openstack.common import log"},{"line_number":26,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":27,"context_line":"from keystone import token"},{"line_number":28,"context_line":"from keystone.token import provider as token_provider"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_20c8e355","line":28,"updated":"2014-07-16 15:10:39.000000000","message":"There is some inconsistency in this import. Everywhere else in the patch this is referred to as provider not token_provider. I think token_provider is more explicit but should we maintain the same imports throughout?","commit_id":"348edec96f2f218c7613832e6bbddd20757f0a10"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"eacd84a5c9edd867d85486c2bc38c673f1a31356","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from keystone.openstack.common import log"},{"line_number":26,"context_line":"from keystone.openstack.common import timeutils"},{"line_number":27,"context_line":"from keystone import token"},{"line_number":28,"context_line":"from keystone.token import provider as token_provider"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_06bbf875","line":28,"in_reply_to":"baada198_20c8e355","updated":"2014-07-16 15:35:26.000000000","message":"Good Point! let me fix this here (less change) we can do a cleanup-pass and make it more explicit down the line.","commit_id":"348edec96f2f218c7613832e6bbddd20757f0a10"},{"author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"change_message_id":"051857e8a4a2539784ed3b295342328ed1e7c949","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        data_copy \u003d copy.deepcopy(data)"},{"line_number":98,"context_line":"        ptk \u003d self._prefix_token_id(token_id)"},{"line_number":99,"context_line":"        if not data_copy.get(\u0027expires\u0027):"},{"line_number":100,"context_line":"            data_copy[\u0027expires\u0027] \u003d token_provider.default_expire_time()"},{"line_number":101,"context_line":"        if not data_copy.get(\u0027user_id\u0027):"},{"line_number":102,"context_line":"            data_copy[\u0027user_id\u0027] \u003d data_copy[\u0027user\u0027][\u0027id\u0027]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e0e50bdd","line":100,"updated":"2014-07-16 15:10:39.000000000","message":"e.g. should this be token_provider.default_expire_time() or provider.default_expire_time() like elsewhere in the patch?","commit_id":"348edec96f2f218c7613832e6bbddd20757f0a10"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"eacd84a5c9edd867d85486c2bc38c673f1a31356","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        data_copy \u003d copy.deepcopy(data)"},{"line_number":98,"context_line":"        ptk \u003d self._prefix_token_id(token_id)"},{"line_number":99,"context_line":"        if not data_copy.get(\u0027expires\u0027):"},{"line_number":100,"context_line":"            data_copy[\u0027expires\u0027] \u003d token_provider.default_expire_time()"},{"line_number":101,"context_line":"        if not data_copy.get(\u0027user_id\u0027):"},{"line_number":102,"context_line":"            data_copy[\u0027user_id\u0027] \u003d data_copy[\u0027user\u0027][\u0027id\u0027]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_466c1009","line":100,"in_reply_to":"baada198_e0e50bdd","updated":"2014-07-16 15:35:26.000000000","message":"++ see above response.","commit_id":"348edec96f2f218c7613832e6bbddd20757f0a10"}]}