)]}'
{"keystone/tests/unit/token/test_token_persistence_proxy.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f42c5afe40374df5289cf662ce96272732fb3088","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Clear the KVS registry so we can re-instantiate the KVS backend. This"},{"line_number":70,"context_line":"        # is required because the KVS core tries to limit duplication of"},{"line_number":71,"context_line":"        # CacheRegion objects and CacheRegion objects cannot be reconfigured."},{"line_number":72,"context_line":"        kvs_core.KEY_VALUE_STORE_REGISTRY.clear()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        manager \u003d token.persistence.Manager()"},{"line_number":75,"context_line":"        self.assertIsInstance(manager.driver, proxy_memcache.Token)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_2e36b151","line":72,"updated":"2014-07-24 22:20:23.000000000","message":"This may be a dumb question, but it isn\u0027t immediately obvious why we are re-instantiating the kvs backend here, for the memcache driver.  At first blush, it looks like a copy \u0026 paste error form the previous method...but I\u0027m sure you\u0027ll enlighten me as to why it\u0027s not...:-)","commit_id":"eccff93616fcda14a8e193422d50e24156480580"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"1902bc020a0e923c0fe66833cbf4270a73a1d5f4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Clear the KVS registry so we can re-instantiate the KVS backend. This"},{"line_number":70,"context_line":"        # is required because the KVS core tries to limit duplication of"},{"line_number":71,"context_line":"        # CacheRegion objects and CacheRegion objects cannot be reconfigured."},{"line_number":72,"context_line":"        kvs_core.KEY_VALUE_STORE_REGISTRY.clear()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        manager \u003d token.persistence.Manager()"},{"line_number":75,"context_line":"        self.assertIsInstance(manager.driver, proxy_memcache.Token)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_4e24c5c5","line":72,"in_reply_to":"baada198_2e36b151","updated":"2014-07-24 22:34:48.000000000","message":"Just as the comment says, we can\u0027t re-initialize the backend, it was already initialized as part of setup, so to re-instantiate we need to clear it. I can update the comment if that would help.\n\nMemcache is a *very* light wrapper to the KVS backend (as in, it says \"use dogpile\u0027s memcache backend\" and thats about it).","commit_id":"eccff93616fcda14a8e193422d50e24156480580"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b61218758ec9d08f4de69cd524e71ee9ed4ec855","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Clear the KVS registry so we can re-instantiate the KVS backend. This"},{"line_number":70,"context_line":"        # is required because the KVS core tries to limit duplication of"},{"line_number":71,"context_line":"        # CacheRegion objects and CacheRegion objects cannot be reconfigured."},{"line_number":72,"context_line":"        kvs_core.KEY_VALUE_STORE_REGISTRY.clear()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        manager \u003d token.persistence.Manager()"},{"line_number":75,"context_line":"        self.assertIsInstance(manager.driver, proxy_memcache.Token)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_a92c7b94","line":72,"in_reply_to":"baada198_4e24c5c5","updated":"2014-07-24 22:37:58.000000000","message":"I think the info that memcache is a light wrapper to the KVS backend is the missing info in the comment - with that, I\u0027m good to go.","commit_id":"eccff93616fcda14a8e193422d50e24156480580"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"49a313bcbc7db9c01b514f6967824193b90ab82f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Clear the KVS registry so we can re-instantiate the KVS backend. This"},{"line_number":70,"context_line":"        # is required because the KVS core tries to limit duplication of"},{"line_number":71,"context_line":"        # CacheRegion objects and CacheRegion objects cannot be reconfigured."},{"line_number":72,"context_line":"        kvs_core.KEY_VALUE_STORE_REGISTRY.clear()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        manager \u003d token.persistence.Manager()"},{"line_number":75,"context_line":"        self.assertIsInstance(manager.driver, proxy_memcache.Token)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_09c6479c","line":72,"in_reply_to":"baada198_a92c7b94","updated":"2014-07-24 22:46:27.000000000","message":"++ I will do that, there is a rebase that is needed anyway. Will post new patch in a few minutes. Thanks henry!","commit_id":"eccff93616fcda14a8e193422d50e24156480580"}]}