)]}'
{"keystone/identity/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1f8ae22b85f3a0042389036db8d555b044bc4ff","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        \"\"\""},{"line_number":286,"context_line":"        conf \u003d CONF.identity"},{"line_number":287,"context_line":"        if not self._needs_post_processing(driver):"},{"line_number":288,"context_line":"            return ref"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        LOG.debug(\u0027ID Mapping - Domain ID: %(domain)s, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_bcc30d37","line":287,"updated":"2014-07-17 14:46:28.000000000","message":"Maybe add a comment that the classic case of this is when running with a single SQL driver...","commit_id":"80509a2b092bba9e386bb05f41b12dd9c4eb2d21"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1f8ae22b85f3a0042389036db8d555b044bc4ff","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            raise ValueError(_(\u0027Expected dict or list: %s\u0027) % type(ref))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _needs_post_processing(self, driver):"},{"line_number":310,"context_line":"        \"\"\"Returns whether the driver needs help. e.g. SQL.\"\"\""},{"line_number":311,"context_line":"        return (driver is not self.driver or not driver.generates_uuids() or"},{"line_number":312,"context_line":"                not driver.is_domain_aware())"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_fcfe6504","line":310,"updated":"2014-07-17 14:46:28.000000000","message":"so the default SQL driver is one that doesn\u0027t meet help...maybe a better title would be\n\n\"\"\"Returns whether entity from driver needs domain added or mapping.\"\"\"\n\nor something like that","commit_id":"80509a2b092bba9e386bb05f41b12dd9c4eb2d21"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1f8ae22b85f3a0042389036db8d555b044bc4ff","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        return ref"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def _insert_domain_id_if_needed(self, ref, driver, domain_id, conf):"},{"line_number":342,"context_line":"        \"\"\"Maybe inserts the domain id to the ref."},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        If the driver can\u0027t handle domains, then we need to insert the"},{"line_number":345,"context_line":"        domain_id into the entity being returned.  If the domain_id is"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9cbe49ff","line":342,"updated":"2014-07-17 14:46:28.000000000","message":"Perhaps a better title would be\n\n\"\"\"\"Inserts the domain ID into the ref, if required.\"\"\"\"","commit_id":"80509a2b092bba9e386bb05f41b12dd9c4eb2d21"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"b1f8ae22b85f3a0042389036db8d555b044bc4ff","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    def _is_mapping_needed(self, driver):"},{"line_number":355,"context_line":"        \"\"\"Returns whether mapping is needed."},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        There are two situations where we must now use the mapping:"},{"line_number":358,"context_line":"        - this isn\u0027t the default driver (i.e. multiple backends), or"},{"line_number":359,"context_line":"        - we have a single backend that doesn\u0027t use UUIDs"},{"line_number":360,"context_line":"        The exception to the above is that we must honor backward"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_5c291136","line":357,"updated":"2014-07-17 14:46:28.000000000","message":"remove the word \"now\"","commit_id":"80509a2b092bba9e386bb05f41b12dd9c4eb2d21"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"44ba7dbe86f21f7461003d775f1130e35194c7a2","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        \"\"\""},{"line_number":286,"context_line":"        conf \u003d CONF.identity"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        # a classic case would be when running with a single SQL driver"},{"line_number":289,"context_line":"        if not self._needs_post_processing(driver):"},{"line_number":290,"context_line":"            return ref"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_de223100","line":288,"updated":"2014-07-19 09:13:49.000000000","message":"minor point, but I\u0027d prefer this comment to be inside the if statement, so that it\u0027s obvious that\u0027s what we mean","commit_id":"08c0b0f72a2caf728fae17d47c5395f9330c0af3"}]}