)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"b963f3e4b4e099f40e5d74ad5b77d21b0b8cf4e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcos Fermin Lobo \u003cmarcos.fermin.lobo@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-22 16:48:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_3d3e57ba","line":7,"updated":"2014-07-22 17:06:43.000000000","message":"Suggest changing this line to \"CRUD grant functions don\u0027t check user_id and group_id\"","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"836f5fa048ca50afb75644108558fc7928d27796","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcos Fermin Lobo \u003cmarcos.fermin.lobo@cern.ch\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-22 16:48:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_5aea0dd9","line":7,"in_reply_to":"baada198_3d3e57ba","updated":"2014-07-23 08:11:55.000000000","message":"Done","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"b963f3e4b4e099f40e5d74ad5b77d21b0b8cf4e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"},{"line_number":11,"context_line":"project_id are checked and I don\u0027t see any reason why"},{"line_number":12,"context_line":"don\u0027t check user_id and group_id as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_bd7fc768","line":9,"updated":"2014-07-22 17:06:43.000000000","message":"I see the functions[1] reference exists in the bug, but the reference isn\u0027t included in this commit message.  I\u0027d suggest removing the [1] in the commit message, since people can look at the bug to get the link.\n\nAlso, the reference to Icehouse should be removed here, as this bug should first be fixed on the master branch (currently Juno).","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"836f5fa048ca50afb75644108558fc7928d27796","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"},{"line_number":11,"context_line":"project_id are checked and I don\u0027t see any reason why"},{"line_number":12,"context_line":"don\u0027t check user_id and group_id as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_9abbc5e3","line":9,"in_reply_to":"baada198_bd7fc768","updated":"2014-07-23 08:11:55.000000000","message":"Done","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"b963f3e4b4e099f40e5d74ad5b77d21b0b8cf4e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"},{"line_number":11,"context_line":"project_id are checked and I don\u0027t see any reason why"},{"line_number":12,"context_line":"don\u0027t check user_id and group_id as well."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_bdb7c7f7","line":10,"updated":"2014-07-22 17:06:43.000000000","message":"Suggest changing this sentence to describe what this change does.  Something like:\n\n\"role_id, domain_id, and project_id are checked, and this change adds checking for user_id and group_id.\"","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"836f5fa048ca50afb75644108558fc7928d27796","unresolved":false,"context_lines":[{"line_number":7,"context_line":"CRUD grant don\u0027t check user_id and group_id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Icehouse release, CRUD grant functions[1] don\u0027t check if"},{"line_number":10,"context_line":"user_id and group_id exists. role_id, domain_id and"},{"line_number":11,"context_line":"project_id are checked and I don\u0027t see any reason why"},{"line_number":12,"context_line":"don\u0027t check user_id and group_id as well."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_bab24904","line":10,"in_reply_to":"baada198_bdb7c7f7","updated":"2014-07-23 08:11:55.000000000","message":"Done","commit_id":"9ceb12aeac9e3dc4188d8630148e980680b863db"}],"keystone/tests/test_backend_ldap.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"68ea5ad2ae7a45b538f31f40946778375cc85c59","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"        self.skipTest(\u0027Blocked by bug 1221805\u0027)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"    def test_grants_not_user(self):"},{"line_number":1767,"context_line":"        self.skipTest(\u0027SQL backend does not handle UserApi\u0027)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"    def test_grants_not_group(self):"},{"line_number":1770,"context_line":"        self.skipTest(\u0027SQL backend does not handle GroupApi\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_1dc7ac66","line":1767,"updated":"2014-07-23 09:37:05.000000000","message":"Should this be LDAP backend?","commit_id":"642d5263de2f672cdacff751f19e47ed4437a933"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"68ea5ad2ae7a45b538f31f40946778375cc85c59","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        self.skipTest(\u0027SQL backend does not handle UserApi\u0027)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"    def test_grants_not_group(self):"},{"line_number":1770,"context_line":"        self.skipTest(\u0027SQL backend does not handle GroupApi\u0027)"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"class LdapIdentitySqlAssignmentWithMapping(LdapIdentitySqlAssignment):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_5dc1244d","line":1770,"updated":"2014-07-23 09:37:05.000000000","message":"Same as above","commit_id":"642d5263de2f672cdacff751f19e47ed4437a933"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"dd616ad1aa2260bd93428837f5adfe72d1caa40f","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        self.skipTest(\u0027SQL backend does not handle UserApi\u0027)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"    def test_grants_not_group(self):"},{"line_number":1770,"context_line":"        self.skipTest(\u0027SQL backend does not handle GroupApi\u0027)"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"class LdapIdentitySqlAssignmentWithMapping(LdapIdentitySqlAssignment):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_dd6e1400","line":1770,"in_reply_to":"baada198_5dc1244d","updated":"2014-07-23 09:49:00.000000000","message":"Bob, I think you are right, I\u0027ll change it. Thanks for your review","commit_id":"642d5263de2f672cdacff751f19e47ed4437a933"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"c5fe73ee81d3e568c6807e0753fd68bf0545ebed","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        self.skipTest(\u0027SQL backend does not handle UserApi\u0027)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"    def test_grants_not_group(self):"},{"line_number":1770,"context_line":"        self.skipTest(\u0027SQL backend does not handle GroupApi\u0027)"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"class LdapIdentitySqlAssignmentWithMapping(LdapIdentitySqlAssignment):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_e06ecfff","line":1770,"in_reply_to":"baada198_5dc1244d","updated":"2014-07-23 10:14:50.000000000","message":"I checked it and I think that yes, these methods should be in the LdapIdentitySqlAssignment class (as now), because this class runs tests for LDAP and SQL backend.\n\nAre you agree?","commit_id":"642d5263de2f672cdacff751f19e47ed4437a933"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"936195273122b2003eb68e577041c2b35716e692","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"        self.skipTest(\u0027SQL backend does not handle UserApi\u0027)"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"    def test_grants_not_group(self):"},{"line_number":1770,"context_line":"        self.skipTest(\u0027SQL backend does not handle GroupApi\u0027)"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":""},{"line_number":1773,"context_line":"class LdapIdentitySqlAssignmentWithMapping(LdapIdentitySqlAssignment):"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_88051817","line":1770,"in_reply_to":"baada198_e06ecfff","updated":"2014-07-24 06:04:19.000000000","message":"Agreed.","commit_id":"642d5263de2f672cdacff751f19e47ed4437a933"}]}