)]}'
{"keystone/tests/test_validation.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c7ef5f4040be30aba14bb101e6d668b65ef1b620","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"baada198_1b3ed4b9","updated":"2014-07-30 16:43:34.000000000","message":"separate topic / commit - but why is there special encoding?","commit_id":"c97981650d3cd7e7abef70aa4dd4f455128889fd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c4742737b86be7f7b185ad1a1f72374d1ffcd337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"baada198_d59a645f","in_reply_to":"baada198_1b3ed4b9","updated":"2014-07-30 18:56:25.000000000","message":"We need the special encoding in order to test unicode strings. See test at line 93","commit_id":"c97981650d3cd7e7abef70aa4dd4f455128889fd"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c7ef5f4040be30aba14bb101e6d668b65ef1b620","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Test that we have successful validation on boolean values for"},{"line_number":114,"context_line":"        `enabled`."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        valid_enabled_formats \u003d [True, False]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        for valid_enabled in valid_enabled_formats:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_bb26c8b7","line":115,"updated":"2014-07-30 16:43:34.000000000","message":"remove this one? and reference the new var?","commit_id":"c97981650d3cd7e7abef70aa4dd4f455128889fd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c4742737b86be7f7b185ad1a1f72374d1ffcd337","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        Test that we have successful validation on boolean values for"},{"line_number":114,"context_line":"        `enabled`."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        valid_enabled_formats \u003d [True, False]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        for valid_enabled in valid_enabled_formats:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f5a9287d","line":115,"in_reply_to":"baada198_bb26c8b7","updated":"2014-07-30 18:56:25.000000000","message":"Done","commit_id":"c97981650d3cd7e7abef70aa4dd4f455128889fd"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"26a86ff663acedf0053a116b1bd12898cc95dd58","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"_VALID_ENABLED_FORMATS \u003d [True, False]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_INVALID_ENABLED_FORMATS \u003d [\u0027some string\u0027, 1, 0, \u0027True\u0027, \u0027False\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class BaseValidationTestCase(tests.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0bdbcd21","line":41,"updated":"2014-07-31 08:00:45.000000000","message":"So, this is not actually used?","commit_id":"898489aa0d5cd5097384c37768719e5a87442a94"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7a69db506c4075348e72891a01d83959fc8b29bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"_VALID_ENABLED_FORMATS \u003d [True, False]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_INVALID_ENABLED_FORMATS \u003d [\u0027some string\u0027, 1, 0, \u0027True\u0027, \u0027False\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class BaseValidationTestCase(tests.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_69551c1d","line":41,"in_reply_to":"baada198_0bdbcd21","updated":"2014-07-31 18:28:23.000000000","message":"it is used in other patches that test schemas: \n\nassignment api: https://review.openstack.org/#/c/86484/37/keystone/tests/test_validation.py\n\ncatalog api: https://review.openstack.org/#/c/96266/22/keystone/tests/test_validation.py\n\nRight now it is included in the patch for assignment api, so other patches (like the catalog api validation patch) are dependent on the assignment api patch. This was an attempt to land the common stuff so that all api validation patches (assignment, catalog, policy, etc..) use the same thing.","commit_id":"898489aa0d5cd5097384c37768719e5a87442a94"}]}