)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Tests have been updated to compare results from the token_api"},{"line_number":13,"context_line":"and the token_provider_api for the revoked token list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change is to ensure interactions with the token persitence"},{"line_number":16,"context_line":"are consistent so that it is possible to support toggling"},{"line_number":17,"context_line":"persistence of tokens."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_2e84150a","line":15,"updated":"2014-07-24 06:31:43.000000000","message":"s/persitence/persistence","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027] for x in self.token_api.list_revoked_tokens()]"},{"line_number":3169,"context_line":"        self.assertEqual("},{"line_number":3170,"context_line":"            revoked_ids,"},{"line_number":3171,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3172,"context_line":"        for token_id in token_ids:"},{"line_number":3173,"context_line":"            self.assertIn(token_id, revoked_ids)"},{"line_number":3174,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8ee361a3","line":3171,"updated":"2014-07-24 06:31:43.000000000","message":"IMHO it would make it easier on the eyes if the expression:\n\n  [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()]\n\nis stored in a variable (e.g. revoked_tokens_from_token_provider_api). And then the assert could be something like:\n\n\nself.assertEqual(revoked_tokens_from_token_api,\n                        revoked_tokens_from_token_provider_api)","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"f8dce87c45aa6bde0f327afc1bfb21a0551e104f","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027] for x in self.token_api.list_revoked_tokens()]"},{"line_number":3169,"context_line":"        self.assertEqual("},{"line_number":3170,"context_line":"            revoked_ids,"},{"line_number":3171,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3172,"context_line":"        for token_id in token_ids:"},{"line_number":3173,"context_line":"            self.assertIn(token_id, revoked_ids)"},{"line_number":3174,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_da3984f3","line":3171,"in_reply_to":"baada198_8ee361a3","updated":"2014-07-24 13:56:30.000000000","message":"Originally that was the plan, but it really looks much worse. I\u0027ll consolidate it to an assert method so we don\u0027t have as much change, but it really isn\u0027t any better to read because it ends up looking like:\n\n    revoked_tokens_from_token_provider_api \u003d [\n        x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()]\n    self.assertEqual(revoked_ids,\n                     revoked_tokens_from_token_provider)","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"b5bbb6538e70745ce8e0d0b01825b23f55ac5946","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027] for x in self.token_api.list_revoked_tokens()]"},{"line_number":3169,"context_line":"        self.assertEqual("},{"line_number":3170,"context_line":"            revoked_ids,"},{"line_number":3171,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3172,"context_line":"        for token_id in token_ids:"},{"line_number":3173,"context_line":"            self.assertIn(token_id, revoked_ids)"},{"line_number":3174,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_71fb3abe","line":3171,"in_reply_to":"baada198_da3984f3","updated":"2014-07-24 15:15:12.000000000","message":"I would rename the variables `revoked_ids` and  `revoked_tokens_from_token_provider` to `revoked_tokens_from_token_api` and `revoked_token_ids_from_token_provider_api`, respectively. That way you have:\n\nself.assertEquals(revoked_token_ids_from_token_api,\n                          revoked_tokens_ids_from_token_provider_api)","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":3192,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027] for x in self.token_api.list_revoked_tokens()]"},{"line_number":3193,"context_line":"        self.assertEqual("},{"line_number":3194,"context_line":"            revoked_ids,"},{"line_number":3195,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3196,"context_line":"        self.assertEqual([], revoked_ids)"},{"line_number":3197,"context_line":""},{"line_number":3198,"context_line":"    def test_list_revoked_tokens_for_single_token(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_ce9399fe","line":3195,"updated":"2014-07-24 06:31:43.000000000","message":"Same as above","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":3259,"context_line":"                          for x in self.token_api.list_revoked_tokens()]"},{"line_number":3260,"context_line":"        self.assertEqual("},{"line_number":3261,"context_line":"            revoked_tokens,"},{"line_number":3262,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3263,"context_line":"        self.assertIn(token_id, revoked_tokens)"},{"line_number":3264,"context_line":"        # Delete the second token, through the manager"},{"line_number":3265,"context_line":"        self.token_api.delete_token(token2_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6e4d2dc5","line":3262,"updated":"2014-07-24 06:31:43.000000000","message":"Same as above","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":3267,"context_line":"                          for x in self.token_api.list_revoked_tokens()]"},{"line_number":3268,"context_line":"        self.assertEqual("},{"line_number":3269,"context_line":"            revoked_tokens,"},{"line_number":3270,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3271,"context_line":"        # Verify both tokens are in the revocation list."},{"line_number":3272,"context_line":"        self.assertIn(token_id, revoked_tokens)"},{"line_number":3273,"context_line":"        self.assertIn(token2_id, revoked_tokens)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_ae4745a2","line":3270,"updated":"2014-07-24 06:31:43.000000000","message":"Same as above","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"3d899208dec68fe7d33840f3da5e5e9b73380bf3","unresolved":false,"context_lines":[{"line_number":3283,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027] for x in self.token_api.list_revoked_tokens()]"},{"line_number":3284,"context_line":"        self.assertEqual("},{"line_number":3285,"context_line":"            revoked_ids,"},{"line_number":3286,"context_line":"            [x[\u0027id\u0027] for x in self.token_provider_api.list_revoked_tokens()])"},{"line_number":3287,"context_line":"        self.assertIn(token_id_hash, revoked_ids)"},{"line_number":3288,"context_line":"        self.assertNotIn(token_id, revoked_ids)"},{"line_number":3289,"context_line":"        for t in self.token_api.list_revoked_tokens():"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_cec5590b","line":3286,"updated":"2014-07-24 06:31:43.000000000","message":"Same as above","commit_id":"1a6192935fe774612c680f8eb586e49c33434d6d"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"d1edc2ece830a19b9189c7204df52fcb147032f4","unresolved":false,"context_lines":[{"line_number":3173,"context_line":"        self.assertEqual(data_ref, new_data_ref)"},{"line_number":3174,"context_line":""},{"line_number":3175,"context_line":"    def check_list_revoked_tokens(self, token_ids):"},{"line_number":3176,"context_line":"        revoked_ids \u003d [x[\u0027id\u0027]"},{"line_number":3177,"context_line":"                       for x in self.token_provider_api.list_revoked_tokens()]"},{"line_number":3178,"context_line":"        self._assert_revoked_token_list_matches_token_persistence(revoked_ids)"},{"line_number":3179,"context_line":"        for token_id in token_ids:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9366d6ba","line":3176,"updated":"2014-08-11 11:34:01.000000000","message":"These 2 lines (once 3 lines) appear together a few times in the code, perhaps it makes sense to move revoked_ids retrieval to _assert_revoked_token_list_matches_token_persistence?","commit_id":"70cd28fde463a8f36746bd9ed088a77e326d6468"}]}