)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1a436fc79ed3d04394b49a3f3ac0cf275e1fa3d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"name. This wasn\u0027t available before, since the name is not saved in the"},{"line_number":11,"context_line":"backend as a column, but instead it\u0027s stored as an extra attribute."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thus, this commits enables this type of search by asserting a TODO that"},{"line_number":14,"context_line":"was left in the SQL backend, and also adding the `name` attribute to the"},{"line_number":15,"context_line":"filterprotected decorator."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_5448f62d","line":13,"updated":"2014-07-31 13:58:01.000000000","message":"...this commit enables this type of search by fixing a TODO....","commit_id":"df4cb307d7be524ac205eb3ac2ca2396d3c2dedb"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"142276402faa1d578e0a9cd7b53e1d8100522e98","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_6ec5093c","line":3672,"updated":"2014-08-01 09:19:30.000000000","message":"Juan Antonio, for my education - how it works in case of KVS implementation, which ignores hints in list_services?","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"276dc8212bac6af9440e316e06c1d4f9affde800","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_649fe502","line":3672,"in_reply_to":"baada198_045d49ec","updated":"2014-08-01 12:01:18.000000000","message":"good catch! henry-nash, can you elaborate on how to add skip tests to kvs?","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"7902972d5fea9d09bb12b5e4e66ec67d2a852eec","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c9e7ef44","line":3672,"in_reply_to":"baada198_6ec5093c","updated":"2014-08-01 09:39:54.000000000","message":"For some reason, all the KVS backends actually ignore the hints, so there is no filtering done in that backend whatsoever.","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"915c56ed3894309ad2f451fc6841c4c5401b3f6d","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_045d49ec","line":3672,"in_reply_to":"baada198_81494b34","updated":"2014-08-01 11:42:16.000000000","message":"Excellent catch!  Yearh we need to improve the test, and then add skip tests in kvs etc.","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"7a65bc293691b9fc9520cfb339571d603b455135","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_81494b34","line":3672,"in_reply_to":"baada198_c9e7ef44","updated":"2014-08-01 11:19:15.000000000","message":"I found why it works. Your code tests list_services when the only one service exists, so it always returns one object in any case. If you create one more service of different type before filtering test it will fail with smth like this:\n\nFile \"keystone/tests/test_backend.py\", line 3690, in test_service_crud\n    self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])\n..\nMismatchError: \u00279934d7b9e85b49cdbe662dc8abaf8841\u0027 !\u003d \u00274ec631ba1a4447b79fb6aa2f56742b03\u0027","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"cee99405a4eb8fb238349697ab31b756c8502b70","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"                                 value\u003dnew_service[\u0027type\u0027])"},{"line_number":3670,"context_line":"        services \u003d self.catalog_api.list_services(hint_for_type)"},{"line_number":3671,"context_line":"        for service in services:"},{"line_number":3672,"context_line":"            self.assertEqual(new_service[\u0027type\u0027], service[\u0027type\u0027])"},{"line_number":3673,"context_line":""},{"line_number":3674,"context_line":"        # filter by name"},{"line_number":3675,"context_line":"        hint_for_name \u003d driver_hints.Hints()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_89a4174d","line":3672,"in_reply_to":"baada198_c9e7ef44","updated":"2014-08-01 10:02:17.000000000","message":"Right, so what\u0027s about your assert? list_services will return all services, assert should fail. I have the same situation, thinking of excluding this test from KVS tests, but in your case it works.","commit_id":"d84a0e10c5d47da1f1d2006b1f5461173bd64281"}]}