)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"d27cc231a0e67a09a7c185eeac2872ae049ef101","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To correctly issue a CADF audit event for a change in role"},{"line_number":10,"context_line":"assignments, we need to expose the context at the manager level."},{"line_number":11,"context_line":"This patch updates several tests that would have otherwise failed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"implements bp role-assignment-notifications"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_3c0af5d2","line":11,"updated":"2014-08-17 11:09:53.000000000","message":"Probably with stating that we are NOT changing the driver signatures, this it\u0027s only the manager layer that has to know about this.","commit_id":"92ff98f985c788d0a230253040856d076571f455"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To correctly issue a CADF audit event for a change in role"},{"line_number":10,"context_line":"assignments, we need to expose the context at the manager level."},{"line_number":11,"context_line":"This patch updates several tests that would have otherwise failed."},{"line_number":12,"context_line":"Note that we are *not* changing the driver signatures, just the"},{"line_number":13,"context_line":"manager needs to know the context."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_9f5cd627","line":11,"updated":"2014-08-18 01:04:59.000000000","message":"I think it\u0027s assumed that there will be test changes when the code changes, so no need to mention it.","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbcba2c1cb014054139e5ba71217ded84ff6b521","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To correctly issue a CADF audit event for a change in role"},{"line_number":10,"context_line":"assignments, we need to expose the context at the manager level."},{"line_number":11,"context_line":"This patch updates several tests that would have otherwise failed."},{"line_number":12,"context_line":"Note that we are *not* changing the driver signatures, just the"},{"line_number":13,"context_line":"manager needs to know the context."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_cb12f9b3","line":11,"in_reply_to":"1abeadc6_9f5cd627","updated":"2014-08-18 15:32:34.000000000","message":"Done","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To correctly issue a CADF audit event for a change in role"},{"line_number":10,"context_line":"assignments, we need to expose the context at the manager level."},{"line_number":11,"context_line":"This patch updates several tests that would have otherwise failed."},{"line_number":12,"context_line":"Note that we are *not* changing the driver signatures, just the"},{"line_number":13,"context_line":"manager needs to know the context."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"implements bp role-assignment-notifications"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_1f31a6ec","line":12,"updated":"2014-08-18 01:04:59.000000000","message":"is this the \"royal\" we?","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbcba2c1cb014054139e5ba71217ded84ff6b521","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To correctly issue a CADF audit event for a change in role"},{"line_number":10,"context_line":"assignments, we need to expose the context at the manager level."},{"line_number":11,"context_line":"This patch updates several tests that would have otherwise failed."},{"line_number":12,"context_line":"Note that we are *not* changing the driver signatures, just the"},{"line_number":13,"context_line":"manager needs to know the context."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"implements bp role-assignment-notifications"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_4b26e917","line":12,"in_reply_to":"1abeadc6_1f31a6ec","updated":"2014-08-18 15:32:34.000000000","message":"tweaked this a bit","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"}],"keystone/assignment/core.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            self.revoke_api.revoke_by_grant(role_id, user_id\u003duser_id,"},{"line_number":505,"context_line":"                                            project_id\u003dtenant_id)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def create_grant(self, context, role_id, user_id\u003dNone, group_id\u003dNone,"},{"line_number":508,"context_line":"                     domain_id\u003dNone, project_id\u003dNone,"},{"line_number":509,"context_line":"                     inherited_to_projects\u003dFalse):"},{"line_number":510,"context_line":"        self.driver.create_grant(role_id, user_id, group_id, domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_5f879e61","line":507,"updated":"2014-08-18 01:04:59.000000000","message":"if context was given a default then the callers wouldn\u0027t have to change.","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbcba2c1cb014054139e5ba71217ded84ff6b521","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            self.revoke_api.revoke_by_grant(role_id, user_id\u003duser_id,"},{"line_number":505,"context_line":"                                            project_id\u003dtenant_id)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def create_grant(self, context, role_id, user_id\u003dNone, group_id\u003dNone,"},{"line_number":508,"context_line":"                     domain_id\u003dNone, project_id\u003dNone,"},{"line_number":509,"context_line":"                     inherited_to_projects\u003dFalse):"},{"line_number":510,"context_line":"        self.driver.create_grant(role_id, user_id, group_id, domain_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_6b6ac51b","line":507,"in_reply_to":"1abeadc6_5f879e61","updated":"2014-08-18 15:32:34.000000000","message":"Done","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        self.driver.create_grant(role_id, user_id, group_id, domain_id,"},{"line_number":511,"context_line":"                                 project_id, inherited_to_projects)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def delete_grant(self, context, role_id, user_id\u003dNone, group_id\u003dNone,"},{"line_number":514,"context_line":"                     domain_id\u003dNone, project_id\u003dNone,"},{"line_number":515,"context_line":"                     inherited_to_projects\u003dFalse):"},{"line_number":516,"context_line":"        user_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_7f7c5a73","line":513,"updated":"2014-08-18 01:04:59.000000000","message":"if context was given a default then the callers wouldn\u0027t have to change.","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbcba2c1cb014054139e5ba71217ded84ff6b521","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        self.driver.create_grant(role_id, user_id, group_id, domain_id,"},{"line_number":511,"context_line":"                                 project_id, inherited_to_projects)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def delete_grant(self, context, role_id, user_id\u003dNone, group_id\u003dNone,"},{"line_number":514,"context_line":"                     domain_id\u003dNone, project_id\u003dNone,"},{"line_number":515,"context_line":"                     inherited_to_projects\u003dFalse):"},{"line_number":516,"context_line":"        user_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_8b772102","line":513,"in_reply_to":"1abeadc6_7f7c5a73","updated":"2014-08-18 15:32:34.000000000","message":"Done","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"}],"keystone/tests/test_auth.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.identity_api.add_user_to_group(self.user_foo[\u0027id\u0027],"},{"line_number":282,"context_line":"                                            new_group[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.assignment_api.create_grant("},{"line_number":284,"context_line":"            context\u003d{}, role_id\u003dself.role_admin[\u0027id\u0027],"},{"line_number":285,"context_line":"            group_id\u003dnew_group[\u0027id\u0027], project_id\u003dself.tenant_bar[\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        # Get a scoped token for the tenant"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_7f6e1acb","line":284,"updated":"2014-08-18 01:04:59.000000000","message":"why was the order of the arguments changed? it makes reviewing the change more difficult.","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cbcba2c1cb014054139e5ba71217ded84ff6b521","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self.identity_api.add_user_to_group(self.user_foo[\u0027id\u0027],"},{"line_number":282,"context_line":"                                            new_group[\u0027id\u0027])"},{"line_number":283,"context_line":"        self.assignment_api.create_grant("},{"line_number":284,"context_line":"            context\u003d{}, role_id\u003dself.role_admin[\u0027id\u0027],"},{"line_number":285,"context_line":"            group_id\u003dnew_group[\u0027id\u0027], project_id\u003dself.tenant_bar[\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        # Get a scoped token for the tenant"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_2bee0d89","line":284,"in_reply_to":"1abeadc6_7f6e1acb","updated":"2014-08-18 15:32:34.000000000","message":"I had initially done this to correct the order of the arguments at the same time, but with your suggestion of defaulting context at the manager level, it\u0027s no longer necessary. I\u0027m resetting all changes to the tests.","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"}],"keystone/tests/test_backend.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        self.assertIn(self.role_other[\u0027id\u0027], roles_ids)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Now delete both grants for user1"},{"line_number":679,"context_line":"        self.assignment_api.delete_grant(context\u003d{},"},{"line_number":680,"context_line":"                                         user_id\u003dnew_user1[\u0027id\u0027],"},{"line_number":681,"context_line":"                                         domain_id\u003dnew_domain[\u0027id\u0027],"},{"line_number":682,"context_line":"                                         role_id\u003d\u0027member\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_3f9bc2ca","line":679,"updated":"2014-08-18 01:04:59.000000000","message":"thank you for not changing the order of the arguments... so much easier to review!","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"7711662cfd8ba6650b887272d26652e0e8bff4d4","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.assertEqual(0, len(roles_ref))"},{"line_number":881,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":882,"context_line":"                          self.assignment_api.delete_grant,"},{"line_number":883,"context_line":"                          context\u003d{},"},{"line_number":884,"context_line":"                          group_id\u003dnew_group[\u0027id\u0027],"},{"line_number":885,"context_line":"                          domain_id\u003dnew_domain[\u0027id\u0027],"},{"line_number":886,"context_line":"                          role_id\u003d\u0027member\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_3f82e252","line":883,"updated":"2014-08-18 01:04:59.000000000","message":"nice!","commit_id":"066cd7958c12c83242329750ddf86daf234acc91"}]}