)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":6282,"name":"Wu Wenxiang","email":"wu.wenxiang@algoblu.com","username":"wu-wenxiang"},"change_message_id":"7de66917cb20c7786a83f3c9067226d69adf1a62","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"        finally:"},{"line_number":1406,"context_line":"            conn.unbind_s()"},{"line_number":1407,"context_line":""},{"line_number":1408,"context_line":"    def _ldap_get_list(self, search_base, scope, query_params\u003dNone,"},{"line_number":1409,"context_line":"                       attrlist\u003dNone):"},{"line_number":1410,"context_line":"        conn \u003d self.get_connection()"},{"line_number":1411,"context_line":"        query \u003d u\u0027(objectClass\u003d%s)\u0027 % self.object_class"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_ae7c6cb6","line":1408,"updated":"2014-09-03 08:44:14.000000000","message":"Prefer correting the default value of attrlist to [] if None could raise a exception","commit_id":"dbd85f95f3289658b0eff238a6a5514f86da6b2a"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"a91105fa838eec1ac678b5463007dc0c9c0e6a6e","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"        finally:"},{"line_number":1406,"context_line":"            conn.unbind_s()"},{"line_number":1407,"context_line":""},{"line_number":1408,"context_line":"    def _ldap_get_list(self, search_base, scope, query_params\u003dNone,"},{"line_number":1409,"context_line":"                       attrlist\u003dNone):"},{"line_number":1410,"context_line":"        conn \u003d self.get_connection()"},{"line_number":1411,"context_line":"        query \u003d u\u0027(objectClass\u003d%s)\u0027 % self.object_class"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_d9592b36","line":1408,"in_reply_to":"fa98f980_ae7c6cb6","updated":"2014-09-05 08:17:50.000000000","message":"So, your proposal is change attrlist\u003dNone to attrlist\u003d[] on function header, is it?\n\nThen, do you want to raise an exception in case the value sent in attrlist would be None?","commit_id":"dbd85f95f3289658b0eff238a6a5514f86da6b2a"}]}