)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        tenantName"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        return dict((k, v) for k, v in self.__dict__.iteritems()"},{"line_number":95,"context_line":"                    if not k[0] \u003d\u003d \u0027_\u0027)"},{"line_number":96,"context_line":"        #return dict([(k, getattr(self, k)) for k in self])"},{"line_number":97,"context_line":"        #local \u003d dict(self)"},{"line_number":98,"context_line":"        #joined \u003d dict([(k, v) for k, v in self.__dict__.iteritems()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FY%3D","line":95,"updated":"2012-08-20 15:36:33.000000000","message":"Easier to read as:\n\n    if k[0] !\u003d \u0027_\u0027","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"}],"keystone/identity/backends/kvs.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    return user_ref"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _metadata_match_user_id(db, key):"},{"line_number":40,"context_line":"    metadata_refs \u003d dict((k, v) for k, v in db.items() if"},{"line_number":41,"context_line":"                         k.startswith(\"metadata-\"))"},{"line_number":42,"context_line":"    result \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FU%3D","line":39,"updated":"2012-08-20 15:36:33.000000000","message":"Can you add a doc string to explain what this does? Neither the function name nor local var names make it obvious.\n\nIs this even used in more than one place? Should it need to be an extracted function?","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"}],"keystone/identity/backends/ldap/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        return user_list"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def get_roles_for_user(self, user_id):"},{"line_number":178,"context_line":"        raise NotImplementedError()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def get_roles_for_user_and_tenant(self, user_id, tenant_id):"},{"line_number":181,"context_line":"        self.get_user(user_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FQ%3D","line":178,"updated":"2012-08-20 15:36:33.000000000","message":"Instead:\n\n    raise exception.NotImplemented()","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"}],"keystone/identity/backends/sql.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    def get_user_by_name(self, user_name):"},{"line_number":229,"context_line":"        return _filter_user(self._get_user_by_name(user_name))"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def get_metadata(self, user_id, tenant_id\u003dNone):"},{"line_number":232,"context_line":"        session \u003d self.get_session()"},{"line_number":233,"context_line":"        if tenant_id is not None:"},{"line_number":234,"context_line":"            metadata_ref \u003d session.query(Metadata)\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FI%3D","line":231,"updated":"2012-08-20 15:36:33.000000000","message":"So this can now return either a single ref OR a list? Not cool.","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"}],"keystone/identity/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        raise exception.NotImplemented()"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def get_roles_for_user(self, user_id):"},{"line_number":177,"context_line":"        \"\"\"Get the role list and associated tenant of the user"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        :returns: a list of role ids and associated tenant name"},{"line_number":180,"context_line":"        :raises: keystone.exception.UserNotFound"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FE%3D","line":177,"updated":"2012-08-20 15:36:33.000000000","message":"\"associated tenant of the user\"? Based on what association? Please revise to be more specific.","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"be9213949d178e0a50881d8d8a3322ab04dc3d06","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    # COMPAT(essex-3)"},{"line_number":541,"context_line":"    def get_user_roles(self, context, user_id, tenant_id\u003dNone):"},{"line_number":542,"context_line":"        \"\"\"Get the roles for a user and tenant pair."},{"line_number":543,"context_line":"        Without tenant_id, we\u0027ll get the user\u0027s all roles."},{"line_number":544,"context_line":"        \"\"\""},{"line_number":545,"context_line":"        self.assert_admin(context)"},{"line_number":546,"context_line":"        if tenant_id is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fr%2FA%3D","line":543,"updated":"2012-08-20 15:36:33.000000000","message":"What\u0027s an \"all role\"?","commit_id":"6744aaad56ffd2913757601d6764f4311a1cc340"}]}
