)]}'
{"keystone/common/ldap/core.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"a9fc88e9d406c08fa6dee0510acedd3fea04832b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    :raises: UnicodeDecodeError for invalid UTF-8 encoding"},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    if isinstance(value, six.binary_type):"},{"line_number":84,"context_line":"        return _utf8_decoder(value, \u0027replace\u0027)[0]"},{"line_number":85,"context_line":"    return six.text_type(value)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_9075c965","line":84,"updated":"2014-09-04 18:16:17.000000000","message":"so instead of handling non-utf8 characters, this is going to return garbage data... i don\u0027t think that\u0027s a fix. why is your server returning non-utf8 and is should the encoding be configurable instead?\n\nif returning garbage is the correct solution, this should use the keyword argument\n\n  errors\u003d\u0027replace\u0027\n\nand contain an inline comment explaining why it\u0027s safe to trash the data we can\u0027t decode properly.","commit_id":"10efa3d9e0998b6bb4dfed152ec84cebe382f86d"}]}